Ecommerce\DeliveryProvider\RussianPost

Complexity

Total Complexity

16

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	6
Bugs	3	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	calcPrice()	0	9	3
C	request()	0	35	7
B	deliveryTime()	0	20	5
A	availablePayTypeGroups()	0	3	1

<?php
/**
 * INJI
 *
 * @author Alexey Krupskiy <admin@inji.ru>
 * @link http://inji.ru/
 * @copyright 2017 Alexey Krupskiy
 * @license https://github.com/injitools/Inji/blob/master/LICENSE
 */

namespace Ecommerce\DeliveryProvider;


use Ecommerce\UserAdds\Field;

class RussianPost extends \Ecommerce\DeliveryProvider {
    static $name = 'PickPoint - курьерская служба';

The visibility should be declared for property $name.

    static function request($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $city = '';
        foreach ($cart->deliveryInfos as $deliveryInfo) {
            if ($deliveryInfo->field->code == 'index') {
                $city = $deliveryInfo->value;
            }
        }
        if (!$city) {
            $cityItem = static::getCity($cart);
            if ($cityItem) {
                $data = json_decode($cityItem->data, true);
                if (!empty($data['PostCodeList'])) {
                    $city = explode(',', $data['PostCodeList'])[0];
                }
            }
        }
        if (!$city) {
            return [];
        }
        $senderCity = '101000';

        $data = [
            'object' => 4030,
            'weight' => '3000',
            'date' => date('Ymd'),
            //'sumoc' => $cart->itemsSum()->sums[0],

74% of this comment could be valid code. Did you maybe forget this after debugging?

            'from' => $senderCity,
            'to' => $city,
            'delivery' => 1,
        ];
        $result = \Cache::get('russianPostCalc', $data, function ($data) {
            return file_get_contents('http://tariff.russianpost.ru/tariff/v1/calculate?json&' . http_build_query($data));
        }, 4 * 60 * 60);
        return json_decode($result, true);
    }

    static function calcPrice($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = static::request($cart);
        $curId = $cart->delivery ? $cart->delivery->currency_id : 0;
        if (empty($result['paynds'])) {
            return new \Money\Sums([$curId => 0]);
        }
        $sum = $result['paynds'];
        return new \Money\Sums([$curId => round($sum / 100 * 1.1, 2)]);
    }

    static function deliveryTime($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $result = static::request($cart);

        if (!empty($result['delivery'])) {
            return $result['delivery'];
        }
        if (!empty($result['from']) && !empty($result['to'])) {
            $url = "http://postcalc.ru/web.php?Extended=1&Output=json&From={$result['from']}&Weight=3000&Valuation=0&Step=0&Date=22.11.2017&IBase=p&ProcessingFee=0&PackingFee=0&Round=0.01&VAT=1&To={$result['to']}";
            $result = \Cache::get('russianPostTimeCalc', $url, function ($data) {
                return file_get_contents($data);
            }, 4 * 60 * 60);
            $result = json_decode($result, true);
            if (!empty($result['ПростаяБандероль']['СрокДоставки'])) {
                return ['min' => $result['ПростаяБандероль']['СрокДоставки']];
            }


        }
        return ['min' => 0, 'max' => 0];
    }

    static function availablePayTypeGroups($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        return ['online'];
    }
}