Sums::greater() - Code Metrics - Inspection of "fix" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( faf894...f88301 )

by Alexey

created 2016-03-20 07:08 UTC

Sums::greater() A

↳ Parent: Sums

Complexity

Conditions	3
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	3
Ratio	50 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	3
loc	6
rs	9.4285
cc	3
eloc	3
nc	2
nop	1

<?php

/**
 * Money sums comparator
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2016 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */

namespace Money;

class Sums extends \Object
{
    public $sums = [];

    public function __construct($sums)
    {
        $this->sums = $sums;
    }

    function plus(Sums $sums)

    {
        $newSums = $this->sums;
        foreach ($sums->sums as $currency_id => $sum) {
            $newSums[$currency_id] = isset($newSums[$currency_id]) ? $newSums[$currency_id] + $sum : $sum;
        }
        return new Sums($newSums);
    }

    function minus(Sums $sums)

    {
        $newSums = $this->sums;
        foreach ($sums->sums as $currency_id => $sum) {
            $newSums[$currency_id] = isset($newSums[$currency_id]) ? $newSums[$currency_id] - $sum : -$sum;
        }
        return new Sums($newSums);
    }

//Equal, Less and Greater
    public function greater(Sums $sums)
    {
        if (count($this->sums) == count($sums->sums) && isset($sums->sums[key($this->sums)])) {

            return current($this->sums) > current($sums->sums);
        }
    }

    public function equal(Sums $sums)
    {
        if (count($this->sums) == count($sums->sums) && isset($sums->sums[key($this->sums)])) {

            return current($this->sums) == current($sums->sums);
        }
    }

    function __toString()

    {
        $string = '';
        $first = true;
        foreach ($this->sums as $currency_id => $sum) {
            if ($first) {
                $first = false;
            } else {
                $string.= '<br />';
            }
            $string.= '<span style="white-space:nowrap;">';
            $string.= number_format($sum, 2, '.', ' ');
            if (\App::$cur->money) {
                $currency = \Money\Currency::get($currency_id);
                if ($currency) {
                    $string.= ' ' . $currency->acronym();
                } else {
                    $string.= ' руб.';
                }
            } else {
                $string.= ' руб.';
            }
            $string.= '</span>';
        }
        return $string;
    }

}


1		<?php
2
3		/**
4		* Money sums comparator
5		*
6		* @author Alexey Krupskiy <[email protected]>
7		* @link http://inji.ru/
8		* @copyright 2016 Alexey Krupskiy
9		* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10		*/
11
12		namespace Money;
13
14		class Sums extends \Object
15		{
16		public $sums = [];
17
18		public function __construct($sums)
19		{
20		$this->sums = $sums;
21		}
22
23	View Code Duplication	function plus(Sums $sums)
		0 ignored issues – show Best Practice introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
24		{
25		$newSums = $this->sums;
26		foreach ($sums->sums as $currency_id => $sum) {
27		$newSums[$currency_id] = isset($newSums[$currency_id]) ? $newSums[$currency_id] + $sum : $sum;
28		}
29		return new Sums($newSums);
30		}
31
32	View Code Duplication	function minus(Sums $sums)
		0 ignored issues – show Best Practice introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
33		{
34		$newSums = $this->sums;
35		foreach ($sums->sums as $currency_id => $sum) {
36		$newSums[$currency_id] = isset($newSums[$currency_id]) ? $newSums[$currency_id] - $sum : -$sum;
37		}
38		return new Sums($newSums);
39		}
40
41		//Equal, Less and Greater
42		public function greater(Sums $sums)
43		{
44	View Code Duplication	if (count($this->sums) == count($sums->sums) && isset($sums->sums[key($this->sums)])) {
		0 ignored issues – show Duplication introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		return current($this->sums) > current($sums->sums);
46		}
47		}
48
49		public function equal(Sums $sums)
50		{
51	View Code Duplication	if (count($this->sums) == count($sums->sums) && isset($sums->sums[key($this->sums)])) {
		0 ignored issues – show Duplication introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
52		return current($this->sums) == current($sums->sums);
53		}
54		}
55
56		function __toString()
		0 ignored issues – show Best Practice introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
57		{
58		$string = '';
59		$first = true;
60		foreach ($this->sums as $currency_id => $sum) {
61		if ($first) {
62		$first = false;
63		} else {
64		$string.= '<br />';
65		}
66		$string.= '<span style="white-space:nowrap;">';
67		$string.= number_format($sum, 2, '.', ' ');
68		if (\App::$cur->money) {
69		$currency = \Money\Currency::get($currency_id);
70		if ($currency) {
71		$string.= ' ' . $currency->acronym();
72		} else {
73		$string.= ' руб.';
74		}
75		} else {
76		$string.= ' руб.';
77		}
78		$string.= '</span>';
79		}
80		return $string;
81		}
82
83		}
84

injitools / cms-Inji

Push — master ( faf894...f88301 )

Sums::greater() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like