Cart::itemName() - Code Metrics - Inspection of "fix" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( faf894...f88301 )

by Alexey

created 2016-03-20 07:08 UTC

Cart::itemName() A

↳ Parent: Cart

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

/**
 * Cart
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */

namespace Ecommerce;

class Cart extends \Model
{
    public static $objectName = 'Корзины';

    public static function indexes()
    {
        return [
            'ecommerce_cartStatusBlock' => [
                'type' => 'INDEX',
                'cols' => [
                    'cart_cart_status_id',
                    'cart_warehouse_block'
                ]
            ],
            'ecommerce_cartStats' => [
                'type' => 'INDEX',
                'cols' => [
                    'cart_cart_status_id',
                ]
            ],
            'ecommerce_cartBlock' => [
                'type' => 'INDEX',
                'cols' => [
                    'cart_warehouse_block'
                ]
            ],
        ];
    }

    public static function relations()
    {
        return [
            'user' => [
                'model' => 'Users\User',
                'col' => 'user_id'
            ],
            'cartItems' => [
                'type' => 'many',
                'model' => 'Ecommerce\Cart\Item',
                'col' => 'cart_id',
            ],
            'events' => [
                'type' => 'many',
                'model' => 'Ecommerce\Cart\Event',
                'col' => 'cart_id',
            ],
            'status' => [
                'model' => 'Ecommerce\Cart\Status',
                'col' => 'cart_status_id'
            ],
            'delivery' => [
                'model' => 'Ecommerce\Delivery',
                'col' => 'delivery_id'
            ],
            'payType' => [
                'model' => 'Ecommerce\PayType',
                'col' => 'paytype_id'
            ],
            'infos' => [
                'type' => 'many',
                'model' => 'Ecommerce\Cart\Info',
                'col' => 'cart_id'
            ],
            'deliveryInfos' => [
                'type' => 'many',
                'model' => 'Ecommerce\Cart\DeliveryInfo',
                'col' => 'cart_id'
            ],
            'extras' => [
                'type' => 'many',
                'model' => 'Ecommerce\Cart\Extra',
                'col' => 'cart_id'
            ],
            'card' => [
                'model' => 'Ecommerce\Card\Item',
                'col' => 'card_item_id'
            ],
            'pays' => [
                'type' => 'many',
                'model' => 'Money\Pay',
                'col' => 'data'
            ],
            'discounts' => [
                'type' => 'relModel',
                'relModel' => 'Ecommerce\Cart\Discount',
                'model' => 'Ecommerce\Discount',
            ]
        ];
    }

    public function beforeDelete()
    {
        foreach ($this->cartItems as $cartItem) {
            $cartItem->delete();
        }
        foreach ($this->infos as $info) {
            $info->delete();
        }
        foreach ($this->extras as $extra) {
            $extra->delete();
        }
        foreach ($this->events as $event) {
            $event->delete();
        }
    }

    public static $labels = [
        'user_id' => 'Пользователь',
        'cart_status_id' => 'Статус',
        'delivery_id' => 'Доставка',
        'comment' => 'Комментарий',
        'bonus_used' => 'Выгодные рубли',
        'complete_data' => 'Время заказа',
        'info' => 'Информация',
        'items' => 'Товары',
        'paytype_id' => 'Способ оплаты',
        'payed' => 'Оплачен',
        'exported' => 'Выгружено',
        'warehouse_block' => 'Блокировка товаров',
        'extra' => 'Доп.',
        'card_item_id' => 'Дисконтная карта',
        'info' => 'Информация',
        'contacts' => 'Информация',
        'pay' => 'Счета',
        'sums' => 'Суммы',
        'deliveryInfo' => 'Для доставки',
        'discount' => 'Скидки',
    ];
    public static $cols = [
        //Основные параметры
        'user_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'user'],
        'cart_status_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'status'],
        'delivery_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'delivery'],
        'paytype_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'payType'],
        'card_item_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'card'],
        'warehouse_block' => ['type' => 'bool'],
        'payed' => ['type' => 'bool'],
        'comment' => ['type' => 'textarea'],
        //Системные
        'exported' => ['type' => 'bool'],
        'complete_data' => ['type' => 'dateTime'],
        'date_status' => ['type' => 'dateTime'],
        'date_last_activ' => ['type' => 'dateTime'],
        'date_create' => ['type' => 'dateTime'],
        //Виджеты
        'sums' => [
            'type' => 'void',
            'view' => [
                'type' => 'widget',
                'widget' => 'Ecommerce\adminSums',
            ],
        ],
        'contacts' => [
            'type' => 'void',
            'view' => [
                'type' => 'widget',
                'widget' => 'Ecommerce\admin/contacts',
            ],
        ],
        //Менеджеры
        'extra' => ['type' => 'dataManager', 'relation' => 'extras'],
        'pay' => ['type' => 'dataManager', 'relation' => 'pays'],
        'items' => ['type' => 'dataManager', 'relation' => 'cartItems'],
        'info' => ['type' => 'dataManager', 'relation' => 'infos'],
        'deliveryInfo' => ['type' => 'dataManager', 'relation' => 'deliveryInfos'],
        'discount' => ['type' => 'dataManager', 'relation' => 'discounts'],
    ];
    public static $dataManagers = [
        'manager' => [
            'cols' => [
                'contacts',
                'items',
                'extra',
                'discount',
                'sums',
                'cart_status_id',
                'delivery_id',
                'deliveryInfo',
                'payed',
                'pay',
                'complete_data',
            ],
            'sortable' => [
                'cart_status_id',
                'delivery_id',
                'payed',
                'complete_data',
            ],
            'filters' => [
                'cart_status_id',
                'delivery_id',
                'payed',
                'complete_data',
            ],
            'preSort' => [
                'complete_data' => 'desc'
            ],
            'actions' => [
                'Ecommerce\CloseCartBtn', 'Open', 'Edit', 'Delete'
            ]
        ]
    ];

    public static function itemName($item)
    {
        return $item->pk() . '. ' . $item->name();
    }

    public static $forms = [
        'manager' => [
            'inputs' => [
                'userSearch' => [
                    'type' => 'search',
                    'source' => 'relation',
                    'relation' => 'user',
                    'label' => 'Покупатель',
                    'cols' => [
                        'info:first_name',
                        'info:last_name',
                        'info:middle_name',
                        'mail'
                    ],
                    'col' => 'user_id',
                    'required' => true,
                    'showCol' => [
                        'type' => 'staticMethod',
                        'class' => 'Ecommerce\Cart',
                        'method' => 'itemName',
                    ],
                ],
                'cardSearch' => [
                    'type' => 'search',
                    'source' => 'relation',
                    'relation' => 'card',
                    'label' => 'Дисконтная карта',
                    'cols' => [
                        'code',
                        'user:info:first_name',
                        'user:info:last_name',
                        'user:info:middle_name',
                        'user:mail'
                    ],
                    'col' => 'card_item_id',
                ],
            ],
            'map' => [
                ['userSearch', 'cart_status_id'],
                ['paytype_id', 'delivery_id'],
                ['cardSearch', 'comment'],
                ['warehouse_block', 'complete_data'],
                ['payed'],
                ['items'],
                ['extra'],
                ['pay'],
                ['info'],
                ['deliveryInfo']
            ]
        ],
    ];

    public function checkStage()
    {
        $sum = $this->itemsSum();
        $stages = Cart\Stage::getList(['order' => ['sum', 'asc']]);
        $curStage = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $groups = [];
        foreach ($stages as $stage) {
            if ($sum->greater(new \Money\Sums([$stage->currency_id => $stage->sum])) || $sum->equal(new \Money\Sums([$stage->currency_id => $stage->sum]))) {
                $groups[$stage->group] = $stage;
            }
        }
        $discounts = Cart\Discount::getList(['where'=>['cart_id',$this->id]]);
        foreach ($discounts as $discount) {
            if (!isset($groups[$discount->group]) && $discount->auto) {
                $discount->delete();
            }
            if (isset($groups[$discount->group]) && $groups[$discount->group]->type == 'discount') {
                $discount->discount_id = $groups[$discount->group]->value;
                $discount->save();
                unset($groups[$discount->group]);
            }
        }
        foreach ($groups as $group) {
            if ($group && $group->type == 'discount') {
                $rel = $this->addRelation('discounts', $group->value);
                $rel->auto = true;
                $rel->group = 'discount';
                $rel->save();

            }
        }
    }

    public function needDelivery()
    {
        foreach ($this->cartItems as $cartItem) {
            if ($cartItem->item->type && $cartItem->item->type->delivery) {
                return true;
            }
        }
        return false;
    }

    public function deliverySum()
    {
        $sum = new \Money\Sums([]);
        if ($this->needDelivery()) {
            $sums = new \Money\Sums($this->itemsSum());
            $deliveryPrice = new \Money\Sums([$this->delivery->currency_id => $this->delivery->max_cart_price]);
            if ($sums->greater($deliveryPrice) || $sums->equal($deliveryPrice)) {
                $sum->sums = [$this->delivery->currency_id => 0];
            } else {
                $sum->sums = [$this->delivery->currency_id => $this->delivery->price];
            }
        }
        return $sum;
    }

    public function hasDiscount()
    {
        return (bool) $this->card || $this->discounts;
    }

    public function discountSum()
    {
        $sums = [];
        foreach ($this->cartItems as $cartItem) {
            $sums[$cartItem->price->currency_id] = isset($sums[$cartItem->price->currency_id]) ? $sums[$cartItem->price->currency_id] + $cartItem->discount() : $cartItem->discount();
        }
        return new \Money\Sums($sums);
    }

    public function finalSum()
    {
        $sums = $this->itemsSum();
        $sums = $sums->minus($this->discountSum());
        $sums = $sums->plus($this->deliverySum());
        return $sums;
    }

    public function itemsSum()
    {
        $cart = Cart::get($this->id);
        $sums = [];
        foreach ($cart->cartItems as $cartItem) {
            if (!$cartItem->price) {
                continue;
            }
            $sums[$cartItem->price->currency_id] = isset($sums[$cartItem->price->currency_id]) ? $sums[$cartItem->price->currency_id] + $cartItem->price->price * $cartItem->count : $cartItem->price->price * $cartItem->count;
        }
        return new \Money\Sums($sums);
    }

    public function addItem($offer_price_id, $count = 1, $final_price = 0)
    {
        $price = Item\Offer\Price::get((int) $offer_price_id);

        if (!$price) {
            return false;
        }

        if ($count <= 0) {
            $count = 1;
        }

        $cartItem = new Cart\Item();
        $cartItem->cart_id = $this->id;
        $cartItem->item_id = $price->offer->item->id;
        $cartItem->count = $count;
        $cartItem->item_offer_price_id = $price->id;
        $cartItem->final_price = $final_price ? $final_price : $price->price;
        $cartItem->save();
        return true;
    }

    public function calc($save = true)
    {
        if ($save) {
            $this->save();
        }
    }

}


1			<?php
2
3			/**
4			* Cart
5			*
6			* @author Alexey Krupskiy <[email protected]>
7			* @link http://inji.ru/
8			* @copyright 2015 Alexey Krupskiy
9			* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10			*/
11
12			namespace Ecommerce;
13
14			class Cart extends \Model
15			{
16			public static $objectName = 'Корзины';
17
18			public static function indexes()
19			{
20			return [
21			'ecommerce_cartStatusBlock' => [
22			'type' => 'INDEX',
23			'cols' => [
24			'cart_cart_status_id',
25			'cart_warehouse_block'
26			]
27			],
28			'ecommerce_cartStats' => [
29			'type' => 'INDEX',
30			'cols' => [
31			'cart_cart_status_id',
32			]
33			],
34			'ecommerce_cartBlock' => [
35			'type' => 'INDEX',
36			'cols' => [
37			'cart_warehouse_block'
38			]
39			],
40			];
41			}
42
43			public static function relations()
44			{
45			return [
46			'user' => [
47			'model' => 'Users\User',
48			'col' => 'user_id'
49			],
50			'cartItems' => [
51			'type' => 'many',
52			'model' => 'Ecommerce\Cart\Item',
53			'col' => 'cart_id',
54			],
55			'events' => [
56			'type' => 'many',
57			'model' => 'Ecommerce\Cart\Event',
58			'col' => 'cart_id',
59			],
60			'status' => [
61			'model' => 'Ecommerce\Cart\Status',
62			'col' => 'cart_status_id'
63			],
64			'delivery' => [
65			'model' => 'Ecommerce\Delivery',
66			'col' => 'delivery_id'
67			],
68			'payType' => [
69			'model' => 'Ecommerce\PayType',
70			'col' => 'paytype_id'
71			],
72			'infos' => [
73			'type' => 'many',
74			'model' => 'Ecommerce\Cart\Info',
75			'col' => 'cart_id'
76			],
77			'deliveryInfos' => [
78			'type' => 'many',
79			'model' => 'Ecommerce\Cart\DeliveryInfo',
80			'col' => 'cart_id'
81			],
82			'extras' => [
83			'type' => 'many',
84			'model' => 'Ecommerce\Cart\Extra',
85			'col' => 'cart_id'
86			],
87			'card' => [
88			'model' => 'Ecommerce\Card\Item',
89			'col' => 'card_item_id'
90			],
91			'pays' => [
92			'type' => 'many',
93			'model' => 'Money\Pay',
94			'col' => 'data'
95			],
96			'discounts' => [
97			'type' => 'relModel',
98			'relModel' => 'Ecommerce\Cart\Discount',
99			'model' => 'Ecommerce\Discount',
100			]
101			];
102			}
103
104			public function beforeDelete()
105			{
106			foreach ($this->cartItems as $cartItem) {
107			$cartItem->delete();
108			}
109			foreach ($this->infos as $info) {
110			$info->delete();
111			}
112			foreach ($this->extras as $extra) {
113			$extra->delete();
114			}
115			foreach ($this->events as $event) {
116			$event->delete();
117			}
118			}
119
120			public static $labels = [
121			'user_id' => 'Пользователь',
122			'cart_status_id' => 'Статус',
123			'delivery_id' => 'Доставка',
124			'comment' => 'Комментарий',
125			'bonus_used' => 'Выгодные рубли',
126			'complete_data' => 'Время заказа',
127			'info' => 'Информация',
128			'items' => 'Товары',
129			'paytype_id' => 'Способ оплаты',
130			'payed' => 'Оплачен',
131			'exported' => 'Выгружено',
132			'warehouse_block' => 'Блокировка товаров',
133			'extra' => 'Доп.',
134			'card_item_id' => 'Дисконтная карта',
135			'info' => 'Информация',
136			'contacts' => 'Информация',
137			'pay' => 'Счета',
138			'sums' => 'Суммы',
139			'deliveryInfo' => 'Для доставки',
140			'discount' => 'Скидки',
141			];
142			public static $cols = [
143			//Основные параметры
144			'user_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'user'],
145			'cart_status_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'status'],
146			'delivery_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'delivery'],
147			'paytype_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'payType'],
148			'card_item_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'card'],
149			'warehouse_block' => ['type' => 'bool'],
150			'payed' => ['type' => 'bool'],
151			'comment' => ['type' => 'textarea'],
152			//Системные
153			'exported' => ['type' => 'bool'],
154			'complete_data' => ['type' => 'dateTime'],
155			'date_status' => ['type' => 'dateTime'],
156			'date_last_activ' => ['type' => 'dateTime'],
157			'date_create' => ['type' => 'dateTime'],
158			//Виджеты
159			'sums' => [
160			'type' => 'void',
161			'view' => [
162			'type' => 'widget',
163			'widget' => 'Ecommerce\adminSums',
164			],
165			],
166			'contacts' => [
167			'type' => 'void',
168			'view' => [
169			'type' => 'widget',
170			'widget' => 'Ecommerce\admin/contacts',
171			],
172			],
173			//Менеджеры
174			'extra' => ['type' => 'dataManager', 'relation' => 'extras'],
175			'pay' => ['type' => 'dataManager', 'relation' => 'pays'],
176			'items' => ['type' => 'dataManager', 'relation' => 'cartItems'],
177			'info' => ['type' => 'dataManager', 'relation' => 'infos'],
178			'deliveryInfo' => ['type' => 'dataManager', 'relation' => 'deliveryInfos'],
179			'discount' => ['type' => 'dataManager', 'relation' => 'discounts'],
180			];
181			public static $dataManagers = [
182			'manager' => [
183			'cols' => [
184			'contacts',
185			'items',
186			'extra',
187			'discount',
188			'sums',
189			'cart_status_id',
190			'delivery_id',
191			'deliveryInfo',
192			'payed',
193			'pay',
194			'complete_data',
195			],
196			'sortable' => [
197			'cart_status_id',
198			'delivery_id',
199			'payed',
200			'complete_data',
201			],
202			'filters' => [
203			'cart_status_id',
204			'delivery_id',
205			'payed',
206			'complete_data',
207			],
208			'preSort' => [
209			'complete_data' => 'desc'
210			],
211			'actions' => [
212			'Ecommerce\CloseCartBtn', 'Open', 'Edit', 'Delete'
213			]
214			]
215			];
216
217			public static function itemName($item)
218			{
219			return $item->pk() . '. ' . $item->name();
220			}
221
222			public static $forms = [
223			'manager' => [
224			'inputs' => [
225			'userSearch' => [
226			'type' => 'search',
227			'source' => 'relation',
228			'relation' => 'user',
229			'label' => 'Покупатель',
230			'cols' => [
231			'info:first_name',
232			'info:last_name',
233			'info:middle_name',
234			'mail'
235			],
236			'col' => 'user_id',
237			'required' => true,
238			'showCol' => [
239			'type' => 'staticMethod',
240			'class' => 'Ecommerce\Cart',
241			'method' => 'itemName',
242			],
243			],
244			'cardSearch' => [
245			'type' => 'search',
246			'source' => 'relation',
247			'relation' => 'card',
248			'label' => 'Дисконтная карта',
249			'cols' => [
250			'code',
251			'user:info:first_name',
252			'user:info:last_name',
253			'user:info:middle_name',
254			'user:mail'
255			],
256			'col' => 'card_item_id',
257			],
258			],
259			'map' => [
260			['userSearch', 'cart_status_id'],
261			['paytype_id', 'delivery_id'],
262			['cardSearch', 'comment'],
263			['warehouse_block', 'complete_data'],
264			['payed'],
265			['items'],
266			['extra'],
267			['pay'],
268			['info'],
269			['deliveryInfo']
270			]
271			],
272			];
273
274			public function checkStage()
275			{
276			$sum = $this->itemsSum();
277			$stages = Cart\Stage::getList(['order' => ['sum', 'asc']]);
278			$curStage = false;
			0 ignored issues – show Unused Code introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report `$curStage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
279			$groups = [];
280			foreach ($stages as $stage) {
281			if ($sum->greater(new \Money\Sums([$stage->currency_id => $stage->sum])) \|\| $sum->equal(new \Money\Sums([$stage->currency_id => $stage->sum]))) {
282			$groups[$stage->group] = $stage;
283			}
284			}
285			$discounts = Cart\Discount::getList(['where'=>['cart_id',$this->id]]);
286			foreach ($discounts as $discount) {
287			if (!isset($groups[$discount->group]) && $discount->auto) {
288			$discount->delete();
289			}
290			if (isset($groups[$discount->group]) && $groups[$discount->group]->type == 'discount') {
291			$discount->discount_id = $groups[$discount->group]->value;
292			$discount->save();
293			unset($groups[$discount->group]);
294			}
295			}
296			foreach ($groups as $group) {
297			if ($group && $group->type == 'discount') {
298			$rel = $this->addRelation('discounts', $group->value);
299			$rel->auto = true;
300			$rel->group = 'discount';
301			$rel->save();
			0 ignored issues – show Bug introduced 2016-03-20 07:13 UTC by Report Bug Copy Issue Report The method `save` cannot be called on `$rel` (of type `boolean`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
302			}
303			}
304			}
305
306			public function needDelivery()
307			{
308			foreach ($this->cartItems as $cartItem) {
309			if ($cartItem->item->type && $cartItem->item->type->delivery) {
310			return true;
311			}
312			}
313			return false;
314			}
315
316			public function deliverySum()
317			{
318			$sum = new \Money\Sums([]);
319			if ($this->needDelivery()) {
320			$sums = new \Money\Sums($this->itemsSum());
321			$deliveryPrice = new \Money\Sums([$this->delivery->currency_id => $this->delivery->max_cart_price]);
322			if ($sums->greater($deliveryPrice) \|\| $sums->equal($deliveryPrice)) {
323			$sum->sums = [$this->delivery->currency_id => 0];
324			} else {
325			$sum->sums = [$this->delivery->currency_id => $this->delivery->price];
326			}
327			}
328			return $sum;
329			}
330
331			public function hasDiscount()
332			{
333			return (bool) $this->card \|\| $this->discounts;
334			}
335
336			public function discountSum()
337			{
338			$sums = [];
339			foreach ($this->cartItems as $cartItem) {
340			$sums[$cartItem->price->currency_id] = isset($sums[$cartItem->price->currency_id]) ? $sums[$cartItem->price->currency_id] + $cartItem->discount() : $cartItem->discount();
341			}
342			return new \Money\Sums($sums);
343			}
344
345			public function finalSum()
346			{
347			$sums = $this->itemsSum();
348			$sums = $sums->minus($this->discountSum());
349			$sums = $sums->plus($this->deliverySum());
350			return $sums;
351			}
352
353			public function itemsSum()
354			{
355			$cart = Cart::get($this->id);
356			$sums = [];
357			foreach ($cart->cartItems as $cartItem) {
358			if (!$cartItem->price) {
359			continue;
360			}
361			$sums[$cartItem->price->currency_id] = isset($sums[$cartItem->price->currency_id]) ? $sums[$cartItem->price->currency_id] + $cartItem->price->price * $cartItem->count : $cartItem->price->price * $cartItem->count;
362			}
363			return new \Money\Sums($sums);
364			}
365
366			public function addItem($offer_price_id, $count = 1, $final_price = 0)
367			{
368			$price = Item\Offer\Price::get((int) $offer_price_id);
369
370			if (!$price) {
371			return false;
372			}
373
374			if ($count <= 0) {
375			$count = 1;
376			}
377
378			$cartItem = new Cart\Item();
379			$cartItem->cart_id = $this->id;
380			$cartItem->item_id = $price->offer->item->id;
381			$cartItem->count = $count;
382			$cartItem->item_offer_price_id = $price->id;
383			$cartItem->final_price = $final_price ? $final_price : $price->price;
384			$cartItem->save();
385			return true;
386			}
387
388			public function calc($save = true)
389			{
390			if ($save) {
391			$this->save();
392			}
393			}
394
395			}
396

injitools / cms-Inji

Push — master ( faf894...f88301 )

Cart::itemName() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like