MoneyController::completeTransferAction() - Code Metrics - Inspection of "skip if where is empty" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v5 ( e348bf...8a8f01 )

by Alexey

created 2018-01-07 17:11 UTC

MoneyController::completeTransferAction() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

/**
 * Money admin Controller
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */
class MoneyController extends adminController {

    public function manualClosePayAction($payId) {
        $pay = \Money\Pay::get((int) $payId);
        $result = new Server\Result();
        if ($pay && $pay->pay_status_id == 1) {
            $pay->pay_status_id = 2;
            $pay->save();
            if ($pay->callback_module && $pay->callback_method) {
                \App::$primary->{$pay->callback_module}->{$pay->callback_method}(['status' => 'success', 'payId' => $pay->id, 'pay' => $pay]);
            }
            $result->successMsg = 'Счет был проведен';
            $result->send();
        }
        $result->success = false;
        $result->content = 'Такой счет не найден';
        $result->send();
    }

    public function cancelTransferAction($transferId) {
        $transfer = Money\Transfer::get($transferId);
        $result = new Server\Result();

        $result->success = $transfer->cancel();

        $result->successMsg = 'Перевод был отменен';
        $result->content = 'Не удалось отменить перевод';
        $result->send();
    }

    public function completeTransferAction($transferId) {
        $transfer = Money\Transfer::get($transferId);

        $result = new Server\Result();

        $result->success = $transfer->complete();

        $result->successMsg = 'Перевод был завершен';
        $result->content = 'Не удалось завершить перевод';
        $result->send();
    }

}


1			<?php
2
3			/**
4			* Money admin Controller
5			*
6			* @author Alexey Krupskiy <[email protected]>
7			* @link http://inji.ru/
8			* @copyright 2015 Alexey Krupskiy
9			* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10			*/
11			class MoneyController extends adminController {
12
13			public function manualClosePayAction($payId) {
14			$pay = \Money\Pay::get((int) $payId);
15			$result = new Server\Result();
16			if ($pay && $pay->pay_status_id == 1) {
17			$pay->pay_status_id = 2;
18			$pay->save();
19			if ($pay->callback_module && $pay->callback_method) {
20			\App::$primary->{$pay->callback_module}->{$pay->callback_method}(['status' => 'success', 'payId' => $pay->id, 'pay' => $pay]);
21			}
22			$result->successMsg = 'Счет был проведен';
23			$result->send();
24			}
25			$result->success = false;
26			$result->content = 'Такой счет не найден';
27			$result->send();
28			}
29
30			public function cancelTransferAction($transferId) {
31			$transfer = Money\Transfer::get($transferId);
32			$result = new Server\Result();
33
34			$result->success = $transfer->cancel();
35
36			$result->successMsg = 'Перевод был отменен';
37			$result->content = 'Не удалось отменить перевод';
38			$result->send();
39			}
40
41			public function completeTransferAction($transferId) {
42			$transfer = Money\Transfer::get($transferId);
43
44			$result = new Server\Result();
45
46			$result->success = $transfer->complete();
47
48			$result->successMsg = 'Перевод был завершен';
49			$result->content = 'Не удалось завершить перевод';
50			$result->send();
51			}
52
53			}
54

injitools / cms-Inji

Push — v5 ( e348bf...8a8f01 )

MoneyController::completeTransferAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like