Ecommerce\DeliveryProvider\RussianPost

Complexity

Total Complexity

9

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
D	calcPrice()	0	32	9

<?php
/**
 * INJI
 *
 * @author Alexey Krupskiy <admin@inji.ru>
 * @link http://inji.ru/
 * @copyright 2017 Alexey Krupskiy
 * @license https://github.com/injitools/Inji/blob/master/LICENSE
 */

namespace Ecommerce\DeliveryProvider;


class RussianPost extends \Ecommerce\DeliveryProvider {
    static $name = 'PickPoint - курьерская служба';

The visibility should be declared for property $name.

    /**
     * @param \Ecommerce\Cart $cart
     * @return \Money\Sums
     *
     */
    static function calcPrice($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $city = '';
        foreach ($cart->delivery->fields as $field) {
            if ($field->code === 'index' && !empty($_POST['deliveryFields'][$field->id]) && is_string($_POST['deliveryFields'][$field->id])) {
                $city = $_POST['deliveryFields'][$field->id];
            }
        }
        if (!$city) {
            return new \Money\Sums([$cart->delivery->currency_id => 0]);
        }
        if (strpos($city, '66') === 0) {
            $senderCity = '660000';
        } else {
            $senderCity = '101000';
        }
        $url = 'http://tariff.russianpost.ru/tariff/v1/calculate?json&';
        $data = [
            'object' => 3020,
            'weight' => 2,
            'date' => date('Ymd'),
            'sumoc' => $cart->itemsSum()->sums[0],
            'from' => $senderCity,
            'to' => $city,
            'closed' => 1,
            'service' => 2,
            'isavia' => 0
        ];
        $result = json_decode(file_get_contents($url . http_build_query($data)), true);
        $sum = !empty($result['tariff'][0]['ground']['valnds']) ? $result['tariff'][0]['ground']['valnds'] : (!empty($result['tariff'][0]['avia']['valnds']) ? $result['tariff'][0]['avia']['valnds'] : 0);
        return new \Money\Sums([$cart->delivery->currency_id => $sum/100]);
    }
}