Query::where() - Code Metrics - Inspection of "add namespaces, add injiStorage driver, create dri..." - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — v5 (12d602)

by Alexey

created 2018-01-07 15:27 UTC

Query::where() A

↳ Parent: Query

Complexity

Conditions	3
Paths	2

Size

Total Lines	8
Code Lines	6

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	2
nop	4
dl	8
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by IntelliJ IDEA.
 * User: inji
 * Date: 07.01.2018
 * Time: 16:39
 */

namespace Inji\Db\InjiStorage;

use \Inji\Tools;

class Query implements \Inji\Db\DriverQuery {
    /**
     * @var \Inji\Db\InjiStorage
     */
    public $connection;
    public $whereArray = [];
    public $table = [];
    public $dbOptions = [];

    public function __construct($connection) {
        $this->connection = $connection;
    }

    public function setDbOption($name, $value) {
        $this->dbOptions[$name] = $value;
    }

    public function where($col, $value = true, $comparision = '=', $concatenation = 'AND') {
        if (is_array($col) && !Tools::isAssoc($col)) {
            $this->whereArray[] = $col;
        } else {
            $this->whereArray[] = [$col, $value, $comparision, $concatenation];
        }
        return $this;
    }

    public function setTable($tableName) {
        $this->table = $tableName;
    }

    public function select($tableName = null) {
        if (!$tableName) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $tableName = $this->table;
        }
        return new Result($this->connection->getItems($tableName, $this->whereArray, $this->dbOptions), $this);
    }

    public function insert(string $tableName, array $values) {
        if (!$tableName) {
            $tableName = $this->table;
        }
        return $this->connection->addItem($tableName, $values, $this->dbOptions);
    }

    public function update(string $tableName, array $values) {
        if (!$tableName) {
            $tableName = $this->table;
        }
        return $this->connection->updateItems($tableName, $this->whereArray, $values, $this->dbOptions);
    }

    public function delete(string $tableName='') {
        if (!$tableName) {
            $tableName = $this->table;
        }
        return $this->connection->deleteItems($tableName, $this->whereArray, $this->dbOptions);
    }

}

1		<?php
2		/**
3		* Created by IntelliJ IDEA.
4		* User: inji
5		* Date: 07.01.2018
6		* Time: 16:39
7		*/
8
9		namespace Inji\Db\InjiStorage;
10
11		use \Inji\Tools;
12
13		class Query implements \Inji\Db\DriverQuery {
14		/**
15		* @var \Inji\Db\InjiStorage
16		*/
17		public $connection;
18		public $whereArray = [];
19		public $table = [];
20		public $dbOptions = [];
21
22		public function __construct($connection) {
23		$this->connection = $connection;
24		}
25
26		public function setDbOption($name, $value) {
27		$this->dbOptions[$name] = $value;
28		}
29
30	View Code Duplication	public function where($col, $value = true, $comparision = '=', $concatenation = 'AND') {
31		if (is_array($col) && !Tools::isAssoc($col)) {
32		$this->whereArray[] = $col;
33		} else {
34		$this->whereArray[] = [$col, $value, $comparision, $concatenation];
35		}
36		return $this;
37		}
38
39		public function setTable($tableName) {
40		$this->table = $tableName;
41		}
42
43		public function select($tableName = null) {
44		if (!$tableName) {
		0 ignored issues – show Bug Best Practice introduced 2018-01-07 15:32 UTC by Report Bug Copy Issue Report The expression `$tableName` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
45		$tableName = $this->table;
46		}
47		return new Result($this->connection->getItems($tableName, $this->whereArray, $this->dbOptions), $this);
48		}
49
50		public function insert(string $tableName, array $values) {
51		if (!$tableName) {
52		$tableName = $this->table;
53		}
54		return $this->connection->addItem($tableName, $values, $this->dbOptions);
55		}
56
57		public function update(string $tableName, array $values) {
58		if (!$tableName) {
59		$tableName = $this->table;
60		}
61		return $this->connection->updateItems($tableName, $this->whereArray, $values, $this->dbOptions);
62		}
63
64		public function delete(string $tableName='') {
65		if (!$tableName) {
66		$tableName = $this->table;
67		}
68		return $this->connection->deleteItems($tableName, $this->whereArray, $this->dbOptions);
69		}
70
71		}

injitools / cms-Inji

Branch — v5 (12d602)

Query::where() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like