injitools /
cms-Inji
| Conditions | 17 |
| Paths | 225 |
| Total Lines | 79 |
| Code Lines | 55 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 90 | public function loadRowsAction() { |
||
| 91 | $result = new Result(); |
||
| 92 | $result->content = []; |
||
| 93 | |||
| 94 | ob_start(); |
||
| 95 | |||
| 96 | $request = $this->parseRequest(); |
||
| 97 | |||
| 98 | $dataManager = DataManager::forModel($request['modelName'], $request['managerName']); |
||
| 99 | |||
| 100 | |||
| 101 | if ($request['download']) { |
||
| 102 | |||
| 103 | ini_set('memory_limit', '4000M'); |
||
| 104 | set_time_limit(0); |
||
| 105 | |||
| 106 | $request['params']['all'] = true; |
||
| 107 | $request['params']['download'] = true; |
||
| 108 | ob_end_clean(); |
||
| 109 | header('Content-Encoding: UTF-8'); |
||
| 110 | header("Content-Type: text/csv"); |
||
| 111 | header("Content-Disposition: attachment; filename=" . str_replace(' ', '_', $request['modelName']::$objectName ? $request['modelName']::$objectName : $request['modelName']) . ".csv"); |
||
| 112 | echo "\xEF\xBB\xBF"; // UTF-8 BOM |
||
| 113 | |||
| 114 | |||
| 115 | $cols = $dataManager->getCols(); |
||
| 116 | if ($dataManager->getActions(true)) { |
||
| 117 | $cols = array_slice($cols, 1); |
||
| 118 | } |
||
| 119 | $endRow = true; |
||
| 120 | foreach ($cols as $colName => $options) { |
||
| 121 | if (!$endRow) { |
||
| 122 | echo ";"; |
||
| 123 | } |
||
| 124 | $endRow = false; |
||
| 125 | echo '"' . $options['label'] . '"'; |
||
| 126 | } |
||
| 127 | echo "\n"; |
||
| 128 | $endRow = true; |
||
| 129 | } |
||
| 130 | if (!$request['params']['all']) { |
||
| 131 | $pages = $dataManager->getPages($request['params'], $request['model']); |
||
| 132 | $request['params']['page'] = !empty($pages->params['page']) ? $pages->params['page'] : $dataManager->page; |
||
| 133 | $request['params']['limit'] = !empty($pages->params['limit']) ? $pages->params['limit'] : $dataManager->limit; |
||
| 134 | } |
||
| 135 | $rows = $dataManager->getRows($request['params'], $request['model']); |
||
| 136 | foreach ($rows as $row) { |
||
| 137 | if ($request['download']) { |
||
| 138 | foreach ($row as $col) { |
||
| 139 | if (!$endRow) { |
||
| 140 | echo ";"; |
||
| 141 | } |
||
| 142 | $endRow = false; |
||
| 143 | echo '"' . str_replace(["\n", '"'], ['“'], $col) . '"'; |
||
| 144 | } |
||
| 145 | echo "\n"; |
||
| 146 | $endRow = true; |
||
| 147 | } else { |
||
| 148 | Table::drawRow($row); |
||
| 149 | } |
||
| 150 | } |
||
| 151 | if ($request['download']) { |
||
| 152 | exit(); |
||
| 153 | } |
||
| 154 | |||
| 155 | $result->content['rows'] = ob_get_contents(); |
||
| 156 | $result->content['summary'] = $dataManager->getSummary($request['params'], $request['model']); |
||
| 157 | ob_clean(); |
||
| 158 | |||
| 159 | $result->content['pages'] = ''; |
||
| 160 | if (isset($pages) && $pages) { |
||
| 161 | if ($pages) { |
||
| 162 | $pages->draw(); |
||
| 163 | echo '<div style="background:#fff;">записей: <b>' . $pages->options['count'] . '</b>. страница <b>' . $pages->params['page'] . '</b> из <b>' . $pages->params['pages'] . '</b></div>'; |
||
| 164 | } |
||
| 165 | $result->content['pages'] = ob_get_contents(); |
||
| 166 | ob_end_clean(); |
||
| 167 | } |
||
| 168 | $result->send(); |
||
| 169 | } |
||
| 268 | } |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. Please note the @ignore annotation hint above.