Item::simpleItemHandler() - Code Metrics - Inspection of "simple forms and item simple form" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7855c2...b6f450 )

by Alexey

created 2016-10-31 09:35 UTC

Item::simpleItemHandler() C

↳ Parent: Item

Complexity

Conditions	8
Paths	13

Size

Total Lines	51
Code Lines	41

Duplication

Lines	18
Ratio	35.29 %

Importance

Changes

Metric	Value
cc	8
eloc	41
nc	13
nop	1
dl	18
loc	51
rs	6.5978
c	0
b	0
f	0

How to fix Long Method

<?php

/**
 * Item
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */

namespace Ecommerce;

class Item extends \Model {

  public static $categoryModel = 'Ecommerce\Category';
  public static $objectName = 'Товар';
  public static $labels = [
      'name' => 'Название',
      'alias' => 'Алиас',
      'category_id' => 'Раздел',
      'description' => 'Описание',
      'item_type_id' => 'Тип товара',
      'image_file_id' => 'Изображение',
      'best' => 'Лучшее предложение',
      'options' => 'Параметры',
      'offers' => 'Торговые предложения',
      'widget' => 'Виджет для отображения в каталоге',
      'view' => 'Шаблон для отображения полной информации',
      'deleted' => 'Удален',
      'imgs' => 'Фото'
  ];
  public static $cols = [
      //Основные параметры
      'category_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'category'],
      'image_file_id' => ['type' => 'image'],
      'name' => ['type' => 'text'],
      'alias' => ['type' => 'text'],
      'description' => ['type' => 'html'],
      'item_type_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'type'],
      'best' => ['type' => 'bool'],
      'deleted' => ['type' => 'bool'],
      //Системные
      'user_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'user'],
      'weight' => ['type' => 'number'],
      'sales' => ['type' => 'number'],
      'imported' => ['type' => 'text'],
      'tree_path' => ['type' => 'text'],
      'search_index' => ['type' => 'text'],
      'date_create' => ['type' => 'dateTime'],
      'widget' => ['type' => 'text'],
      'view' => ['type' => 'text'],
      //Менеджеры
      'options' => ['type' => 'dataManager', 'relation' => 'options'],
      'offers' => ['type' => 'dataManager', 'relation' => 'offers'],
      'imgs' => ['type' => 'dataManager', 'relation' => 'images'],
  ];

  public static function simpleItemHandler($request) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    if ($request) {
      $item = new Item();
      $item->name = $request['name'];
      $item->description = $request['description'];
      $item->category_id = $request['category'];
      $item->save();
      if (!empty($_FILES['ActiveForm_simpleItem']['tmp_name']['Ecommerce\Item']['image'])) {
        $file_id = \App::$primary->files->upload([
            'tmp_name' => $_FILES['ActiveForm_simpleItem']['tmp_name']['Ecommerce\Item']['image'],
            'name' => $_FILES['ActiveForm_simpleItem']['name']['Ecommerce\Item']['image'],
            'type' => $_FILES['ActiveForm_simpleItem']['type']['Ecommerce\Item']['image'],
            'size' => $_FILES['ActiveForm_simpleItem']['size']['Ecommerce\Item']['image'],
            'error' => $_FILES['ActiveForm_simpleItem']['error']['Ecommerce\Item']['image'],
                ], [
            'upload_code' => 'activeForm:' . 'Ecommerce\Item' . ':' . $item->pk(),
            'accept_group' => 'image'
        ]);
        if ($file_id) {
          $item->image_file_id = $file_id;
          $item->save();
        }
      }
      if (!empty($request['options']['option'])) {

        foreach ($request['options']['option'] as $key => $option_id) {
          $param = new Item\Param();
          $param->item_id = $item->id;
          $param->value = $request['options']['value'][$key];
          $param->item_option_id = $option_id;
          $param->save();
        }
      }
      $offer = new Item\Offer();
      $offer->item_id = $item->id;
      $offer->save();
      if (!empty($request['offerOptions']['option'])) {

        foreach ($request['offerOptions']['option'] as $key => $option_id) {
          $param = new Item\Offer\Param();
          $param->item_offer_id = $offer->id;
          $param->value = $request['offerOptions']['value'][$key];
          $param->item_offer_option_id = $option_id;
          $param->save();
        }
      }
      $price = new Item\Offer\Price();
      $price->price = $request['price'];
      $price->item_offer_id = $offer->id;
      $price->currency_id = $request['currency'];
      $price->save();
    }
  }

  public static $dataManagers = [
      'manager' => [
          'name' => 'Товары',
          'cols' => [
              'name',
              'imgs',
              'category_id',
              'item_type_id',
              'best',
              'deleted',
              'options',
              'offers',
          ],
          'categorys' => [
              'model' => 'Ecommerce\Category',
          ],
          'sortMode' => true
      ]
  ];
  public static $forms = [
      'manager' => [
          'map' => [
              ['name', 'alias'],
              ['category_id', 'item_type_id', 'deleted'],
              ['widget', 'view'],
              ['best', 'image_file_id'],
              ['description'],
              ['imgs'],
              ['options'],
              ['offers'],
          ]
      ],
      'simpleItem' => [
          'options' => [
              'access' => [
                  'groups' => [
                      3
                  ]
              ],
          ],
          'name' => 'Простой товар с ценой',
          'inputs' => [
              'name' => ['type' => 'text'],
              'description' => ['type' => 'html'],
              'category' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Category', 'label' => 'Категория'],
              'image' => ['type' => 'image', 'label' => 'Изображение'],
              'price' => ['type' => 'text', 'label' => 'Цена'],
              'currency' => ['type' => 'select', 'source' => 'model', 'model' => 'Money\Currency', 'label' => 'Валюта'],
              'options' => ['type' => 'dynamicList', 'source' => 'options', 'options' => [
                      'inputs' => [
                          'option' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Item\Option', 'label' => 'Свойство'],
                          'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType', 'label' => 'Значение'],
                      ]
                  ]
              ],
              'offerOptions' => ['type' => 'dynamicList', 'source' => 'options', 'options' => [
                      'inputs' => [
                          'option' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Item\Offer\Option', 'label' => 'Свойство предложения'],
                          'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType', 'label' => 'Значение'],
                      ]
                  ],'label'=>'Параметры предлоежния'
              ]
          ],
          'map' => [
              ['name', 'category'],
              ['description'],
              ['image'],
              ['price', 'currency'],
              ['options'],
              ['offerOptions'],
          ],
          'handler' => 'simpleItemHandler'
      ]
  ];

  public function realType() {
    if ($this->option && $this->option->type) {
      $type = $this->option->type;

      if ($type == 'select') {
        return [
            'type' => 'select',
            'source' => 'relation',
            'relation' => 'option:items',
        ];
      }
      return $type;
    }
    return 'text';
  }

  public static function indexes() {
    return [
        'ecommerce_item_item_category_id' => [
            'type' => 'INDEX',
            'cols' => [
                'item_category_id'
            ]
        ],
        'inji_ecommerce_item_item_tree_path' => [
            'type' => 'INDEX',
            'cols' => [
                'item_tree_path(255)'
            ]
        ],
        'ecommerce_item_item_search_index' => [
            'type' => 'INDEX',
            'cols' => [
                'item_search_index(255)'
            ]
        ],
    ];
  }

  public function beforeSave() {

    if ($this->id) {
      $this->search_index = $this->name . ' ';
      if ($this->category) {
        $this->search_index .= $this->category->name . ' ';
      }
      if ($this->options) {

        foreach ($this->options as $option) {
          if ($option->item_option_searchable && $option->value) {
            if ($option->item_option_type != 'select') {
              $this->search_index .= $option->value . ' ';
            } elseif (!empty($option->option->items[$option->value])) {
              $option->option->items[$option->value]->value . ' ';
            }
          }
        }
      }
      if ($this->offers) {
        foreach ($this->offers as $offer) {
          if ($offer->options) {

            foreach ($offer->options as $option) {
              if ($option->item_offer_option_searchable && $option->value) {
                if ($option->item_offer_option_type != 'select') {
                  $this->search_index .= $option->value . ' ';
                } elseif (!empty($option->option->items[$option->value])) {
                  $option->option->items[$option->value]->value . ' ';
                }
              }
            }
          }
        }
      }
    }
  }

  public static function relations() {

    return [
        'category' => [
            'model' => 'Ecommerce\Category',
            'col' => 'category_id'
        ],
        'options' => [
            'type' => 'many',
            'model' => 'Ecommerce\Item\Param',
            'col' => 'item_id',
            //'resultKey' => 'code',

            'resultKey' => 'item_option_id',
            'join' => [Item\Option::table(), Item\Option::index() . ' = ' . Item\Param::colPrefix() . Item\Option::index()]
        ],
        'offers' => [
            'type' => 'many',
            'model' => 'Ecommerce\Item\Offer',
            'col' => 'item_id',
        ],
        'type' => [
            'model' => 'Ecommerce\Item\Type',
            'col' => 'item_type_id',
        ],
        'image' => [
            'model' => 'Files\File',
            'col' => 'image_file_id'
        ],
        'images' => [
            'type' => 'many',
            'model' => 'Ecommerce\Item\Image',
            'col' => 'item_id'
        ],
        'user' => [
            'model' => 'Users\User',
            'col' => 'user_id'
        ]
    ];
  }

  public function getPrice() {
    $offers = $this->offers(['key' => false]);
    $curPrice = null;

    foreach ($offers[0]->prices as $price) {
      if (!$price->type) {
        $curPrice = $price;
      } elseif (
              (!$price->type->roles && !$curPrice) ||
              ($price->type->roles && !$curPrice && strpos($price->type->roles, "|" . \Users\User::$cur->role_id . "|") !== false)
      ) {
        $curPrice = $price;
      }
    }
    return $curPrice;
  }

  public function name() {
    if (!empty(\App::$primary->ecommerce->config['item_option_as_name'])) {
      $param = Item\Param::get([['item_id', $this->id], ['item_option_id', \App::$primary->ecommerce->config['item_option_as_name']]]);
      if ($param && $param->value) {
        return $param->value;
      }
    }
    return $this->name;
  }

  public function beforeDelete() {
    if ($this->id) {
      if ($this->options) {
        foreach ($this->options as $option) {
          $option->delete();
        }
      }
      if ($this->offers) {
        foreach ($this->offers as $offer) {
          $offer->delete();
        }
      }
      if ($this->image) {
        $this->image->delete();
      }
    }
  }

  public function getHref() {
    return "/ecommerce/view/{$this->pk()}";
  }

}


1		<?php
2
3		/**
4		* Item
5		*
6		* @author Alexey Krupskiy <[email protected]>
7		* @link http://inji.ru/
8		* @copyright 2015 Alexey Krupskiy
9		* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10		*/
11
12		namespace Ecommerce;
13
14		class Item extends \Model {
15
16		public static $categoryModel = 'Ecommerce\Category';
17		public static $objectName = 'Товар';
18		public static $labels = [
19		'name' => 'Название',
20		'alias' => 'Алиас',
21		'category_id' => 'Раздел',
22		'description' => 'Описание',
23		'item_type_id' => 'Тип товара',
24		'image_file_id' => 'Изображение',
25		'best' => 'Лучшее предложение',
26		'options' => 'Параметры',
27		'offers' => 'Торговые предложения',
28		'widget' => 'Виджет для отображения в каталоге',
29		'view' => 'Шаблон для отображения полной информации',
30		'deleted' => 'Удален',
31		'imgs' => 'Фото'
32		];
33		public static $cols = [
34		//Основные параметры
35		'category_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'category'],
36		'image_file_id' => ['type' => 'image'],
37		'name' => ['type' => 'text'],
38		'alias' => ['type' => 'text'],
39		'description' => ['type' => 'html'],
40		'item_type_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'type'],
41		'best' => ['type' => 'bool'],
42		'deleted' => ['type' => 'bool'],
43		//Системные
44		'user_id' => ['type' => 'select', 'source' => 'relation', 'relation' => 'user'],
45		'weight' => ['type' => 'number'],
46		'sales' => ['type' => 'number'],
47		'imported' => ['type' => 'text'],
48		'tree_path' => ['type' => 'text'],
49		'search_index' => ['type' => 'text'],
50		'date_create' => ['type' => 'dateTime'],
51		'widget' => ['type' => 'text'],
52		'view' => ['type' => 'text'],
53		//Менеджеры
54		'options' => ['type' => 'dataManager', 'relation' => 'options'],
55		'offers' => ['type' => 'dataManager', 'relation' => 'offers'],
56		'imgs' => ['type' => 'dataManager', 'relation' => 'images'],
57		];
58
59		public static function simpleItemHandler($request) {
		1 ignored issue – show Coding Style introduced 2016-10-31 09:42 UTC by Report Bug Copy Issue Report `simpleItemHandler` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
60		if ($request) {
61		$item = new Item();
62		$item->name = $request['name'];
63		$item->description = $request['description'];
64		$item->category_id = $request['category'];
65		$item->save();
66		if (!empty($_FILES['ActiveForm_simpleItem']['tmp_name']['Ecommerce\Item']['image'])) {
67		$file_id = \App::$primary->files->upload([
68		'tmp_name' => $_FILES['ActiveForm_simpleItem']['tmp_name']['Ecommerce\Item']['image'],
69		'name' => $_FILES['ActiveForm_simpleItem']['name']['Ecommerce\Item']['image'],
70		'type' => $_FILES['ActiveForm_simpleItem']['type']['Ecommerce\Item']['image'],
71		'size' => $_FILES['ActiveForm_simpleItem']['size']['Ecommerce\Item']['image'],
72		'error' => $_FILES['ActiveForm_simpleItem']['error']['Ecommerce\Item']['image'],
73		], [
74		'upload_code' => 'activeForm:' . 'Ecommerce\Item' . ':' . $item->pk(),
75		'accept_group' => 'image'
76		]);
77		if ($file_id) {
78		$item->image_file_id = $file_id;
79		$item->save();
80		}
81		}
82	View Code Duplication	if (!empty($request['options']['option'])) {
		0 ignored issues – show Duplication introduced 2016-10-31 09:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
83		foreach ($request['options']['option'] as $key => $option_id) {
84		$param = new Item\Param();
85		$param->item_id = $item->id;
86		$param->value = $request['options']['value'][$key];
87		$param->item_option_id = $option_id;
88		$param->save();
89		}
90		}
91		$offer = new Item\Offer();
92		$offer->item_id = $item->id;
93		$offer->save();
94	View Code Duplication	if (!empty($request['offerOptions']['option'])) {
		0 ignored issues – show Duplication introduced 2016-10-31 09:42 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
95		foreach ($request['offerOptions']['option'] as $key => $option_id) {
96		$param = new Item\Offer\Param();
97		$param->item_offer_id = $offer->id;
98		$param->value = $request['offerOptions']['value'][$key];
99		$param->item_offer_option_id = $option_id;
100		$param->save();
101		}
102		}
103		$price = new Item\Offer\Price();
104		$price->price = $request['price'];
105		$price->item_offer_id = $offer->id;
106		$price->currency_id = $request['currency'];
107		$price->save();
108		}
109		}
110
111		public static $dataManagers = [
112		'manager' => [
113		'name' => 'Товары',
114		'cols' => [
115		'name',
116		'imgs',
117		'category_id',
118		'item_type_id',
119		'best',
120		'deleted',
121		'options',
122		'offers',
123		],
124		'categorys' => [
125		'model' => 'Ecommerce\Category',
126		],
127		'sortMode' => true
128		]
129		];
130		public static $forms = [
131		'manager' => [
132		'map' => [
133		['name', 'alias'],
134		['category_id', 'item_type_id', 'deleted'],
135		['widget', 'view'],
136		['best', 'image_file_id'],
137		['description'],
138		['imgs'],
139		['options'],
140		['offers'],
141		]
142		],
143		'simpleItem' => [
144		'options' => [
145		'access' => [
146		'groups' => [
147		3
148		]
149		],
150		],
151		'name' => 'Простой товар с ценой',
152		'inputs' => [
153		'name' => ['type' => 'text'],
154		'description' => ['type' => 'html'],
155		'category' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Category', 'label' => 'Категория'],
156		'image' => ['type' => 'image', 'label' => 'Изображение'],
157		'price' => ['type' => 'text', 'label' => 'Цена'],
158		'currency' => ['type' => 'select', 'source' => 'model', 'model' => 'Money\Currency', 'label' => 'Валюта'],
159		'options' => ['type' => 'dynamicList', 'source' => 'options', 'options' => [
160		'inputs' => [
161		'option' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Item\Option', 'label' => 'Свойство'],
162		'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType', 'label' => 'Значение'],
163		]
164		]
165		],
166		'offerOptions' => ['type' => 'dynamicList', 'source' => 'options', 'options' => [
167		'inputs' => [
168		'option' => ['type' => 'select', 'source' => 'model', 'model' => 'Ecommerce\Item\Offer\Option', 'label' => 'Свойство предложения'],
169		'value' => ['type' => 'dynamicType', 'typeSource' => 'selfMethod', 'selfMethod' => 'realType', 'label' => 'Значение'],
170		]
171		],'label'=>'Параметры предлоежния'
172		]
173		],
174		'map' => [
175		['name', 'category'],
176		['description'],
177		['image'],
178		['price', 'currency'],
179		['options'],
180		['offerOptions'],
181		],
182		'handler' => 'simpleItemHandler'
183		]
184		];
185
186		public function realType() {
187		if ($this->option && $this->option->type) {
188		$type = $this->option->type;
189
190		if ($type == 'select') {
191		return [
192		'type' => 'select',
193		'source' => 'relation',
194		'relation' => 'option:items',
195		];
196		}
197		return $type;
198		}
199		return 'text';
200		}
201
202		public static function indexes() {
203		return [
204		'ecommerce_item_item_category_id' => [
205		'type' => 'INDEX',
206		'cols' => [
207		'item_category_id'
208		]
209		],
210		'inji_ecommerce_item_item_tree_path' => [
211		'type' => 'INDEX',
212		'cols' => [
213		'item_tree_path(255)'
214		]
215		],
216		'ecommerce_item_item_search_index' => [
217		'type' => 'INDEX',
218		'cols' => [
219		'item_search_index(255)'
220		]
221		],
222		];
223		}
224
225		public function beforeSave() {
226
227		if ($this->id) {
228		$this->search_index = $this->name . ' ';
229		if ($this->category) {
230		$this->search_index .= $this->category->name . ' ';
231		}
232	View Code Duplication	if ($this->options) {
		0 ignored issues – show Duplication introduced 2016-10-08 07:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
233		foreach ($this->options as $option) {
234		if ($option->item_option_searchable && $option->value) {
235		if ($option->item_option_type != 'select') {
236		$this->search_index .= $option->value . ' ';
237		} elseif (!empty($option->option->items[$option->value])) {
238		$option->option->items[$option->value]->value . ' ';
239		}
240		}
241		}
242		}
243		if ($this->offers) {
244		foreach ($this->offers as $offer) {
245	View Code Duplication	if ($offer->options) {
		0 ignored issues – show Duplication introduced 2016-10-08 07:49 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
246		foreach ($offer->options as $option) {
247		if ($option->item_offer_option_searchable && $option->value) {
248		if ($option->item_offer_option_type != 'select') {
249		$this->search_index .= $option->value . ' ';
250		} elseif (!empty($option->option->items[$option->value])) {
251		$option->option->items[$option->value]->value . ' ';
252		}
253		}
254		}
255		}
256		}
257		}
258		}
259		}
260
261		public static function relations() {
262
263		return [
264		'category' => [
265		'model' => 'Ecommerce\Category',
266		'col' => 'category_id'
267		],
268		'options' => [
269		'type' => 'many',
270		'model' => 'Ecommerce\Item\Param',
271		'col' => 'item_id',
272		//'resultKey' => 'code',
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-02-05 04:58 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
273		'resultKey' => 'item_option_id',
274		'join' => [Item\Option::table(), Item\Option::index() . ' = ' . Item\Param::colPrefix() . Item\Option::index()]
275		],
276		'offers' => [
277		'type' => 'many',
278		'model' => 'Ecommerce\Item\Offer',
279		'col' => 'item_id',
280		],
281		'type' => [
282		'model' => 'Ecommerce\Item\Type',
283		'col' => 'item_type_id',
284		],
285		'image' => [
286		'model' => 'Files\File',
287		'col' => 'image_file_id'
288		],
289		'images' => [
290		'type' => 'many',
291		'model' => 'Ecommerce\Item\Image',
292		'col' => 'item_id'
293		],
294		'user' => [
295		'model' => 'Users\User',
296		'col' => 'user_id'
297		]
298		];
299		}
300
301		public function getPrice() {
302		$offers = $this->offers(['key' => false]);
303		$curPrice = null;
304
305		foreach ($offers[0]->prices as $price) {
306		if (!$price->type) {
307		$curPrice = $price;
308		} elseif (
309		(!$price->type->roles && !$curPrice) \|\|
310		($price->type->roles && !$curPrice && strpos($price->type->roles, "\|" . \Users\User::$cur->role_id . "\|") !== false)
311		) {
312		$curPrice = $price;
313		}
314		}
315		return $curPrice;
316		}
317
318		public function name() {
319		if (!empty(\App::$primary->ecommerce->config['item_option_as_name'])) {
320		$param = Item\Param::get([['item_id', $this->id], ['item_option_id', \App::$primary->ecommerce->config['item_option_as_name']]]);
321		if ($param && $param->value) {
322		return $param->value;
323		}
324		}
325		return $this->name;
326		}
327
328		public function beforeDelete() {
329		if ($this->id) {
330		if ($this->options) {
331		foreach ($this->options as $option) {
332		$option->delete();
333		}
334		}
335		if ($this->offers) {
336		foreach ($this->offers as $offer) {
337		$offer->delete();
338		}
339		}
340		if ($this->image) {
341		$this->image->delete();
342		}
343		}
344		}
345
346		public function getHref() {
347		return "/ecommerce/view/{$this->pk()}";
348		}
349
350		}
351

injitools / cms-Inji

Push — master ( 7855c2...b6f450 )

Item::simpleItemHandler() C

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like