MoneyController::manualClosePayAction() - Code Metrics - Inspection of "transfer admin" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 337c6f...93368f )

by Alexey

created 2016-03-16 10:55 UTC

MoneyController::manualClosePayAction() B

↳ Parent: MoneyController

Complexity

Conditions	5
Paths	3

Size

Total Lines	17
Code Lines	13

Duplication

Lines	3
Ratio	17.65 %

Metric	Value
dl	3
loc	17
rs	8.8571
cc	5
eloc	13
nc	3
nop	1

<?php

/**
 * Money admin Controller
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */
class MoneyController extends adminController
{
    public function manualClosePayAction($payId)
    {
        $pay = \Money\Pay::get((int) $payId);
        $result = new Server\Result();
        if ($pay && $pay->pay_status_id == 1) {
            $pay->pay_status_id = 2;
            $pay->save();
            if ($pay->callback_module && $pay->callback_method) {

                \App::$primary->{$pay->callback_module}->{$pay->callback_method}(['status' => 'success', 'payId' => $pay->id, 'pay' => $pay]);
            }
            $result->successMsg = 'Счет был проведен';
            $result->send();
        }
        $result->success = false;
        $result->content = 'Такой счет не найден';
        $result->send();
    }

    public function cancelTransferAction($transferId)
    {
        $transfer = Money\Transfer::get($transferId);
        $result = new Server\Result();

        $result->success = $transfer->cancel();

        $result->successMsg = 'Перевод был отменен';
        $result->content = 'Не удалось отменить перевод';
        $result->send();
    }

    public function completeTransferAction($transferId)
    {
        $transfer = Money\Transfer::get($transferId);

        $result = new Server\Result();

        $result->success = $transfer->complete();

        $result->successMsg = 'Перевод был завершен';
        $result->content = 'Не удалось завершить перевод';
        $result->send();
    }

}


1		<?php
2
3		/**
4		* Money admin Controller
5		*
6		* @author Alexey Krupskiy <[email protected]>
7		* @link http://inji.ru/
8		* @copyright 2015 Alexey Krupskiy
9		* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10		*/
11		class MoneyController extends adminController
12		{
13		public function manualClosePayAction($payId)
14		{
15		$pay = \Money\Pay::get((int) $payId);
16		$result = new Server\Result();
17		if ($pay && $pay->pay_status_id == 1) {
18		$pay->pay_status_id = 2;
19		$pay->save();
20	View Code Duplication	if ($pay->callback_module && $pay->callback_method) {
		0 ignored issues – show Duplication introduced 2016-01-31 20:44 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		\App::$primary->{$pay->callback_module}->{$pay->callback_method}(['status' => 'success', 'payId' => $pay->id, 'pay' => $pay]);
22		}
23		$result->successMsg = 'Счет был проведен';
24		$result->send();
25		}
26		$result->success = false;
27		$result->content = 'Такой счет не найден';
28		$result->send();
29		}
30
31	View Code Duplication	public function cancelTransferAction($transferId)
32		{
33		$transfer = Money\Transfer::get($transferId);
34		$result = new Server\Result();
35
36		$result->success = $transfer->cancel();
37
38		$result->successMsg = 'Перевод был отменен';
39		$result->content = 'Не удалось отменить перевод';
40		$result->send();
41		}
42
43	View Code Duplication	public function completeTransferAction($transferId)
44		{
45		$transfer = Money\Transfer::get($transferId);
46
47		$result = new Server\Result();
48
49		$result->success = $transfer->complete();
50
51		$result->successMsg = 'Перевод был завершен';
52		$result->content = 'Не удалось завершить перевод';
53		$result->send();
54		}
55
56		}
57

injitools / cms-Inji

Push — master ( 337c6f...93368f )

MoneyController::manualClosePayAction() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like