File - Code Metrics - Inspection of "add single file viewer" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e57e6...32019c )

by Alexey

created 2016-11-24 17:32 UTC

File A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	21
Duplicated Lines	80.95 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	17
loc	21
rs	10
c	1
b	0
f	1
wmc	3
lcom	1
cbo	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	parseRequest()	17	17	3

How to fix Duplicated Code

<?php

/**
 * Active form input files
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */

namespace Ui\ActiveForm\Input;

class File extends \Ui\ActiveForm\Input {

  public function parseRequest($request) {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    if (!empty($_FILES[$this->activeForm->requestFormName]['tmp_name'][$this->modelName][$this->colName])) {
      $file_id = \App::$primary->files->upload([
          'tmp_name' => $_FILES[$this->activeForm->requestFormName]['tmp_name'][$this->modelName][$this->colName],
          'name' => $_FILES[$this->activeForm->requestFormName]['name'][$this->modelName][$this->colName],
          'type' => $_FILES[$this->activeForm->requestFormName]['type'][$this->modelName][$this->colName],
          'size' => $_FILES[$this->activeForm->requestFormName]['size'][$this->modelName][$this->colName],
          'error' => $_FILES[$this->activeForm->requestFormName]['error'][$this->modelName][$this->colName],
              ], [
          'upload_code' => 'activeForm:' . $this->activeForm->modelName . ':' . $this->activeForm->model->pk()
      ]);

      if ($file_id) {
        $this->activeForm->model->{$this->colName} = $file_id;
      }
    }
  }

}


1		<?php
2
3		/**
4		* Active form input files
5		*
6		* @author Alexey Krupskiy <[email protected]>
7		* @link http://inji.ru/
8		* @copyright 2015 Alexey Krupskiy
9		* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10		*/
11
12		namespace Ui\ActiveForm\Input;
13
14		class File extends \Ui\ActiveForm\Input {
15
16	View Code Duplication	public function parseRequest($request) {
		1 ignored issue – show Coding Style introduced 2016-11-24 17:36 UTC by Report Bug Copy Issue Report `parseRequest` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
17		if (!empty($_FILES[$this->activeForm->requestFormName]['tmp_name'][$this->modelName][$this->colName])) {
18		$file_id = \App::$primary->files->upload([
19		'tmp_name' => $_FILES[$this->activeForm->requestFormName]['tmp_name'][$this->modelName][$this->colName],
20		'name' => $_FILES[$this->activeForm->requestFormName]['name'][$this->modelName][$this->colName],
21		'type' => $_FILES[$this->activeForm->requestFormName]['type'][$this->modelName][$this->colName],
22		'size' => $_FILES[$this->activeForm->requestFormName]['size'][$this->modelName][$this->colName],
23		'error' => $_FILES[$this->activeForm->requestFormName]['error'][$this->modelName][$this->colName],
24		], [
25		'upload_code' => 'activeForm:' . $this->activeForm->modelName . ':' . $this->activeForm->model->pk()
26		]);
27
28		if ($file_id) {
29		$this->activeForm->model->{$this->colName} = $file_id;
30		}
31		}
32		}
33
34		}
35

injitools / cms-Inji

Push — master ( 0e57e6...32019c )

File A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like