Completed
Push — master ( 308a3c...ebb499 )
by Alexey
08:08
created
system/modules/Users/appAdminControllers/UsersController.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,8 @@
 block discarded – undo
13 13
     public function loginAction() {
14 14
         if (!Users\User::$cur->user_id) {
15 15
             $this->view->page(['page' => 'login', 'content' => 'login']);
16
-        } else {
16
+        }
17
+        else {
17 18
             $this->view->page(['content' => 'profile']);
18 19
         }
19 20
     }
Please login to merge, or discard this patch.
system/modules/Users/appAdminControllers/content/edit.php 1 patch
Braces   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -42,10 +42,12 @@
 block discarded – undo
42 42
                             <select class="form-control" name = 'user_role_id'>
43 43
                               <?php
44 44
                               foreach ($roles as $role) {
45
-                                  if ($role['role_id'] == $user->user_role_id)
46
-                                      $selected = 'selected = "selected"';
47
-                                  else
48
-                                      $selected = '';
45
+                                  if ($role['role_id'] == $user->user_role_id) {
46
+                                                                        $selected = 'selected = "selected"';
47
+                                  }
48
+                                  else {
49
+                                                                        $selected = '';
50
+                                  }
49 51
                                   echo "<option {$selected} value = '{$role['role_id']}'>{$role['role_name']}</option>";
50 52
                               }
51 53
                               ?>
Please login to merge, or discard this patch.
system/modules/Users/objects/SocialHelper/Vk.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -62,7 +62,8 @@  discard block
 block discarded – undo
62 62
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
63 63
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type]);
64 64
             }
65
-        } else {
65
+        }
66
+        else {
66 67
             if ($userSocial && !$userSocial->user) {
67 68
                 $userSocial->delete();
68 69
             }
@@ -104,7 +105,8 @@  discard block
 block discarded – undo
104 105
                     $userInfo->user_id = $user->id;
105 106
                     $userInfo->save();
106 107
                 }
107
-            } else {
108
+            }
109
+            else {
108 110
                 $user = \Users\User::$cur;
109 111
             }
110 112
             if (!$user->info->photo_file_id && !empty($userDetail['response'][0]['photo_max_orig'])) {
@@ -172,7 +174,8 @@  discard block
 block discarded – undo
172 174
             $social->social_id = 1;
173 175
             $social->uid = $userResult['response'][0]['uid'];
174 176
             $social->save();
175
-        } else {
177
+        }
178
+        else {
176 179
             $user = $socUser->user;
177 180
         }
178 181
         return $user;
Please login to merge, or discard this patch.
system/modules/Users/objects/SocialHelper/Facebook.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -60,7 +60,8 @@  discard block
 block discarded – undo
60 60
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
61 61
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type]);
62 62
             }
63
-        } else {
63
+        }
64
+        else {
64 65
             if ($userSocial && !$userSocial->user) {
65 66
                 $userSocial->delete();
66 67
             }
@@ -102,7 +103,8 @@  discard block
 block discarded – undo
102 103
                     $userInfo->user_id = $user->id;
103 104
                     $userInfo->save();
104 105
                 }
105
-            } else {
106
+            }
107
+            else {
106 108
                 $user = \Users\User::$cur;
107 109
             }
108 110
             if (!$user->info->photo_file_id && !empty($userDetail['picture']['data']['url'])) {
@@ -132,7 +134,8 @@  discard block
 block discarded – undo
132 134
             \App::$cur->users->newSession($user);
133 135
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
134 136
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type], 'Вы успешно зарегистрировались через Facebook', 'success');
135
-            } else {
137
+            }
138
+            else {
136 139
                 \Tools::redirect('/users/cabinet/profile', 'Вы успешно зарегистрировались через Facebook', 'success');
137 140
             }
138 141
         }
Please login to merge, or discard this patch.
system/modules/Users/objects/SocialHelper/Google.php 1 patch
Braces   +4 added lines, -2 removed lines patch added patch discarded remove patch
@@ -69,7 +69,8 @@  discard block
 block discarded – undo
69 69
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
70 70
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type]);
71 71
             }
72
-        } else {
72
+        }
73
+        else {
73 74
             if ($userSocial && !$userSocial->user) {
74 75
                 $userSocial->delete();
75 76
             }
@@ -111,7 +112,8 @@  discard block
 block discarded – undo
111 112
                     $userInfo->user_id = $user->id;
112 113
                     $userInfo->save();
113 114
                 }
114
-            } else {
115
+            }
116
+            else {
115 117
                 $user = \Users\User::$cur;
116 118
             }
117 119
             if (!$user->info->photo_file_id && !empty($userDetail['picture'])) {
Please login to merge, or discard this patch.
system/modules/Users/objects/SocialHelper/Twitter.php 1 patch
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -137,7 +137,8 @@  discard block
 block discarded – undo
137 137
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
138 138
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type]);
139 139
             }
140
-        } else {
140
+        }
141
+        else {
141 142
             if ($userSocial && !$userSocial->user) {
142 143
                 $userSocial->delete();
143 144
             }
@@ -170,7 +171,8 @@  discard block
 block discarded – undo
170 171
                 $userInfo = new \Users\User\Info();
171 172
                 $userInfo->user_id = $user->id;
172 173
                 $userInfo->save();
173
-            } else {
174
+            }
175
+            else {
174 176
                 $user = \Users\User::$cur;
175 177
             }
176 178
             $name = explode(' ', $userDetail['name']);
@@ -186,7 +188,8 @@  discard block
 block discarded – undo
186 188
             \App::$cur->users->newSession($user);
187 189
             if (!empty(\App::$cur->users->config['loginUrl'][\App::$cur->type])) {
188 190
                 \Tools::redirect(\App::$cur->users->config['loginUrl'][\App::$cur->type], 'Вы успешно зарегистрировались через Twitter', 'success');
189
-            } else {
191
+            }
192
+            else {
190 193
                 \Tools::redirect('/users/cabinet/profile', 'Вы успешно зарегистрировались через Twitter', 'success');
191 194
             }
192 195
         }
Please login to merge, or discard this patch.
system/modules/Users/Users.php 1 patch
Braces   +33 added lines, -19 removed lines patch added patch discarded remove patch
@@ -98,7 +98,8 @@  discard block
 block discarded – undo
98 98
                     setcookie($this->cookiePrefix . "_user_id", '', 0, "/");
99 99
                 }
100 100
                 Tools::redirect('/', 'Этот аккаунт ещё не активирован. <br />Если вы не получали письмо с ссылкой для активации, нажмите на - <a href = "/users/resendActivation/' . $session->user->id . '"><b>повторно выслать ссылку активации</b></a>');
101
-            } elseif ($session->user->activation) {
101
+            }
102
+            elseif ($session->user->activation) {
102 103
                 Msg::add('Этот аккаунт ещё не активирован, не все функции могут быть доступны. <br />Если вы не получали письмо с ссылкой для активации, нажмите на - <a href = "/users/resendActivation/' . $session->user->id . '"><b>повторно выслать ссылку активации</b></a>');
103 104
             }
104 105
             if (!$session->user->mail && !empty($this->config['noMailNotify'])) {
@@ -107,7 +108,8 @@  discard block
 block discarded – undo
107 108
             Users\User::$cur = $session->user;
108 109
             Users\User::$cur->date_last_active = 'CURRENT_TIMESTAMP';
109 110
             Users\User::$cur->save();
110
-        } else {
111
+        }
112
+        else {
111 113
             if (!headers_sent()) {
112 114
                 setcookie($this->cookiePrefix . "_user_session_hash", '', 0, "/");
113 115
                 setcookie($this->cookiePrefix . "_user_id", '', 0, "/");
@@ -160,7 +162,8 @@  discard block
 block discarded – undo
160 162
         if ($user && $this->verifypass($pass, $user->pass) && !$user->blocked) {
161 163
             if (!empty($this->config['needActivation']) && $user->activation) {
162 164
                 Tools::redirect('/', 'Этот аккаунт ещё не активирован. <br />Если вы не получали письмо с ссылкой для активации, нажмите на - <a href = "/users/resendActivation/' . $user->id . '"><b>повторно выслать ссылку активации</b></a>');
163
-            } elseif ($user->activation) {
165
+            }
166
+            elseif ($user->activation) {
164 167
                 Msg::add('Этот аккаунт ещё не активирован, не все функции могут быть доступны. <br />Если вы не получали письмо с ссылкой для активации, нажмите на - <a href = "/users/resendActivation/' . $user->id . '"><b>повторно выслать ссылку активации</b></a>');
165 168
             }
166 169
             if (!$user->mail && !empty($this->config['noMailNotify'])) {
@@ -179,9 +182,11 @@  discard block
 block discarded – undo
179 182
         if (!$noMsg) {
180 183
             if ($user && $user->blocked) {
181 184
                 Msg::add('Вы заблокированы', 'danger');
182
-            } elseif ($user) {
185
+            }
186
+            elseif ($user) {
183 187
                 Msg::add('Вы ошиблись при наборе пароля или логина, попробуйте ещё раз или воспользуйтесь <a href = "?passre=1&user_mail=' . $user->mail . '">Восстановлением пароля</a>', 'danger');
184
-            } else {
188
+            }
189
+            else {
185 190
                 Msg::add('Данный почтовый ящик не зарегистрирован в системе', 'danger');
186 191
             }
187 192
         }
@@ -204,7 +209,8 @@  discard block
 block discarded – undo
204 209
         if (!headers_sent()) {
205 210
             setcookie($this->cookiePrefix . "_user_session_hash", $session->hash, time() + 360000, "/");
206 211
             setcookie($this->cookiePrefix . "_user_id", $session->user_id, time() + 360000, "/");
207
-        } else {
212
+        }
213
+        else {
208 214
             Msg::add('Не удалось провести авторизацию. Попробуйте позже', 'info');
209 215
         }
210 216
     }
@@ -217,17 +223,22 @@  discard block
 block discarded – undo
217 223
      * @return boolean|\User\User
218 224
      */
219 225
     public function get($idn, $ltype = 'id') {
220
-        if (!$idn)
221
-            return false;
226
+        if (!$idn) {
227
+                    return false;
228
+        }
222 229
 
223
-        if (is_numeric($idn) && $ltype != 'login')
224
-            $user = Users\User::get($idn, 'id');
225
-        elseif ($ltype == 'login')
226
-            $user = Users\User::get($idn, 'login');
227
-        else
228
-            $user = Users\User::get($idn, 'mail');
229
-        if (!$user)
230
-            return [];
230
+        if (is_numeric($idn) && $ltype != 'login') {
231
+                    $user = Users\User::get($idn, 'id');
232
+        }
233
+        elseif ($ltype == 'login') {
234
+                    $user = Users\User::get($idn, 'login');
235
+        }
236
+        else {
237
+                    $user = Users\User::get($idn, 'mail');
238
+        }
239
+        if (!$user) {
240
+                    return [];
241
+        }
231 242
 
232 243
         return $user;
233 244
     }
@@ -309,7 +320,8 @@  discard block
 block discarded – undo
309 320
                 return false;
310 321
             }
311 322
             $pass = $data['user_pass'][0];
312
-        } else {
323
+        }
324
+        else {
313 325
             $pass = Tools::randomString(10);
314 326
         }
315 327
 
@@ -355,7 +367,8 @@  discard block
 block discarded – undo
355 367
             $text .= 'Для активации вашего аккаунта перейдите по ссылке <a href = "http://' . INJI_DOMAIN_NAME . '/users/activation/' . $user->id . '/' . $user->activation . '">http://' . idn_to_utf8(INJI_DOMAIN_NAME) . '/users/activation/' . $user->id . '/' . $user->activation . '</a>';
356 368
             Tools::sendMail($from, $to, $subject, $text);
357 369
             Msg::add('Вы были зарегистрированы. На указанный почтовый ящик был выслан ваш пароль и ссылка для активации', 'success');
358
-        } else {
370
+        }
371
+        else {
359 372
             $from = 'noreply@' . INJI_DOMAIN_NAME;
360 373
             $to = $data['user_mail'];
361 374
             $subject = 'Регистрация на сайте ' . idn_to_utf8(INJI_DOMAIN_NAME);
@@ -387,7 +400,8 @@  discard block
 block discarded – undo
387 400
             if (!$userIds && $levels) {
388 401
                 $levels[$i] = [];
389 402
                 continue;
390
-            } elseif (!$userIds && !$levels) {
403
+            }
404
+            elseif (!$userIds && !$levels) {
391 405
                 break;
392 406
             }
393 407
             $usersLevel = \Users\User::getList(['where' => [['parent_id', $userIds, 'IN']]]);
Please login to merge, or discard this patch.
system/modules/Users/models/User.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -170,7 +170,8 @@
 block discarded – undo
170 170
     public function name() {
171 171
         if ($this->info) {
172 172
             return trim($this->info->name());
173
-        } else {
173
+        }
174
+        else {
174 175
             $this->id;
175 176
         }
176 177
     }
Please login to merge, or discard this patch.
system/modules/Users/models/User/Info.php 1 patch
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -99,7 +99,8 @@
 block discarded – undo
99 99
                 $name.=($name ? ' ' : '') . $this->last_name;
100 100
             }
101 101
             return $name;
102
-        } else {
102
+        }
103
+        else {
103 104
             return $this->user_id;
104 105
         }
105 106
     }
Please login to merge, or discard this patch.