DataManagerController::groupActionAction() - Code Metrics - Inspection of "relModel dataManager fix" - injitools/cms-Inji - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e999e7...604db9 )

by Alexey

created 2016-02-01 09:16 UTC

DataManagerController::groupActionAction() D

↳ Parent: DataManagerController

Complexity

Conditions	21
Paths	216

Size

Total Lines	75
Code Lines	56

Duplication

Lines	28
Ratio	37.33 %

Metric	Value
dl	28
loc	75
rs	4.6077
cc	21
eloc	56
nc	216
nop	0

How to fix Long Method Complexity

<?php

/**
 * Data manager controller
 *
 * @author Alexey Krupskiy <[email protected]>
 * @link http://inji.ru/
 * @copyright 2015 Alexey Krupskiy
 * @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
 */
class DataManagerController extends Controller
namespace YourVendor;

class YourClass { }
{
    function indexAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $result = new Server\Result();
        ob_start();
        $params = [];
        if (!empty($_GET['params'])) {
            $params = $_GET['params'];
        }
        if (strpos($_GET['item'], ':')) {
            $raw = explode(':', $_GET['item']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id, $modelName::index(), $params);
        } else {
            $modelName = $_GET['item'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
        }
        if (!empty($_GET['params']['relation'])) {
            $params['relation'] = $_GET['params']['relation'];
            $relations = $modelName::relations();
            $type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';

            switch ($type) {
                case 'relModel':
                    $modelName = $relations[$_GET['params']['relation']]['relModel'];
                    break;
                default:
                    $modelName = $relations[$_GET['params']['relation']]['model'];
            }
        }
        $dataManager = new Ui\DataManager($modelName, 'manager');
        $dataManager->draw($params, $model);
        $result->content = ob_get_contents();
        ob_end_clean();
        $result->send();
    }

    //function 

    function loadRowsAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $result = new Server\Result();
        $result->content = [];
        ob_start();
        $params = [];
        if (!empty($_GET['params'])) {
            $params = $_GET['params'];
        }
        if (strpos($_GET['modelName'], ':')) {

            $raw = explode(':', $_GET['modelName']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id, $modelName::index(), $params);
        } else {
            $modelName = $_GET['modelName'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
        }
        if (!empty($_GET['params']['relation'])) {
            $params['relation'] = $_GET['params']['relation'];
            $relations = $modelName::relations();
            $type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';

            switch ($type) {
                case 'relModel':
                    $modelName = $relations[$_GET['params']['relation']]['relModel'];
                    break;
                default:
                    $modelName = $relations[$_GET['params']['relation']]['model'];
            }
        }
        if (!empty($_GET['filters'])) {
            $params['filters'] = $_GET['filters'];
        }

        if (!empty($_GET['sortered'])) {
            $params['sortered'] = $_GET['sortered'];
        }
        if (!empty($_GET['mode'])) {
            $params['mode'] = $_GET['mode'];
        }
        if (!empty($_GET['all'])) {
            $params['all'] = true;
        }
        $dataManager = new Ui\DataManager($modelName, $_GET['managerName']);
        if (!empty($_GET['download'])) {
            $params['all'] = true;
            $params['download'] = true;
            set_time_limit(0);
            ob_end_clean();
            header('Content-Encoding: UTF-8');
            header("Content-Type: text/csv");
            header("Content-Disposition: attachment; filename=" . $modelName::$objectName . '.csv');
            echo "\xEF\xBB\xBF"; // UTF-8 BOM


            $cols = $dataManager->getCols();
            $cols = array_slice($cols, (!empty($dataManager->managerOptions['groupActions']) ? 1 : 0));
            $endRow = true;
            foreach ($cols as $colName => $options) {
                if (!$endRow) {
                    echo ";";
                }
                $endRow = false;
                echo '"' . $options['label'] . '"';
            }
            echo "\n";
            $endRow = true;
        }
        $rows = $dataManager->getRows($params, $model);
        foreach ($rows as $row) {
            if (!empty($_GET['download'])) {
                $row = array_slice($row, (!empty($dataManager->managerOptions['groupActions']) ? 1 : 0), -1);
                foreach ($row as $col) {
                    if (!$endRow) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                        echo ";";
                    }
                    $endRow = false;
                    echo '"' . str_replace("\n", '', $col) . '"';
                }
                echo "\n";
                $endRow = true;
            } else {
                Ui\Table::drawRow($row);
            }
        }
        if (!empty($_GET['download'])) {
            exit();

        }
        $result->content['rows'] = ob_get_contents();
        ob_clean();
        $result->content['pages'] = '';
        if (empty($params['all'])) {
            $pages = $dataManager->getPages($params, $model);

            if ($pages) {
                $pages->draw();
            }
            $result->content['pages'] = ob_get_contents();
            ob_end_clean();
        }
        $result->send();
    }

    function loadCategorysAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $result = new Server\Result();
        ob_start();
        if (strpos($_GET['modelName'], ':')) {

            $raw = explode(':', $_GET['modelName']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $modelName = $_GET['modelName'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        if (!empty($_GET['params'])) {
            $params = $_GET['params'];
            if (!empty($params['relation'])) {
                $relations = $modelName::relations();
                $modelName = $relations[$params['relation']]['model'];
            }
        } else {
            $params = [];
        }
        if (!empty($_GET['filters'])) {
            $params['filters'] = $_GET['filters'];
        }
        $dataManager = new Ui\DataManager($modelName, $_GET['managerName']);
        $dataManager->drawCategorys();
        $result->content = ob_get_contents();
        ob_end_clean();
        $result->send();
    }

    function delRowAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (strpos($_GET['modelName'], ':')) {

            $raw = explode(':', $_GET['modelName']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $modelName = $_GET['modelName'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        if (!empty($_GET['params'])) {

            $params = $_GET['params'];
            if (!empty($params['relation'])) {
                $relations = $modelName::relations();

                $type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';

                switch ($type) {
                    case 'relModel':
                        $modelName = $relations[$_GET['params']['relation']]['relModel'];
                        break;
                    default:
                        $modelName = $relations[$_GET['params']['relation']]['model'];
                }
            }
        } else {
            $params = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        $dataManager = new Ui\DataManager($modelName, $_GET['managerName']);
        if ($dataManager->checkAccess()) {
            $model = $modelName::get($_GET['key'], $modelName::index(), !empty($_GET['params']) ? $_GET['params'] : []);
            if ($model) {
                $model->delete(!empty($_GET['params']) ? $_GET['params'] : []);
            }
        }
        $result = new Server\Result();
        $result->successMsg = empty($_GET['silence']) ? 'Запись удалена' : '';
        $result->send();
    }

    function updateRowAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        if (strpos($_GET['modelName'], ':')) {

            $raw = explode(':', $_GET['modelName']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        } else {
            $modelName = $_GET['modelName'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        $params = [];
        if (!empty($_GET['params'])) {

            $params = $_GET['params'];
            if (!empty($_GET['params']['relation'])) {
                $relations = $modelName::relations();
                $type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';

                switch ($type) {
                    case 'relModel':
                        $modelName = $relations[$_GET['params']['relation']]['relModel'];
                        break;
                    default:
                        $modelName = $relations[$_GET['params']['relation']]['model'];
                }
            }
        }
        $dataManager = new Ui\DataManager($modelName, $_GET['managerName']);
        if ($dataManager->checkAccess()) {
            $model = $modelName::get($_GET['key'], $modelName::index(), !empty($_GET['params']) ? $_GET['params'] : []);
            if ($model) {
                $model->$_GET['col'] = $_GET['col_value'];
                $model->save($params);
            }
        }
        $result = new Server\Result();
        $result->successMsg = empty($_GET['silence']) ? 'Запись Обновлена' : '';
        $result->send();
    }

    function groupActionAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {


        if (strpos($_GET['modelName'], ':')) {

            $raw = explode(':', $_GET['modelName']);
            $modelName = $raw[0];
            $id = $raw[1];
            $model = $modelName::get($id);
        } else {
            $modelName = $_GET['modelName'];
            $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $model = null;
        }
        if (!empty($_GET['params'])) {

            $params = $_GET['params'];
            if (!empty($params['relation'])) {
                $relations = $modelName::relations();

                $type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';

                switch ($type) {
                    case 'relModel':
                        $modelName = $relations[$_GET['params']['relation']]['relModel'];
                        break;
                    default:
                        $modelName = $relations[$_GET['params']['relation']]['model'];
                }
            }
        } else {
            $params = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }
        $dataManager = new Ui\DataManager($modelName, $_GET['managerName']);
        if ($dataManager->checkAccess()) {
            if (!empty($_GET['action']) && !empty($dataManager->managerOptions['groupActions'][$_GET['action']]) && !empty($_GET['ids'])) {
                $action = $dataManager->managerOptions['groupActions'][$_GET['action']];
                switch ($action['action']) {
                    case'delete':
switch (true) {
    case!isset($a):  //wrong
        doSomething();
        break;
    case !isset($b):  //right
        doSomething();
        break;
}
                        $ids = filter_input(INPUT_GET, 'ids', FILTER_SANITIZE_STRING);
                        if ($ids) {
                            $ids = trim($ids, ',');
                            $models = $modelName::getList(['where' => [[$modelName::index(), $ids, 'IN']]]);
                            foreach ($models as $model) {
                                $model->delete();
                            }
                        }
                        break;
                    case 'changeParam':
                        $ids = filter_input(INPUT_GET, 'ids', FILTER_SANITIZE_STRING);
                        if ($ids) {
                            $ids = trim($ids, ',');
                            $models = $modelName::getList(['where' => [[$modelName::index(), $ids, 'IN']]]);
                            foreach ($models as $model) {
                                $model->{$action['col']} = $action['value'];
                                $model->save(!empty($_GET['params']) ? $_GET['params'] : []);
                            }
                        }
                        break;
                    case 'moduleMethod':
                        $ids = filter_input(INPUT_GET, 'ids', FILTER_SANITIZE_STRING);
                        if ($ids) {
                            $comandResult = App::$cur->$action['module']->$action['method']($dataManager, trim($ids, ','), !empty($_GET['adInfo']) ? $_GET['adInfo'] : []);
                        }
                        break;
                }
            }
        }
        $result = new Server\Result();
        if (!empty($comandResult)) {
            $result->success = $comandResult['success'];
            $result->content = $comandResult['content'];
        }
        $result->successMsg = 'Операция выполнена';
        $result->send();
    }

    function delCategoryAction()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        $dataManager = new Ui\DataManager($_GET['modelName'], $_GET['managerName']);
        if ($dataManager->checkAccess() && !empty($dataManager->managerOptions['categorys'])) {
            $categoryModel = $dataManager->managerOptions['categorys']['model'];
            $model = $categoryModel::get($_GET['key'], $categoryModel::index(), !empty($_GET['params']) ? $_GET['params'] : []);
            if ($model) {
                $model->delete(!empty($_GET['params']) ? $_GET['params'] : []);
            }
        }
        $result = new Server\Result();
        $result->send();
    }

}


1			<?php
2
3			/**
4			* Data manager controller
5			*
6			* @author Alexey Krupskiy <[email protected]>
7			* @link http://inji.ru/
8			* @copyright 2015 Alexey Krupskiy
9			* @license https://github.com/injitools/cms-Inji/blob/master/LICENSE
10			*/
11			class DataManagerController extends Controller
			1 ignored issue – show Coding Style Compatibility introduced 2016-01-31 20:44 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
12			{
13			function indexAction()
			1 ignored issue – show Best Practice introduced 2016-01-31 20:44 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history... Coding Style introduced 2016-01-31 20:44 UTC by Report Bug Copy Issue Report `indexAction` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
14			{
15			$result = new Server\Result();
16			ob_start();
17			$params = [];
18			if (!empty($_GET['params'])) {
19			$params = $_GET['params'];
20			}
21			if (strpos($_GET['item'], ':')) {
22			$raw = explode(':', $_GET['item']);
23			$modelName = $raw[0];
24			$id = $raw[1];
25			$model = $modelName::get($id, $modelName::index(), $params);
26			} else {
27			$modelName = $_GET['item'];
28			$id = null;
			0 ignored issues – show Unused Code introduced 2016-01-31 20:44 UTC by Report Bug Copy Issue Report `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29			$model = null;
30			}
31			if (!empty($_GET['params']['relation'])) {
32			$params['relation'] = $_GET['params']['relation'];
33			$relations = $modelName::relations();
34			$type = !empty($relations[$_GET['params']['relation']]['type']) ? $relations[$_GET['params']['relation']]['type'] : 'to';
35
36			switch ($type) {
37			case 'relModel':

injitools / cms-Inji

Push — master ( e999e7...604db9 )

DataManagerController::groupActionAction() D

Complexity

Size

Duplication

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like