Ecommerce\DeliveryProvider\CDEK

Complexity

Total Complexity

15

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	11

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	calcPrice()	0	53	15

<?php
/**
 * INJI
 *
 * @author Alexey Krupskiy <admin@inji.ru>
 * @link http://inji.ru/
 * @copyright 2017 Alexey Krupskiy
 * @license https://github.com/injitools/Inji/blob/master/LICENSE
 */

namespace Ecommerce\DeliveryProvider;

use Ecommerce\Delivery\Field\Item;
use Ecommerce\Delivery\Provider\ConfigItem;

class CDEK extends \Ecommerce\DeliveryProvider {
    static $name = 'СДЭК - курьерская служба';

The visibility should be declared for property $name.

    /**
     * @param \Ecommerce\Cart $cart
     * @return \Money\Sums
     */
    static function calcPrice($cart) {

It is generally recommended to explicitly declare the visibility for methods.

        $calc = new \Ecommerce\Vendor\CalculatePriceDeliveryCdek();
        $fields = [];

$fields is not used, you could remove the assignment.

        $cityId = 0;
        $senderCity = 44;

$senderCity is not used, you could remove the assignment.

        foreach ($cart->delivery->fields as $field) {
            if ($field->code === 'city' && !empty($_POST['deliveryFields'][$field->id]) && is_string($_POST['deliveryFields'][$field->id])) {
                $item = Item::get([['id', $_POST['deliveryFields'][$field->id]], ['delivery_field_id', $field->id]]);
                if ($item) {
                    $cityId = json_decode($item->data, true)['ID'];
                }
            }
        }
        if ($cityId == 278) {
            $senderCity = 278;
            foreach ($cart->cartItems as $cartItem) {
                if ($cartItem->item->offers(['key' => false]) && $cartItem->item->offers(['key' => false])[0]->warehouses) {

The call to Item::offers() has too many arguments starting with array('key' => false).

The expression $cartItem->item->offers(array('key' => false))[0]->warehouses of type Ecommerce\Item\Offer\Warehouse[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                    $msocow = 0;
                    $kras = 0;
                    foreach ($cartItem->item->offers(['key' => false])[0]->warehouses as $warehouse) {

The call to Item::offers() has too many arguments starting with array('key' => false).

                        if ($warehouse->warehouse_id != 6) {
                            $kras += $warehouse->count;
                        } else {
                            $msocow += $warehouse->count;
                        }

                    }
                    if ($kras < $cartItem->count) {
                        $senderCity = 44;
                    }
                }
            }
        } else {
            $senderCity = 44;
        }
        if ($cityId) {
            $config = ConfigItem::getList(['where' => ['delivery_provider_id', $cart->delivery->delivery_provider_id], 'key' => 'name']);
            $calc->setAuth($config['authLogin']->value, $config['authPassword']->value);
            $calc->setDateExecute(date('Y-m-d H:i:s'));
            $calc->setSenderCityId($senderCity);
            //устанавливаем город-получатель
            $calc->setReceiverCityId($cityId);
            $calc->setTariffId('136');
            $calc->addGoodsItemBySize(3, 25, 25, 24);
            if ($calc->calculate()) {
                return new \Money\Sums([$cart->delivery->currency_id => $calc->getResult()['result']['price']]);
            } else {

This else statement is empty and can be removed.

                //var_dump($calc->getError());

78% of this comment could be valid code. Did you maybe forget this after debugging?

            }

        }
        return new \Money\Sums([$cart->delivery->currency_id => 0]);
    }
}