injitools /
cms-Inji
| Total Complexity | 101 |
| Total Lines | 353 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like ActiveForm often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ActiveForm, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 17 | class ActiveForm extends \Inji\InjiObject { |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @var \Inji\Model |
||
| 21 | */ |
||
| 22 | public $model = null; |
||
| 23 | public $modelName = ''; |
||
| 24 | public $label = null; |
||
| 25 | public $action = ""; |
||
| 26 | public $form = []; |
||
| 27 | public $inputs = []; |
||
| 28 | public $name = 'manager'; |
||
| 29 | public $requestFormName = ''; |
||
| 30 | public $requestFullFormName = ''; |
||
| 31 | public $parent = null; |
||
| 32 | public $connection = 'default'; |
||
| 33 | public $dbOptions = []; |
||
| 34 | |||
| 35 | public function __construct() { |
||
| 36 | $this->requestFormName = 'ActiveForm_' . str_replace('\\', '_', $this->modelName); |
||
| 37 | } |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @param $modelName |
||
| 41 | * @param $formName |
||
| 42 | * @return static |
||
| 43 | */ |
||
| 44 | public static function forModel($modelName, $formName = 'manager') { |
||
| 45 | if ($formName !== 'manager') { |
||
| 46 | $className = $modelName . ucfirst($formName) . 'ActiveForm'; |
||
| 47 | } else { |
||
| 48 | $className = $modelName . 'ActiveForm'; |
||
| 49 | } |
||
| 50 | return new $className(); |
||
| 51 | } |
||
| 52 | |||
| 53 | public function modelBuilderFromParams($params = []) { |
||
| 59 | } |
||
| 60 | |||
| 61 | public function loadModelById($id, $options = []) { |
||
| 62 | $builder = $this->modelBuilderFromParams($options); |
||
| 63 | $builder->where($this->modelName::index(), $id); |
||
| 64 | $this->model = $builder->get(); |
||
| 65 | } |
||
| 66 | |||
| 67 | public function setModel($model) { |
||
| 68 | $this->model = $model; |
||
| 69 | } |
||
| 70 | |||
| 71 | public function emptyModel() { |
||
| 72 | $this->model = $this->modelName::create(); |
||
| 73 | $this->model->connectionName = $this->connection; |
||
| 74 | $this->model->dbOptions = $this->dbOptions; |
||
| 75 | } |
||
| 76 | |||
| 77 | public function getInputs() { |
||
| 78 | $inputs = !empty($this->form['inputs']) ? $this->form['inputs'] : []; |
||
| 79 | $modelName = $this->modelName; |
||
| 80 | foreach ($this->map as $row) { |
||
| 81 | foreach ($row as $col) { |
||
| 82 | if (!$col || !empty($inputs[$col])) { |
||
| 83 | continue; |
||
| 84 | } |
||
| 85 | if (strpos($col, 'form:') === 0) { |
||
| 86 | $colPath = explode(':', $col); |
||
| 87 | if ($this->model->{$colPath[1]}) { |
||
|
|
|||
| 88 | //$inputs[$col] = new ActiveForm($this->model->{$colPath[1]}, $colPath[2]); |
||
| 89 | } else { |
||
| 90 | $relOptions = $modelName::getRelation($colPath[1]); |
||
| 91 | if (!isset($this->model->_params[$modelName::index()])) { |
||
| 92 | $this->model->_params[$modelName::index()] = 0; |
||
| 93 | } |
||
| 94 | $relOptions['model']::fixPrefix($relOptions['col']); |
||
| 95 | //$inputs[$col] = new ActiveForm(new $relOptions['model'](), $colPath[2]); |
||
| 96 | } |
||
| 97 | $inputs[$col]->parent = $this; |
||
| 98 | |||
| 99 | $inputs[$col]->parent = $this; |
||
| 100 | } elseif (!empty($modelName::$cols[$col])) { |
||
| 101 | $inputs[$col] = $modelName::$cols[$col]; |
||
| 102 | } |
||
| 103 | } |
||
| 104 | } |
||
| 105 | return $inputs; |
||
| 106 | } |
||
| 107 | |||
| 108 | public function checkRequest($params = [], $ajax = false) { |
||
| 109 | if (!$this->checkAccess()) { |
||
| 110 | $this->drawError('you not have access to "' . $this->modelName . '" manager with name: "' . $this->formName . '"'); |
||
| 111 | return []; |
||
| 112 | } |
||
| 113 | $successId = 0; |
||
| 114 | $modelName = $this->model; |
||
| 115 | if (!empty($_POST[$this->requestFormName][$this->modelName]) || !empty($_FILES[$this->requestFormName]['tmp_name'][$this->modelName])) { |
||
| 116 | $request = !empty($_POST[$this->requestFormName][$this->modelName]) ? $_POST[$this->requestFormName][$this->modelName] : []; |
||
| 117 | if ($this->model) { |
||
| 118 | if (!empty($this->form['handler']) && empty($_GET['notSave'])) { |
||
| 119 | |||
| 120 | $modelName::{$this->form['handler']}($request); |
||
| 121 | $text = 'Новый элемент был успешно добавлен'; |
||
| 122 | \Inji\Msg::add($text, 'success'); |
||
| 123 | \Inji\Msg::show(); |
||
| 124 | } else { |
||
| 125 | $presets = !empty($this->form['preset']) ? $this->form['preset'] : []; |
||
| 126 | if (!empty($this->form['userGroupPreset'][\Inji\Users\User::$cur->group_id])) { |
||
| 127 | $presets = array_merge($presets, $this->form['userGroupPreset'][\Inji\Users\User::$cur->group_id]); |
||
| 128 | } |
||
| 129 | $afterSave = []; |
||
| 130 | $error = false; |
||
| 131 | foreach ($this->getInputs() as $col => $param) { |
||
| 132 | if (!empty($presets[$col])) { |
||
| 133 | continue; |
||
| 134 | } |
||
| 135 | if (is_object($param)) { |
||
| 136 | $afterSave[$col] = $param; |
||
| 137 | continue; |
||
| 138 | } |
||
| 139 | if (!empty($this->form['userGroupReadonly'][\Inji\Users\User::$cur->group_id]) && in_array($col, $this->form['userGroupReadonly'][\Inji\Users\User::$cur->group_id])) { |
||
| 140 | continue; |
||
| 141 | } |
||
| 142 | $type = $param['type']; |
||
| 143 | if ($type == 'DynamicType') { |
||
| 144 | switch ($param['typeSource']) { |
||
| 145 | case 'selfMethod': |
||
| 146 | $type = $this->model->{$param['selfMethod']}(); |
||
| 147 | if (is_array($type)) { |
||
| 148 | $param = $type; |
||
| 149 | $type = $type['type']; |
||
| 150 | } |
||
| 151 | break; |
||
| 152 | } |
||
| 153 | } |
||
| 154 | if ($type == 'bool') { |
||
| 155 | $type = 'checkbox'; |
||
| 156 | } |
||
| 157 | $inputClassName = 'Inji\Ui\ActiveForm\Input\\' . ucfirst($type); |
||
| 158 | /** @var \Inji\Ui\ActiveForm\Input $input */ |
||
| 159 | $input = new $inputClassName(); |
||
| 160 | $input->activeForm = $this; |
||
| 161 | $input->activeFormParams = $params; |
||
| 162 | $input->modelName = $this->modelName; |
||
| 163 | $input->colName = $col; |
||
| 164 | $input->colParams = $param; |
||
| 165 | try { |
||
| 166 | $input->validate($request); |
||
| 167 | $input->parseRequest($request); |
||
| 168 | } catch (\Exception $exc) { |
||
| 169 | \Inji\Msg::add($exc->getMessage(), 'danger'); |
||
| 170 | $error = true; |
||
| 171 | } |
||
| 172 | } |
||
| 173 | if (!$error && empty($_GET['notSave'])) { |
||
| 174 | foreach ($presets as $col => $preset) { |
||
| 175 | if (!empty($preset['value'])) { |
||
| 176 | $this->model->$col = $preset['value']; |
||
| 177 | } elseif (!empty($preset['userCol'])) { |
||
| 178 | if (strpos($preset['userCol'], ':')) { |
||
| 179 | $rel = substr($preset['userCol'], 0, strpos($preset['userCol'], ':')); |
||
| 180 | $param = substr($preset['userCol'], strpos($preset['userCol'], ':') + 1); |
||
| 181 | $this->model->$col = \Inji\Users\User::$cur->$rel->$param; |
||
| 182 | } else { |
||
| 183 | $this->model->$col = \Inji\Users\User::$cur->{$preset['userCol']}; |
||
| 184 | } |
||
| 185 | } |
||
| 186 | } |
||
| 187 | if (!$this->parent) { |
||
| 188 | if (!empty($this->form['successText'])) { |
||
| 189 | $text = $this->form['successText']; |
||
| 190 | } else { |
||
| 191 | $text = $this->model->pk() ? 'Изменения были успешно сохранены' : 'Новый элемент был успешно добавлен'; |
||
| 192 | } |
||
| 193 | \Inji\Msg::add($text, 'success'); |
||
| 194 | } |
||
| 195 | $this->model->save(!empty($params['dataManagerParams']) ? $params['dataManagerParams'] : []); |
||
| 196 | foreach ($afterSave as $col => $form) { |
||
| 197 | if (strpos($col, 'form:') === 0) { |
||
| 198 | $colPath = explode(':', $col); |
||
| 199 | if (!$this->model->{$colPath[1]}) { |
||
| 200 | $relOptions = $modelName::getRelation($colPath[1]); |
||
| 201 | if (!isset($this->model->_params[$modelName::index()])) { |
||
| 202 | $this->model->_params[$modelName::index()] = 0; |
||
| 203 | } |
||
| 204 | $relOptions['model']::fixPrefix($relOptions['col']); |
||
| 205 | $form->model->{$relOptions['col']} = $this->model->_params[$modelName::index()]; |
||
| 206 | } |
||
| 207 | } |
||
| 208 | $form->checkRequest(); |
||
| 209 | } |
||
| 210 | if ($ajax) { |
||
| 211 | \Inji\Msg::show(); |
||
| 212 | } elseif (!empty($_GET['redirectUrl'])) { |
||
| 213 | \Inji\Tools::redirect($_GET['redirectUrl'] . (!empty($_GET['dataManagerHash']) ? '#' . $_GET['dataManagerHash'] : '')); |
||
| 214 | } |
||
| 215 | $successId = $this->model->pk(); |
||
| 216 | } |
||
| 217 | } |
||
| 218 | } |
||
| 219 | if (!is_array($params) && is_callable($params)) { |
||
| 220 | $params($request); |
||
| 221 | } |
||
| 222 | } |
||
| 223 | return $successId; |
||
| 224 | } |
||
| 225 | |||
| 226 | public function draw($params = [], $ajax = false) { |
||
| 227 | if (!$this->checkAccess()) { |
||
| 228 | $this->drawError('you not have access to "' . $this->modelName . '" form with name: "' . $this->formName . '"'); |
||
| 229 | return []; |
||
| 230 | } |
||
| 231 | $form = new Form(!empty($this->form['formOptions']) ? $this->form['formOptions'] : []); |
||
| 232 | App::$cur->view->widget('Ui\ActiveForm', ['form' => $form, 'activeForm' => $this, 'ajax' => $ajax, 'params' => $params]); |
||
| 233 | } |
||
| 234 | |||
| 235 | public function drawCol($colName, $options, $form, $params = []) { |
||
| 236 | if (is_object($options)) { |
||
| 237 | $options->draw(); |
||
| 238 | } else { |
||
| 239 | $type = $options['type']; |
||
| 240 | if ($type == 'DynamicType') { |
||
| 241 | switch ($options['typeSource']) { |
||
| 242 | case 'selfMethod': |
||
| 243 | $type = $this->model->{$options['selfMethod']}(); |
||
| 244 | if (is_array($type)) { |
||
| 245 | $options = $type; |
||
| 246 | $type = $type['type']; |
||
| 247 | } |
||
| 248 | break; |
||
| 249 | } |
||
| 250 | } |
||
| 251 | if ($type == 'bool') { |
||
| 252 | $type = 'checkbox'; |
||
| 253 | } |
||
| 254 | $inputClassName = '\Inji\Ui\ActiveForm\Input\\' . ucfirst($type); |
||
| 255 | $input = new $inputClassName(); |
||
| 256 | $input->form = $form; |
||
| 257 | $input->activeForm = $this; |
||
| 258 | $input->activeFormParams = $params; |
||
| 259 | $input->modelName = $this->modelName; |
||
| 260 | $input->colName = $colName; |
||
| 261 | $input->colParams = $options; |
||
| 262 | $input->options = !empty($options['options']) ? $options['options'] : []; |
||
| 263 | $input->draw(); |
||
| 264 | } |
||
| 265 | return true; |
||
| 266 | } |
||
| 267 | |||
| 268 | public static function getOptionsList($inputParams, $params = [], $modelName = '', $aditionalInputNamePrefix = 'aditional', $options = [], $model = false) { |
||
| 269 | $values = []; |
||
| 270 | switch ($inputParams['source']) { |
||
| 271 | case 'model': |
||
| 272 | $values = $inputParams['model']::getList(['forSelect' => true]); |
||
| 273 | break; |
||
| 274 | case 'array': |
||
| 275 | $values = $inputParams['sourceArray']; |
||
| 276 | break; |
||
| 277 | case 'method': |
||
| 278 | if (!empty($inputParams['params'])) { |
||
| 279 | $values = call_user_func_array([\App::$cur->{$inputParams['module']}, $inputParams['method']], $inputParams['params'] + [$model]); |
||
| 280 | } else { |
||
| 281 | $values = \App::$cur->{$inputParams['module']}->{$inputParams['method']}($model); |
||
| 282 | } |
||
| 283 | break; |
||
| 284 | case 'relation': |
||
| 285 | if (!$modelName) { |
||
| 286 | return []; |
||
| 287 | } |
||
| 288 | $relation = $modelName::getRelation($inputParams['relation']); |
||
| 289 | if (!empty($params['dataManagerParams']['appType'])) { |
||
| 290 | $options['appType'] = $params['dataManagerParams']['appType']; |
||
| 291 | } |
||
| 292 | $items = []; |
||
| 293 | if (class_exists($relation['model'])) { |
||
| 294 | $filters = $relation['model']::managerFilters(); |
||
| 295 | if (!empty($filters['getRows']['where'])) { |
||
| 296 | $options['where'][] = $filters['getRows']['where']; |
||
| 297 | } |
||
| 298 | if (!empty($relation['where'])) { |
||
| 299 | $options['where'][] = $relation['where']; |
||
| 300 | } |
||
| 301 | if (!empty($relation['order'])) { |
||
| 302 | $options['order'] = $relation['order']; |
||
| 303 | } |
||
| 304 | if (!empty($inputParams['itemName'])) { |
||
| 305 | $options['itemName'] = $inputParams['itemName']; |
||
| 306 | } |
||
| 307 | $items = $relation['model']::getList($options); |
||
| 308 | } |
||
| 309 | if (!empty($params['noEmptyValue'])) { |
||
| 310 | $values = []; |
||
| 311 | } else { |
||
| 312 | $values = [0 => 'Не задано']; |
||
| 313 | } |
||
| 314 | foreach ($items as $key => $item) { |
||
| 315 | if (!empty($inputParams['showCol'])) { |
||
| 316 | if (is_array($inputParams['showCol'])) { |
||
| 317 | switch ($inputParams['showCol']['type']) { |
||
| 318 | case 'staticMethod': |
||
| 319 | $values[$key] = $inputParams['showCol']['class']::{$inputParams['showCol']['method']}($item); |
||
| 320 | break; |
||
| 321 | } |
||
| 322 | } else { |
||
| 323 | $values[$key] = $item->{$inputParams['showCol']}; |
||
| 324 | } |
||
| 325 | } else { |
||
| 326 | $values[$key] = $item->name(); |
||
| 327 | } |
||
| 328 | } |
||
| 329 | break; |
||
| 330 | } |
||
| 331 | foreach ($values as $key => $value) { |
||
| 332 | if (is_array($value) && !empty($value['input']) && empty($value['input']['noprefix'])) { |
||
| 333 | $values[$key]['input']['name'] = $aditionalInputNamePrefix . "[{$value['input']['name']}]"; |
||
| 334 | } |
||
| 335 | } |
||
| 336 | return $values; |
||
| 337 | } |
||
| 338 | |||
| 339 | /** |
||
| 340 | * Draw error message |
||
| 341 | * |
||
| 342 | * @param string $errorText |
||
| 343 | */ |
||
| 344 | public function drawError($errorText) { |
||
| 345 | echo $errorText; |
||
| 346 | } |
||
| 347 | |||
| 348 | /** |
||
| 349 | * Check access cur user to form with name in param and $model |
||
| 350 | * |
||
| 351 | * @return boolean |
||
| 352 | */ |
||
| 353 | public function checkAccess() { |
||
| 370 | } |
||
| 371 | } |
||
| 372 |
Loading history...
This check looks for the bodies of
ifstatements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete.These
ifbodies can be removed. If you have an empty if but statements in theelsebranch, consider inverting the condition.could be turned into
This is much more concise to read.