initx / querabilis

src/Driver/HasDefaultRemoveAndElement.php

<?php declare(strict_types=1);

namespace Initx\Querabilis\Driver;

use Initx\Querabilis\Envelope;
use Initx\Querabilis\Exception\NoSuchElementException;

trait HasDefaultRemoveAndElement
{
    public function remove(): Envelope
    {
        return $this->returnOrThrowNoSuchElement($this->poll());

It seems like poll() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function element(): Envelope
    {
        return $this->returnOrThrowNoSuchElement($this->peek());

It seems like peek() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    private function returnOrThrowNoSuchElement(?Envelope $envelope = null): Envelope
    {
        if (!$envelope) {
            throw new NoSuchElementException();
        }

        return $envelope;
    }
}