FilesystemQueue::removeFirstLine() - Code Metrics - Inspection of "remove and poll methods for FS queue driver" - initx/querabilis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4b9f01...160a67 )

by Damian

created 2019-05-27 19:47 UTC

FilesystemQueue::removeFirstLine() B

↳ Parent: FilesystemQueue

Complexity

Conditions	6
Paths	4

Size

Total Lines	30
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	6.3698

Importance

Changes

Metric	Value
eloc	22
dl	0
loc	30
ccs	18
cts	23
cp	0.7826
rs	8.9457
c	0
b	0
f	0
cc	6
nc	4
nop	0
crap	6.3698

<?php declare(strict_types=1);

namespace Initx\Driver;

use Initx\Envelope;
use Initx\Exception\IllegalStateException;
use Initx\Exception\NoSuchElementException;
use Initx\Queue;
use JMS\Serializer\SerializerBuilder;
use JMS\Serializer\SerializerInterface;
use Throwable;

final class FilesystemQueue implements Queue
{
    /**
     * @var string
     */
    private $path;

    /**
     * @var SerializerInterface
     */
    private $serializer;

    public function __construct(string $path, SerializerInterface $serializer = null)
    {
        if (!$serializer) {
            $serializer = SerializerBuilder::create()
                ->addMetadataDir(__DIR__ . '/../../config/jms', 'Initx')
                ->build();
        }
        $this->serializer = $serializer;
        $this->path = $path;
    }

    /**
     * Inserts an element if possible, otherwise throwing exception.
     *
     * @param Envelope $envelope
     * @return void
     * @throws IllegalStateException
     */
    public function add(Envelope $envelope): void
    {
        if (!$this->write($envelope)) {
            throw IllegalStateException::create("Could not write to {$this->path}");
        }
    }

    /**
     * Inserts an element if possible.
     *
     * @param Envelope $envelope
     * @return void
     */
    public function offer(Envelope $envelope): void
    {
        $this->write($envelope);
    }

    private function write(Envelope $envelope): bool
    {
        $content = $this->serializer->serialize($envelope, 'json');
        try {
            $result = (bool)file_put_contents(
                $this->path,
                $content,
                FILE_APPEND
            );
        } catch (Throwable $exception) {
            $result = false;
        }

        return $result;
    }

    /**
     * Remove and return head of queue, otherwise throwing exception.
     *
     * @return Envelope
     * @throws NoSuchElementException | IllegalStateException
     */
    public function remove(): Envelope
    {
        if (!$envelope = $this->poll()) {
            throw new NoSuchElementException('Queue empty');
        }

        return $envelope;
    }

    private function removeFirstLine(): ?string
    {
        if (!file_exists($this->path)) {
            throw new IllegalStateException("File $this->path not exists");
        }
        $firstLine = null;
        if ($handle = fopen($this->path, 'cb+')) {
            if (!flock($handle, LOCK_EX)) {
                fclose($handle);
            }
            $offset = 0;
            $len = filesize($this->path);
            while (($line = fgets($handle, 4096)) !== false) {
                if (!$firstLine) {
                    $firstLine = $line;
                    $offset = strlen($firstLine);
                    continue;
                }
                $pos = ftell($handle);
                fseek($handle, $pos - strlen($line) - $offset);
                fwrite($handle, $line);
                fseek($handle, $pos);
            }
            fflush($handle);
            ftruncate($handle, $len - $offset);
            flock($handle, LOCK_UN);
            fclose($handle);
        }

        return $firstLine;
    }

    /**
     * Remove and return head of queue, otherwise returning null.
     *
     * @return Envelope | null
     * @throws IllegalStateException
     */
    public function poll(): ?Envelope
    {
        $firstLine = $this->removeFirstLine();

        if (!$firstLine) {
            return null;
        }

        return $this->serializer->deserialize($firstLine, Envelope::class, 'json');
    }

    /**
     * Return but do not remove head of queue, otherwise throwing exception.
     *
     * @return Envelope
     * @throws NoSuchElementException
     */
    public function element(): Envelope
    {
        // TODO: Implement element() method.
    }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}

    /**
     * Return but do not remove head of queue, otherwise returning null.
     *
     * @return Envelope | null
     */
    public function peek(): ?Envelope
    {
        // TODO: Implement peek() method.
    }
}


1		<?php declare(strict_types=1);
2
3		namespace Initx\Driver;
4
5		use Initx\Envelope;
6		use Initx\Exception\IllegalStateException;
7		use Initx\Exception\NoSuchElementException;
8		use Initx\Queue;
9		use JMS\Serializer\SerializerBuilder;
10		use JMS\Serializer\SerializerInterface;
11		use Throwable;
12
13		final class FilesystemQueue implements Queue
14		{
15		/**
16		* @var string
17		*/
18		private $path;
19
20		/**
21		* @var SerializerInterface
22		*/
23		private $serializer;
24
25	7	public function __construct(string $path, SerializerInterface $serializer = null)
26		{
27	7	if (!$serializer) {
28	7	$serializer = SerializerBuilder::create()
29	7	->addMetadataDir(__DIR__ . '/../../config/jms', 'Initx')
30	7	->build();
31		}
32	7	$this->serializer = $serializer;
33	7	$this->path = $path;
34	7	}
35
36		/**
37		* Inserts an element if possible, otherwise throwing exception.
38		*
39		* @param Envelope $envelope
40		* @return void
41		* @throws IllegalStateException
42		*/
43	3	public function add(Envelope $envelope): void
44		{
45	3	if (!$this->write($envelope)) {
46	1	throw IllegalStateException::create("Could not write to {$this->path}");
47		}
48	2	}
49
50		/**
51		* Inserts an element if possible.
52		*
53		* @param Envelope $envelope
54		* @return void
55		*/
56	2	public function offer(Envelope $envelope): void
57		{
58	2	$this->write($envelope);
59	2	}
60
61	5	private function write(Envelope $envelope): bool
62		{
63	5	$content = $this->serializer->serialize($envelope, 'json');
64		try {
65	5	$result = (bool)file_put_contents(
66	5	$this->path,
67	5	$content,
68	5	FILE_APPEND
69		);
70	2	} catch (Throwable $exception) {
71	2	$result = false;
72		}
73
74	5	return $result;
75		}
76
77		/**
78		* Remove and return head of queue, otherwise throwing exception.
79		*
80		* @return Envelope
81		* @throws NoSuchElementException \| IllegalStateException
82		*/
83	3	public function remove(): Envelope
84		{
85	3	if (!$envelope = $this->poll()) {
86	1	throw new NoSuchElementException('Queue empty');
87		}
88
89	1	return $envelope;
90		}
91
92	3	private function removeFirstLine(): ?string
93		{
94	3	if (!file_exists($this->path)) {
95	1	throw new IllegalStateException("File $this->path not exists");
96		}
97	2	$firstLine = null;
98	2	if ($handle = fopen($this->path, 'cb+')) {
99	2	if (!flock($handle, LOCK_EX)) {
100		fclose($handle);
101		}
102	2	$offset = 0;
103	2	$len = filesize($this->path);
104	2	while (($line = fgets($handle, 4096)) !== false) {
105	1	if (!$firstLine) {
106	1	$firstLine = $line;
107	1	$offset = strlen($firstLine);
108	1	continue;
109		}
110		$pos = ftell($handle);
111		fseek($handle, $pos - strlen($line) - $offset);
112		fwrite($handle, $line);
113		fseek($handle, $pos);
114		}
115	2	fflush($handle);
116	2	ftruncate($handle, $len - $offset);
117	2	flock($handle, LOCK_UN);
118	2	fclose($handle);
119		}
120
121	2	return $firstLine;
122		}
123
124		/**
125		* Remove and return head of queue, otherwise returning null.
126		*
127		* @return Envelope \| null
128		* @throws IllegalStateException
129		*/
130	3	public function poll(): ?Envelope
131		{
132	3	$firstLine = $this->removeFirstLine();
133
134	2	if (!$firstLine) {
135	1	return null;
136		}
137
138	1	return $this->serializer->deserialize($firstLine, Envelope::class, 'json');
139		}
140
141		/**
142		* Return but do not remove head of queue, otherwise throwing exception.
143		*
144		* @return Envelope
145		* @throws NoSuchElementException
146		*/
147		public function element(): Envelope
148		{
149		// TODO: Implement element() method.
150		}
		0 ignored issues – show Bug Best Practice introduced 2019-05-27 18:00 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `Initx\Envelope`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
151
152		/**
153		* Return but do not remove head of queue, otherwise returning null.
154		*
155		* @return Envelope \| null
156		*/
157		public function peek(): ?Envelope
158		{
159		// TODO: Implement peek() method.
160		}
161		}
162

initx / querabilis

Push — master ( 4b9f01...160a67 )

FilesystemQueue::removeFirstLine() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like