Issues in Request.php (master) - Issues in master - ingeniasoftware/luthier - Measure and Improve Code Quality continuously with Scrutinizer

Issues (45)

Security Analysis no vulnerabilities found

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Middleware/Request.php (9 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 * Luthier Request middleware (internal)
 *
 * @author    Anderson Salas <[email protected]>
 * @copyright 2017
 * @license   GNU-3.0
 *
 */

namespace Luthier\Middleware;

use Luthier\Core\Route as Route;

class Request extends \Luthier\Core\Middleware
{

    /**
     * Current (improved) route
     *
     * @var $route
     *
     * @access protected
     */
    protected $route;

    /**
     * Infered request method
     *
     * @var $requestMethod
     *
     * @access protected
     */
    protected $requestMethod;

    /**
     * Class constructor
     *
     * @return void

     *
     * @access public
     */
    public function __construct()
    {
        parent::__construct();
        $this->deterimeRequestMethod();
        $this->route = Route::getRouteByPath(self::$uri_string, $this->requestMethod);
    }

    /**
     * Determines the actual request method
     *
     * @return void
     *
     * @access private
     */
    private function deterimeRequestMethod()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {

        $requestMethod = $_SERVER['REQUEST_METHOD'];
        $formMethod    = NULL;
        $validMethods  = Route::getHTTPVerbs();

        // FIXME: Solve ambiguity here! POST with _method="GET" makes no sense

        if (isset($_POST['_method']) && in_array(strtoupper($_POST['_method']), $validMethods, TRUE))
            $formMethod = strtoupper($_POST['_method']);

        if (is_null($formMethod))
        {
            $this->requestMethod = $requestMethod;
        }
        else
        {
            if ($requestMethod == 'POST')
                $this->requestMethod = $formMethod;

            if (!$this->CI->input->is_ajax_request() && $this->requestMethod == 'HEAD')

                $this->requestMethod = 'POST';
        }
    }

    /**
     * Entry point of the middleware
     *
     * @return void
     *
     * @access public
     */
    public function run()
    {
        if (!$this->route)
        {
            if (ENVIRONMENT != 'production')
                show_error('The request method '.$this->requestMethod.' is not allowed to view the resource', 403, 'Forbidden method');

            if(is_null(Route::get404()))
                show_404();

            if (Route::get404()->controller != get_class($this->CI))

                Route::trigger404();
        }
        else
        {
            if (method_exists($this->CI, $this->route->method))
            {
                $path_args  = Route::getRouteArgs($this->route, self::$uri_string);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $route_args = Route::compileRoute($this->route)->args;

                // Redirect to 404 if not enough parameters provided

                if(count($path_args) < count($route_args['required']))
                    redirect(Route::get404()->path);

                if(count($path_args) == 0)
                {
                    $this->CI->{$this->route->method}();
                }
                else
                {
                    call_user_func_array( [$this->CI, $this->route->method], array_values($path_args) );
                }

                // TODO: Add support to hooks in this execution thread

                $this->CI->output->_display();

                exit(0);

            }
            else
            {
                if (ENVIRONMENT != 'production')
                    show_error('The method '.$this->route->controller.'::'.$this->route->method.'() does not exists', 500, 'Method not found');

                if(is_null(Route::get404()))
                    show_404();

                if (Route::get404()->controller != get_class($this->CI))

                    Route::trigger404();
            }
        }
    }
}

1			<?php
2
3			/**
4			* Luthier Request middleware (internal)
5			*
6			* @author Anderson Salas <[email protected]>
7			* @copyright 2017
8			* @license GNU-3.0
9			*
10			*/
11
12			namespace Luthier\Middleware;
13
14			use Luthier\Core\Route as Route;
15
16			class Request extends \Luthier\Core\Middleware
17			{
18
19			/**
20			* Current (improved) route
21			*
22			* @var $route
23			*
24			* @access protected
25			*/
26			protected $route;
27
28			/**
29			* Infered request method
30			*
31			* @var $requestMethod
32			*
33			* @access protected
34			*/
35			protected $requestMethod;
36
37			/**
38			* Class constructor
39			*
40			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
41			*
42			* @access public
43			*/
44			public function __construct()
45			{
46			parent::__construct();
47			$this->deterimeRequestMethod();
48			$this->route = Route::getRouteByPath(self::$uri_string, $this->requestMethod);
49			}
50
51			/**
52			* Determines the actual request method
53			*
54			* @return void
55			*
56			* @access private
57			*/
58			private function deterimeRequestMethod()
			0 ignored issues – show Coding Style introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `deterimeRequestMethod` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `deterimeRequestMethod` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
59			{
60
61			$requestMethod = $_SERVER['REQUEST_METHOD'];
62			$formMethod = NULL;
63			$validMethods = Route::getHTTPVerbs();
64
65			// FIXME: Solve ambiguity here! POST with _method="GET" makes no sense
66
67			if (isset($_POST['_method']) && in_array(strtoupper($_POST['_method']), $validMethods, TRUE))
68			$formMethod = strtoupper($_POST['_method']);
69
70			if (is_null($formMethod))
71			{
72			$this->requestMethod = $requestMethod;
73			}
74			else
75			{
76			if ($requestMethod == 'POST')
77			$this->requestMethod = $formMethod;
78
79			if (!$this->CI->input->is_ajax_request() && $this->requestMethod == 'HEAD')
			0 ignored issues – show Bug introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `input` does not seem to exist in `Luthier\Core\Middleware`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
80			$this->requestMethod = 'POST';
81			}
82			}
83
84			/**
85			* Entry point of the middleware
86			*
87			* @return void
88			*
89			* @access public
90			*/
91			public function run()
92			{
93			if (!$this->route)
94			{
95			if (ENVIRONMENT != 'production')
96			show_error('The request method '.$this->requestMethod.' is not allowed to view the resource', 403, 'Forbidden method');
97
98			if(is_null(Route::get404()))
99			show_404();
100
101			if (Route::get404()->controller != get_class($this->CI))
			0 ignored issues – show Bug introduced 2017-02-13 06:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `controller` does not seem to exist. Did you mean `defaultController`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
102			Route::trigger404();
103			}
104			else
105			{
106			if (method_exists($this->CI, $this->route->method))
107			{
108			$path_args = Route::getRouteArgs($this->route, self::$uri_string);
			0 ignored issues – show Documentation introduced 2017-02-14 02:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this `self::$uri_string` is of type `object<Luthier\Core\Middleware>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
109			$route_args = Route::compileRoute($this->route)->args;
110
111			// Redirect to 404 if not enough parameters provided
112
113			if(count($path_args) < count($route_args['required']))
114			redirect(Route::get404()->path);
115
116			if(count($path_args) == 0)
117			{
118			$this->CI->{$this->route->method}();
119			}
120			else
121			{
122			call_user_func_array( [$this->CI, $this->route->method], array_values($path_args) );
123			}
124
125			// TODO: Add support to hooks in this execution thread
126
127			$this->CI->output->_display();
			0 ignored issues – show Bug introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `output` does not seem to exist in `Luthier\Core\Middleware`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
128			exit(0);
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-21 05:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `run()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
129			}
130			else
131			{
132			if (ENVIRONMENT != 'production')
133			show_error('The method '.$this->route->controller.'::'.$this->route->method.'() does not exists', 500, 'Method not found');
134
135			if(is_null(Route::get404()))
136			show_404();
137
138			if (Route::get404()->controller != get_class($this->CI))
			0 ignored issues – show Bug introduced 2017-05-21 20:02 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `controller` does not seem to exist. Did you mean `defaultController`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
139			Route::trigger404();
140			}
141			}
142			}
143			}

ingeniasoftware / luthier

Issues (45)

Security Analysis no vulnerabilities found

src/Middleware/Request.php (9 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like