RunSingle::execute() - Code Metrics - ingenerator/runsingle - Measure and Improve Code Quality continuously with Scrutinizer

RunSingle::execute() A
last analyzed 2019-04-03 14:21 UTC

↳ Parent: RunSingle

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	9.456
c	0
b	0
f	0
cc	3
nc	4
nop	4

<?php
/**
 * Wrapper script to run a command not more than once at a time across multiple instances.
 *
 * @author    Matthias Gisder <[email protected]>
 * @copyright 2014 inGenerator Ltd
 * @licence   BSD
 */

namespace Ingenerator\RunSingle;

use Psr\Log\LoggerInterface;

class RunSingle
{
    /**
     * @var string
     */
    protected $config_file = 'run_single_config.php';

    /**
     * @var \Ingenerator\RunSingle\LockDriver
     */
    protected $driver;

    /**
     * @var \Ingenerator\RunSingle\CommandRunner $runner
     */
    protected $runner;

    /**
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * @var LockHolder
     */
    protected $lock_holder;

    /**
     * @param LockDriver       $driver
     * @param CommandRunner    $runner
     * @param LoggerInterface  $logger
     * @param LockHolder $lock_holder
     */
    public function __construct(
        LockDriver $driver,
        CommandRunner $runner,
        LoggerInterface $logger,
        LockHolder $lock_holder
    ) {
        $this->driver      = $driver;
        $this->runner      = $runner;
        $this->logger      = $logger;
        $this->lock_holder = $lock_holder;
//        //print_r($lock_holder->get_lock_holder(), 1);
//        echo $lock_holder->get_lock_holder();
    }

    /**
     * @param string $task_name
     * @param string $command
     * @param string $timeout
     * @param string $garbage_collect
     *
     * @return integer

     */
    public function execute($task_name, $command, $timeout, $garbage_collect)
    {
        if ($garbage_collect === TRUE) {
            $this->logger->info('garbage collecting for task '.$task_name);
            $this->driver->garbage_collect($task_name);
        }

        $this->logger->info('lock_holder id is '.$this->lock_holder->get_lock_holder());
        $this->logger->info('trying to get lock for task '.$task_name);
        $lock_id = $this->driver->get_lock($task_name, $timeout, $this->lock_holder->get_lock_holder());
        if ($lock_id !== FALSE) {
            $this->logger->info('executing task '.$task_name.' ...');
            $this->logger->info('<command output>');

            $start_time = \time();
            $exit_code  = $this->runner->execute($command);
            $end_time   = \time();

            $elapsed_time = $end_time - $start_time;
            $this->logger->info('</command output>');
            $this->logger->info('finished '.$task_name.' after '.$elapsed_time.' seconds with exit code '.$exit_code);

            $this->driver->release_lock($task_name, $lock_id);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return $exit_code;
        }

        $this->logger->info('no lock available for '.$task_name);
        return 0;
    }

}


1			<?php
2			/**
3			* Wrapper script to run a command not more than once at a time across multiple instances.
4			*
5			* @author Matthias Gisder <[email protected]>
6			* @copyright 2014 inGenerator Ltd
7			* @licence BSD
8			*/
9
10			namespace Ingenerator\RunSingle;
11
12			use Psr\Log\LoggerInterface;
13
14			class RunSingle
15			{
16			/**
17			* @var string
18			*/
19			protected $config_file = 'run_single_config.php';
20
21			/**
22			* @var \Ingenerator\RunSingle\LockDriver
23			*/
24			protected $driver;
25
26			/**
27			* @var \Ingenerator\RunSingle\CommandRunner $runner
28			*/
29			protected $runner;
30
31			/**
32			* @var LoggerInterface
33			*/
34			protected $logger;
35
36			/**
37			* @var LockHolder
38			*/
39			protected $lock_holder;
40
41			/**
42			* @param LockDriver $driver
43			* @param CommandRunner $runner
44			* @param LoggerInterface $logger
45			* @param LockHolder $lock_holder
46			*/
47			public function __construct(
48			LockDriver $driver,
49			CommandRunner $runner,
50			LoggerInterface $logger,
51			LockHolder $lock_holder
52			) {
53			$this->driver = $driver;
54			$this->runner = $runner;
55			$this->logger = $logger;
56			$this->lock_holder = $lock_holder;
57			// //print_r($lock_holder->get_lock_holder(), 1);
58			// echo $lock_holder->get_lock_holder();
59			}
60
61			/**
62			* @param string $task_name
63			* @param string $command
64			* @param string $timeout
65			* @param string $garbage_collect
66			*
67			* @return integer
			0 ignored issues – show Documentation introduced 2018-02-09 11:23 UTC by Report Bug Copy Issue Report Should the return type not be `integer\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
68			*/
69			public function execute($task_name, $command, $timeout, $garbage_collect)
70			{
71			if ($garbage_collect === TRUE) {
72			$this->logger->info('garbage collecting for task '.$task_name);
73			$this->driver->garbage_collect($task_name);
74			}
75
76			$this->logger->info('lock_holder id is '.$this->lock_holder->get_lock_holder());
77			$this->logger->info('trying to get lock for task '.$task_name);
78			$lock_id = $this->driver->get_lock($task_name, $timeout, $this->lock_holder->get_lock_holder());
79			if ($lock_id !== FALSE) {
80			$this->logger->info('executing task '.$task_name.' ...');
81			$this->logger->info('<command output>');
82
83			$start_time = \time();
84			$exit_code = $this->runner->execute($command);
85			$end_time = \time();
86
87			$elapsed_time = $end_time - $start_time;
88			$this->logger->info('</command output>');
89			$this->logger->info('finished '.$task_name.' after '.$elapsed_time.' seconds with exit code '.$exit_code);
90
91			$this->driver->release_lock($task_name, $lock_id);
			0 ignored issues – show Bug introduced 2018-02-09 11:23 UTC by Report Bug Copy Issue Report It seems like `$lock_id` defined by `$this->driver->get_lock(...der->get_lock_holder())` on line `78` can also be of type `boolean`; however, `Ingenerator\RunSingle\LockDriver::release_lock()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
92			return $exit_code;
93			}
94
95			$this->logger->info('no lock available for '.$task_name);
96			return 0;
97			}
98
99			}
100

ingenerator / runsingle

RunSingle::execute() A last analyzed 2019-04-03 14:21 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

RunSingle::execute() A
last analyzed 2019-04-03 14:21 UTC