Infinitypaul\NairaExchangeRates\Traits\DateTraits

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getDateFrom()	0	4	1
A	getDateTo()	0	4	1
A	addDateFrom()	0	11	2
A	addDateTo()	0	11	2
A	validateDateFormat()	0	8	2

<?php

namespace Infinitypaul\NairaExchangeRates\Traits;

use Infinitypaul\NairaExchangeRates\Exceptions\Exceptions;

trait DateTraits
{
    // Regular Expression for the date:
    private $dateRegExp = '/^[0-9]{4}-(0[1-9]|1[0-2])-(0[1-9]|[1-2][0-9]|3[0-1])$/';

    // Date from which to request historic rates:
    private $dateFrom;

    // Date to which to request historic rates:
    private $dateTo;

    // Get the "from" date:
    public function getDateFrom()
    {
        return $this->dateFrom;
    }

    // Get the "to" date:
    public function getDateTo()
    {
        return $this->dateTo;
    }

    // Add a date-from:
    public function addDateFrom(string $from)
    {
        if ($this->validateDateFormat($from)) {

The expression $this->validateDateFormat($from) of type integer|false is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $this->dateFrom = $from;

            // Return object to preserve method-chaining:
            return $this;
        }

        throw Exceptions::create('format.invalid_date');
    }

    // Add a date-to:
    public function addDateTo(string $to)
    {
        if ($this->validateDateFormat($to)) {

The expression $this->validateDateFormat($to) of type integer|false is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $this->dateTo = $to;

            // Return object to preserve method-chaining:
            return $this;
        }

        throw Exceptions::create('format.invalid_date');
    }

    // Validate a date is in the correct format:
    private function validateDateFormat(string $date = null)
    {
        if (! is_null($date)) {
            return preg_match($this->dateRegExp, $date);
        }

        return false;
    }
}