Issues in Builder.php - Fixed Issues - Inspection of "Add travis, scrutinizer, tests, documentation" - indragunawan/rest-service - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( aa1927...26941e )

by Indra

created 2016-08-13 18:43 UTC

Builder.php (15 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace IndraGunawan\RestService;

use GuzzleHttp;
use GuzzleHttp\Command\CommandInterface;
use GuzzleHttp\Exception\BadResponseException as GuzzleBadResponseException;
use GuzzleHttp\Psr7\Request;
use IndraGunawan\RestService\Exception\BadResponseException;
use IndraGunawan\RestService\Exception\CommandException;
use IndraGunawan\RestService\Exception\ValidatorException;
use IndraGunawan\RestService\Validator\Validator;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

class Builder
{
    /**
     * @var ServiceInterface
     */
    private $service;

    /**
     * @param ServiceInterface $service
     */
    public function __construct(ServiceInterface $service)
    {
        $this->service = $service;
    }

    /**
     * Transform command to request.
     *
     * @return Request
     */
    public function commandToRequestTransformer()
    {
        return function (CommandInterface $command) {
            if (!$this->service->hasOperation($command->getName())) {
                throw new CommandException(sprintf(

                    'Command "%s" not found',
                    $command->getName()
                ));
            }

            $operation = $this->service->getOperation($command->getName());

            $result = $this->transformData($command, $command->toArray(), $operation, 'request');

            $uri = ltrim($operation['requestUri'], '/');
            if ($result['uri']) {
                // replace uri
                $patterns = [];
                $replacements = [];
                foreach ($result['uri'] as $key => $value) {
                    $patterns[] = '/{'.$key.'}/';
                    $replacements[] = $value;
                }

                $uri = preg_replace($patterns, $replacements, $uri);
            }

            $body = null;
            if ('rest_json' === $operation['requestProtocol']) {
                $body = GuzzleHttp\json_encode($result['body']);
                $result['header']['Content-Type'] = 'application/json';
            } elseif ('form_params' === $operation['requestProtocol']) {
                $body = http_build_query($result['body'], '', '&');
                $result['header']['Content-Type'] = 'application/x-www-form-urlencoded';
            }

            if ($result['query']) {
                $uri .= sprintf('?%s', http_build_query($result['query'], null, '&', PHP_QUERY_RFC3986));
            }

            return new Request(
                $operation['httpMethod'],
                $this->service->getEndpoint().$uri,
                $result['header'],
                $body
            );
        };
    }

    /**
     * Transform response to result.
     *
     * @return Result
     */
    public function responseToResultTransformer()
    {
        return function (
            ResponseInterface $response,
            RequestInterface $request,
            CommandInterface $command
        ) {
            $operation = $this->service->getOperation($command->getName());
            $this->processResponseError($operation, $request, $response);

            $body = [];
            if ('rest_json' === $operation['responseProtocol']) {
                $body = GuzzleHttp\json_decode($response->getBody(), true);
            }

            $result = $this->transformData($command, $body, $operation, 'response');

            foreach ($response->getHeaders() as $name => $header) {
                $result['header'][$name] = is_array($header) ? array_pop($header) : null;
            }

            return new Result($result['body'], $result['header']);
        };
    }

    public function badResponseExceptionParser()
    {
        return function (CommandInterface $command, GuzzleBadResponseException $e) {
            $operation = $this->service->getOperation($command->getName());

            return $this->processResponseError(
                $operation,
                $e->getRequest(),
                $e->getResponse(),
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
                $e
            );
        };
    }

    /**
     * Process response to check is error or not.
     *
     * @param array                           $operation
     * @param RequestInterface                $request
     * @param ResponseInterface               $response
     * @param GuzzleBadResponseException|null $e
     *
     * @return BadResponseException|null
     */
    private function processResponseError(
        array $operation,
        RequestInterface $request,
        ResponseInterface $response,
        GuzzleBadResponseException $e = null
    ) {
        $body = null;
        if ('rest_json' === $operation['responseProtocol']) {
            try {
                $body = GuzzleHttp\json_decode($response->getBody(), true);
            } catch (\InvalidArgumentException $ex) {
                return new BadResponseException(
                    '',
                    $ex->getMessage(),
                    ($e ? $e->getMessage() : ''),
                    $request,
                    $response,
                    $e ? $e->getPrevious() : null
                );
            }
        }

        $responseCode = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $responseMessage = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($body) {
            foreach ($operation['errors'] as $name => $error) {
                if ('field' === $error['type']) {
                    $responseCode = $this->parseError($body, $error['codeField']);

                    if (!$responseCode) {
                        continue;
                    }

                    // if no ifCode property then return exception
                    if (!$error['ifCode']) {

                        $responseMessage = $this->getErrorMessage($body, $error, $response);

                        return new BadResponseException(
                            $responseCode,
                            $responseMessage,
                            ($e ? $e->getMessage() : '').' code: '.$responseCode.', message: '.$responseMessage,
                            $request,
                            $response,
                            $e ? $e->getPrevious() : null
                        );
                    }
                } else {
                    $responseCode = $response->getStatusCode();
                }

                if ($error['ifCode'] == $responseCode) {

                    $responseMessage = $this->getErrorMessage($body, $error, $response);

                    return new BadResponseException(
                        $responseCode,
                        $responseMessage,
                        ($e ? $e->getMessage() : '').' code: '.$responseCode.', message: '.$responseMessage,
                        $request,
                        $response,
                        $e ? $e->getPrevious() : null
                    );
                }
            }
        }

        return;
    }

    /**
     * Parse error codeField from body.
     *
     * @param array  $body
     * @param string $path
     *
     * @return string|null
     */
    private function parseError(array $body, $path)
    {
        $tmp = $body;
        foreach (explode('.', $path) as $key) {
            if (!isset($tmp[$key])) {
                return;
            }

            $tmp = $tmp[$key];
        }

        return $tmp;
    }

    /**
     * Get error message from posible field.
     *
     * @param array             $body
     * @param array             $error
     * @param ResponseInterface $response
     *
     * @return string
     */
    private function getErrorMessage(array $body, array $error, ResponseInterface $response)
    {
        $message = $this->parseError($body, $error['messageField']);
        if (!$message) {
            $message = $error['defaultMessage'];
        }
        if (!$message && $response->getStatusCode() >= 400) {
            $message = $response->getReasonPhrase();
        }

        return $message;
    }

    /**
     * Transform and match data with shape.
     *
     * @param CommandInterface $command
     * @param array            $datas
     * @param array            $operation
     * @param string           $action
     *
     * @return array
     */
    private function transformData(CommandInterface $command, array $datas, array $operation, $action)
    {
        $result = [
            'header' => [],
            'uri' => [],
            'query' => [],
            'body' => [],
        ];

        $validator = new Validator();

        $shape = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        if (isset($operation[$action])) {
            $shape = $operation[$action];
        } else {
            $shape = [
                'type' => null,
                'members' => [],
            ];
        }

        $result['body'] = $this->createData(
            $validator,
            $datas,
            $shape,
            $command->getName(),
            $action,
            $result
        );

        if (!$validator->validate([$command->getName() => $datas])) {
            // validation failed
            throw $validator->createValidatorException();
        }

        return $result;
    }

    /**
     * Create request/response data and add validation rule.
     *
     * @param Validator $validator
     * @param array     $datas
     * @param array     $shape
     * @param string    $path
     * @param string    $action
     * @param array     &$result
     *
     * @return array
     */
    private function createData(
        Validator $validator,
        array $datas,
        array $shape,
        $path,
        $action,
        array &$result
    ) {
        $bodyResult = [];
        if ('list' === $shape['type']) {
            $path .= '[*]';
        }

        foreach ($shape['members'] as $name => $parameter) {
            $tmpPath = $path.'['.$name.']';
            $value = isset($datas[$name]) ? $datas[$name] : null;
            // set validator
            $validator->add($tmpPath, $parameter, $value);

            // if nested children
            if (isset($parameter['members']) && count($parameter['members']) > 0) {
                if (!is_null($value) && !is_array($value)) {
                    throw new ValidatorException($tmpPath, sprintf(
                        'Expected "%s", but got "%s"',
                        $parameter['type'],
                        gettype($value)
                    ));
                }
                if ('list' === $parameter['type']) {
                    $children = $value ?: [];
                    foreach ($children as $idx => $child) {

                        if (!is_array($child)) {
                            throw new ValidatorException($tmpPath, 'Expected "list", but got "map"');
                        }

                        $bodyResult[$parameter['locationName']][] = $this->createData($validator, $child, $parameter, $tmpPath, $action, $result);
                    }
                } elseif ('map' === $parameter['type']) {
                    if (is_null($value)) {
                        continue;
                    }
                    $children = $value ?: [];
                    foreach (array_keys($parameter['members']) as $key) {
                        if (!array_key_exists($key, $children)) {
                            $children[$key] = null;
                        }
                    }

                    foreach ($children as $parameterName => $child) {

                        if (is_array($child)) {
                            $bodyResult[$parameter['locationName']][$parameterName] = $this->createData(
                                $validator,
                                $child,
                                $parameter,
                                $tmpPath,
                                $action,
                                $result
                            );
                        }
                    }
                    $bodyResult[$parameter['locationName']] = $this->createData(
                        $validator,
                        $children,
                        $parameter,
                        $tmpPath,
                        $action,
                        $result
                    );
                }
            }

            $value = $this->getFormatedValue($value, $parameter, $action);
            if ('body' !== $parameter['location']) {
                $result[$parameter['location']][$parameter['locationName']] = $value;
            } else {
                if (!array_key_exists($parameter['locationName'], $bodyResult)) {
                    $bodyResult[$parameter['locationName']] = $value;
                }
            }
            unset($datas[$name]);
        }

        if (count($datas) > 0) {
            foreach ($datas as $name => $child) {
                $bodyResult[$name] = $child;
            }
        }

        return $bodyResult;
    }

    /**
     * Get formatted value.
     *
     * @param mixed  $value     [description]
     * @param array  $parameter [description]
     * @param string $action    request/response
     *
     * @return mixed
     */
    private function getFormatedValue($value, array $parameter, $action)
    {
        if (!$value) {
            $value = $parameter['defaultValue'];
        }

        switch ($parameter['type']) {
            case 'integer':
                return (int) (string) $value;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'float':
                return (float) (string) $value;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'string':
                $result = (string) $value;

                return sprintf($parameter['format'] ?: '%s', $result);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'boolean':
                return ($value === 'true' || true === $value) ? true : false;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'number':
                if ($parameter['format']) {
                    $format = explode('|', $parameter['format']);
                    $decimal = isset($format[0]) ? $format[0] : 0;
                    $decimalPoint = isset($format[1]) ? $format[1] : '.';
                    $thousandsSeparator = isset($format[2]) ? $format[2] : ',';

                    return number_format((float) (string) $value, $decimal, $decimalPoint, $thousandsSeparator);
                }

                return (string) $value;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'datetime':
                if ('request' === $action) {
                    if (!$value) {
                        return;
                    }

                    if (!($value instanceof \DateTime)) {
                        $value = new \DateTime($value);
                    }

                    if ($parameter['format']) {
                        return $value->format($parameter['format']);
                    }

                    return $value->format('Y-m-d\TH:i:s\Z');
                } elseif ('response' === $action) {
                    if ($parameter['format']) {
                        return \DateTime::createFromFormat($parameter['format'], $value);
                    } else {
                        return new \DateTime($value);
                    }
                }
                break;
            default:
                return;
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }
}


1		<?php
2
3		namespace IndraGunawan\RestService;
4
5		use GuzzleHttp;
6		use GuzzleHttp\Command\CommandInterface;
7		use GuzzleHttp\Exception\BadResponseException as GuzzleBadResponseException;
8		use GuzzleHttp\Psr7\Request;
9		use IndraGunawan\RestService\Exception\BadResponseException;
10		use IndraGunawan\RestService\Exception\CommandException;
11		use IndraGunawan\RestService\Exception\ValidatorException;
12		use IndraGunawan\RestService\Validator\Validator;
13		use Psr\Http\Message\RequestInterface;
14		use Psr\Http\Message\ResponseInterface;
15
16		class Builder
17		{
18		/**
19		* @var ServiceInterface
20		*/
21		private $service;
22
23		/**
24		* @param ServiceInterface $service
25		*/
26		public function __construct(ServiceInterface $service)
27		{
28		$this->service = $service;
29		}
30
31		/**
32		* Transform command to request.
33		*
34		* @return Request
35		*/
36		public function commandToRequestTransformer()
37		{
38		return function (CommandInterface $command) {
39		if (!$this->service->hasOperation($command->getName())) {
40		throw new CommandException(sprintf(
		0 ignored issues – show Bug introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this The call to `CommandException::__construct()` misses a required argument `$command`. This check looks for function calls that miss required arguments. Loading history...
41		'Command "%s" not found',
42		$command->getName()
43		));
44		}
45
46		$operation = $this->service->getOperation($command->getName());
47
48		$result = $this->transformData($command, $command->toArray(), $operation, 'request');
49
50		$uri = ltrim($operation['requestUri'], '/');
51		if ($result['uri']) {
52		// replace uri
53		$patterns = [];
54		$replacements = [];
55		foreach ($result['uri'] as $key => $value) {
56		$patterns[] = '/{'.$key.'}/';
57		$replacements[] = $value;
58		}
59
60		$uri = preg_replace($patterns, $replacements, $uri);
61		}
62
63		$body = null;
64		if ('rest_json' === $operation['requestProtocol']) {
65		$body = GuzzleHttp\json_encode($result['body']);
66		$result['header']['Content-Type'] = 'application/json';
67		} elseif ('form_params' === $operation['requestProtocol']) {
68		$body = http_build_query($result['body'], '', '&');
69		$result['header']['Content-Type'] = 'application/x-www-form-urlencoded';
70		}
71
72		if ($result['query']) {
73		$uri .= sprintf('?%s', http_build_query($result['query'], null, '&', PHP_QUERY_RFC3986));
74		}
75
76		return new Request(
77		$operation['httpMethod'],
78		$this->service->getEndpoint().$uri,
79		$result['header'],
80		$body
81		);
82		};
83		}
84
85		/**
86		* Transform response to result.
87		*
88		* @return Result
89		*/
90		public function responseToResultTransformer()
91		{
92		return function (
93		ResponseInterface $response,
94		RequestInterface $request,
95		CommandInterface $command
96		) {
97		$operation = $this->service->getOperation($command->getName());
98		$this->processResponseError($operation, $request, $response);
99
100		$body = [];
101		if ('rest_json' === $operation['responseProtocol']) {
102		$body = GuzzleHttp\json_decode($response->getBody(), true);
103		}
104
105		$result = $this->transformData($command, $body, $operation, 'response');
106
107		foreach ($response->getHeaders() as $name => $header) {
108		$result['header'][$name] = is_array($header) ? array_pop($header) : null;
109		}
110
111		return new Result($result['body'], $result['header']);
112		};
113		}
114
115		public function badResponseExceptionParser()
116		{
117		return function (CommandInterface $command, GuzzleBadResponseException $e) {
118		$operation = $this->service->getOperation($command->getName());
119
120		return $this->processResponseError(
121		$operation,
122		$e->getRequest(),
123		$e->getResponse(),
		0 ignored issues – show Bug introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$e->getResponse()` can be `null`; however, `processResponseError()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
124		$e
125		);
126		};
127		}
128
129		/**
130		* Process response to check is error or not.
131		*
132		* @param array $operation
133		* @param RequestInterface $request
134		* @param ResponseInterface $response
135		* @param GuzzleBadResponseException\|null $e
136		*
137		* @return BadResponseException\|null
138		*/
139		private function processResponseError(
140		array $operation,
141		RequestInterface $request,
142		ResponseInterface $response,
143		GuzzleBadResponseException $e = null
144		) {
145		$body = null;
146		if ('rest_json' === $operation['responseProtocol']) {
147		try {
148		$body = GuzzleHttp\json_decode($response->getBody(), true);
149		} catch (\InvalidArgumentException $ex) {
150		return new BadResponseException(
151		'',
152		$ex->getMessage(),
153		($e ? $e->getMessage() : ''),
154		$request,
155		$response,
156		$e ? $e->getPrevious() : null
157		);
158		}
159		}
160
161		$responseCode = 0;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$responseCode` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
162		$responseMessage = '';
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$responseMessage` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
163
164		if ($body) {
165		foreach ($operation['errors'] as $name => $error) {
166		if ('field' === $error['type']) {
167		$responseCode = $this->parseError($body, $error['codeField']);
168
169		if (!$responseCode) {
170		continue;
171		}
172
173		// if no ifCode property then return exception
174	View Code Duplication	if (!$error['ifCode']) {
		0 ignored issues – show Duplication introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
175		$responseMessage = $this->getErrorMessage($body, $error, $response);
176
177		return new BadResponseException(
178		$responseCode,
179		$responseMessage,
180		($e ? $e->getMessage() : '').' code: '.$responseCode.', message: '.$responseMessage,
181		$request,
182		$response,
183		$e ? $e->getPrevious() : null
184		);
185		}
186		} else {
187		$responseCode = $response->getStatusCode();
188		}
189
190	View Code Duplication	if ($error['ifCode'] == $responseCode) {
		0 ignored issues – show Duplication introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
191		$responseMessage = $this->getErrorMessage($body, $error, $response);
192
193		return new BadResponseException(
194		$responseCode,
195		$responseMessage,
196		($e ? $e->getMessage() : '').' code: '.$responseCode.', message: '.$responseMessage,
197		$request,
198		$response,
199		$e ? $e->getPrevious() : null
200		);
201		}
202		}
203		}
204
205		return;
206		}
207
208		/**
209		* Parse error codeField from body.
210		*
211		* @param array $body
212		* @param string $path
213		*
214		* @return string\|null
215		*/
216		private function parseError(array $body, $path)
217		{
218		$tmp = $body;
219		foreach (explode('.', $path) as $key) {
220		if (!isset($tmp[$key])) {
221		return;
222		}
223
224		$tmp = $tmp[$key];
225		}
226
227		return $tmp;
228		}
229
230		/**
231		* Get error message from posible field.
232		*
233		* @param array $body
234		* @param array $error
235		* @param ResponseInterface $response
236		*
237		* @return string
238		*/
239		private function getErrorMessage(array $body, array $error, ResponseInterface $response)
240		{
241		$message = $this->parseError($body, $error['messageField']);
242		if (!$message) {
243		$message = $error['defaultMessage'];
244		}
245		if (!$message && $response->getStatusCode() >= 400) {
246		$message = $response->getReasonPhrase();
247		}
248
249		return $message;
250		}
251
252		/**
253		* Transform and match data with shape.
254		*
255		* @param CommandInterface $command
256		* @param array $datas
257		* @param array $operation
258		* @param string $action
259		*
260		* @return array
261		*/
262		private function transformData(CommandInterface $command, array $datas, array $operation, $action)
263		{
264		$result = [
265		'header' => [],
266		'uri' => [],
267		'query' => [],
268		'body' => [],
269		];
270
271		$validator = new Validator();
272
273		$shape = [];
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$shape` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
274		if (isset($operation[$action])) {
275		$shape = $operation[$action];
276		} else {
277		$shape = [
278		'type' => null,
279		'members' => [],
280		];
281		}
282
283		$result['body'] = $this->createData(
284		$validator,
285		$datas,
286		$shape,
287		$command->getName(),
288		$action,
289		$result
290		);
291
292		if (!$validator->validate([$command->getName() => $datas])) {
293		// validation failed
294		throw $validator->createValidatorException();
295		}
296
297		return $result;
298		}
299
300		/**
301		* Create request/response data and add validation rule.
302		*
303		* @param Validator $validator
304		* @param array $datas
305		* @param array $shape
306		* @param string $path
307		* @param string $action
308		* @param array &$result
309		*
310		* @return array
311		*/
312		private function createData(
313		Validator $validator,
314		array $datas,
315		array $shape,
316		$path,
317		$action,
318		array &$result
319		) {
320		$bodyResult = [];
321		if ('list' === $shape['type']) {
322		$path .= '[*]';
323		}
324
325		foreach ($shape['members'] as $name => $parameter) {
326		$tmpPath = $path.'['.$name.']';
327		$value = isset($datas[$name]) ? $datas[$name] : null;
328		// set validator
329		$validator->add($tmpPath, $parameter, $value);
330
331		// if nested children
332		if (isset($parameter['members']) && count($parameter['members']) > 0) {
333		if (!is_null($value) && !is_array($value)) {
334		throw new ValidatorException($tmpPath, sprintf(
335		'Expected "%s", but got "%s"',
336		$parameter['type'],
337		gettype($value)
338		));
339		}
340		if ('list' === $parameter['type']) {
341		$children = $value ?: [];
342	View Code Duplication	foreach ($children as $idx => $child) {
		0 ignored issues – show Duplication introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
343		if (!is_array($child)) {
344		throw new ValidatorException($tmpPath, 'Expected "list", but got "map"');
345		}
346
347		$bodyResult[$parameter['locationName']][] = $this->createData($validator, $child, $parameter, $tmpPath, $action, $result);
348		}
349		} elseif ('map' === $parameter['type']) {
350		if (is_null($value)) {
351		continue;
352		}
353		$children = $value ?: [];
354		foreach (array_keys($parameter['members']) as $key) {
355		if (!array_key_exists($key, $children)) {
356		$children[$key] = null;
357		}
358		}
359
360	View Code Duplication	foreach ($children as $parameterName => $child) {
		0 ignored issues – show Duplication introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
361		if (is_array($child)) {
362		$bodyResult[$parameter['locationName']][$parameterName] = $this->createData(
363		$validator,
364		$child,
365		$parameter,
366		$tmpPath,
367		$action,
368		$result
369		);
370		}
371		}
372		$bodyResult[$parameter['locationName']] = $this->createData(
373		$validator,
374		$children,
375		$parameter,
376		$tmpPath,
377		$action,
378		$result
379		);
380		}
381		}
382
383		$value = $this->getFormatedValue($value, $parameter, $action);
384		if ('body' !== $parameter['location']) {
385		$result[$parameter['location']][$parameter['locationName']] = $value;
386		} else {
387		if (!array_key_exists($parameter['locationName'], $bodyResult)) {
388		$bodyResult[$parameter['locationName']] = $value;
389		}
390		}
391		unset($datas[$name]);
392		}
393
394		if (count($datas) > 0) {
395		foreach ($datas as $name => $child) {
396		$bodyResult[$name] = $child;
397		}
398		}
399
400		return $bodyResult;
401		}
402
403		/**
404		* Get formatted value.
405		*
406		* @param mixed $value [description]
407		* @param array $parameter [description]
408		* @param string $action request/response
409		*
410		* @return mixed
411		*/
412		private function getFormatedValue($value, array $parameter, $action)
413		{
414		if (!$value) {
415		$value = $parameter['defaultValue'];
416		}
417
418		switch ($parameter['type']) {
419		case 'integer':
420		return (int) (string) $value;
421		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
422		case 'float':
423		return (float) (string) $value;
424		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
425		case 'string':
426		$result = (string) $value;
427
428		return sprintf($parameter['format'] ?: '%s', $result);
429		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
430		case 'boolean':
431		return ($value === 'true' \|\| true === $value) ? true : false;
432		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
433		case 'number':
434		if ($parameter['format']) {
435		$format = explode('\|', $parameter['format']);
436		$decimal = isset($format[0]) ? $format[0] : 0;
437		$decimalPoint = isset($format[1]) ? $format[1] : '.';
438		$thousandsSeparator = isset($format[2]) ? $format[2] : ',';
439
440		return number_format((float) (string) $value, $decimal, $decimalPoint, $thousandsSeparator);
441		}
442
443		return (string) $value;
444		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
445		case 'datetime':
446		if ('request' === $action) {
447		if (!$value) {
448		return;
449		}
450
451		if (!($value instanceof \DateTime)) {
452		$value = new \DateTime($value);
453		}
454
455		if ($parameter['format']) {
456		return $value->format($parameter['format']);
457		}
458
459		return $value->format('Y-m-d\TH:i:s\Z');
460		} elseif ('response' === $action) {
461		if ($parameter['format']) {
462		return \DateTime::createFromFormat($parameter['format'], $value);
463		} else {
464		return new \DateTime($value);
465		}
466		}
467		break;
468		default:
469		return;
470		break;
		0 ignored issues – show Unused Code introduced 2016-08-12 17:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
471		}
472		}
473		}
474

indragunawan / rest-service

Push — master ( aa1927...26941e )

Builder.php (15 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like