Indigo\Iterator\LazyAppendIterator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	current()	0	6	1
A	key()	0	6	1
A	next()	0	6	1
A	rewind()	0	6	1
A	valid()	0	6	1
A	lazyAppend()	0	7	3

<?php

namespace Indigo\Iterator;

/**
 * This is an extension of the SPL AppendIterator.
 *
 * Lazily append iterators from a traversable object.
 * Useful when moving to the next element invokes an expensive resolver logic.
 *
 * @author Márk Sági-Kazár <mark.sagikazar@gmail.com>
 */
class LazyAppendIterator extends \AppendIterator
{
    /**
     * @var \Iterator
     */
    private $iterators;

    /**
     * @param \Iterator $iterators
     */
    public function __construct(\Iterator $iterators)
    {
        parent::__construct();

        $this->iterators = $iterators;

        $iterators->rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function current()
    {
        $this->lazyAppend();

        return parent::current();
    }

    /**
     * {@inheritdoc}
     */
    public function key()
    {
        $this->lazyAppend();

        return parent::key();
    }

    /**
     * {@inheritdoc}
     */
    public function next()
    {
        $this->lazyAppend();

        parent::next();
    }

    /**
     * {@inheritdoc}
     */
    public function rewind()
    {
        $this->lazyAppend();

        return parent::rewind();
    }

    /**
     * {@inheritdoc}
     */
    public function valid()
    {
        $this->lazyAppend();

        return parent::valid();
    }

    /**
     * Lazily append the next iterator to the chain
     */
    private function lazyAppend()
    {
        if (!parent::valid() and $this->iterators->valid()) {

It seems like you call parent on a different method (valid() instead of lazyAppend()). Are you sure this is correct? If so, you might want to change this to $this->valid().

Using logical operators such as and instead of && is generally not recommended.

            $this->append($this->iterators->current());
            $this->iterators->next();
        }
    }
}