Issues in AccountController.php (master) - Issues in master - inblank/yii2-activeuser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (102)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/AccountController.php (20 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace inblank\activeuser\controllers;

use inblank\activeuser\models\forms\ChangePasswordForm;
use inblank\activeuser\models\forms\LoginForm;
use inblank\activeuser\models\forms\RegisterForm;
use inblank\activeuser\models\forms\ResendForm;
use inblank\activeuser\models\forms\RestoreForm;
use inblank\activeuser\traits\CommonTrait;
use yii;
use yii\filters\AccessControl;
use yii\web\Controller;

class AccountController extends Controller
{

    use CommonTrait;

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        $authorizedUserAction = ['index', 'update', 'change-password', 'logout'];
        return [
            'access' => [
                'class' => AccessControl::className(),

                'except' => ['confirm', 'view'],
                'rules' => [
                    [
                        'allow' => true,
                        'actions' => ['register', 'login', 'resend', 'restore'],
                        'roles' => ['?'],
                    ],
                    [
                        'allow' => true,
                        'actions' => $authorizedUserAction,
                        'roles' => ['@'],
                    ],
                ],
                'denyCallback' => function ($rule, $action) use ($authorizedUserAction) {
                    return in_array($action->id, $authorizedUserAction) ?
                        $action->controller->redirect(['login']) :
                        $action->controller->redirect(['index']);
                },
            ],
        ];
    }

    /**
     * General user cabinet page
     */
    public function actionIndex()
    {
        $user = $this->findModel(Yii::$app->user->id);
        return $this->render('index', [
            'user' => $user
        ]);
    }

    /**
     * User registering action
     */
    public function actionRegister()
    {
        if (!$this->module->isRegistrationEnabled()) {
            return $this->render('registerDisable');
        }
        $flashMessageId = 'activeuser_register';

        $email = Yii::$app->session->getFlash($flashMessageId);
        if (!empty($email)) {

            return $this->render('registerAfter', [
                'user' => Yii::createObject(self::di('User'))->findOne(['email' => $email]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ]);
        }
        /** @var RegisterForm $model */
        $model = Yii::createObject(RegisterForm::className());

        if ($model->load(Yii::$app->getRequest()->post()) && $model->register()) {

            // congratulation and instruction
            Yii::$app->session->setFlash($flashMessageId, $model->email);
            return $this->redirect(['/activeuser/account/register']);
        }
        return $this->render('register', [
            'model' => $model,
        ]);
    }

    /**
     * User login action
     */
    public function actionLogin()
    {
        // TODO filter too many login request
        /** @var LoginForm $model */
        $model = Yii::createObject(LoginForm::className());

        if ($model->load(Yii::$app->getRequest()->post()) && $model->login()) {
            return $this->goBack();
        }
        return $this->render('login', [
            'model' => $model,
        ]);
    }

    /**
     * User logout action
     */
    public function actionLogout()
    {
        Yii::$app->user->logout();
        return $this->redirect('/');
    }

    /**
     * Request password change
     * @return string|yii\web\Response
     * @throws yii\base\InvalidConfigException
     * @throws yii\web\NotFoundHttpException
     */
    public function actionRestore()
    {
        // TODO filter too many restore request and set in Module period for restore
        if (!$this->getModule()->enablePasswordRestore) {
            throw new yii\web\NotFoundHttpException();
        }
        $flashMessageId = 'activeuser_restore_sent';
        $email = Yii::$app->session->getFlash($flashMessageId);
        if ($email !== null) {
            // message with instructions sent
            return $this->render('restoreSent', [
                'email' => $email,
            ]);
        }

        /** @var RestoreForm $model */
        $model = Yii::createObject(RestoreForm::className());

        $model->setScenario($model::SCENARIO_EMAIL);
        if ($model->load(Yii::$app->getRequest()->post()) && $model->restore()) {

            Yii::$app->session->setFlash($flashMessageId, $model->email);
            return $this->redirect(['/activeuser/account/restore']);
        }
        $error = Yii::$app->session->getFlash('activeuser_error');
        if (!empty($error) && !empty($error['token'])) {
            $error = $error['token'][0];
        } else {
            $error = null;
        }
        return $this->render('restore', [
            'model' => $model,
            'error' => $error,
        ]);
    }

    /**
     * Change user password
     * @param string $token user token for restore
     * @return string|yii\web\Response
     * @throws yii\base\InvalidConfigException
     * @throws yii\web\NotFoundHttpException
     */
    public function actionPassword($token = null)
    {
        $flashMessageId = 'activeuser_restore';

        $email = Yii::$app->session->getFlash($flashMessageId);
        if (!empty($email)) {

            // congratulation message
            return $this->render('restoreComplete', [
                'user' => Yii::createObject(self::di('User'))->findOne(['email' => $email]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ]);
        }

        /** @var \inblank\activeuser\models\User $user */
        if (!$this->getModule()->enablePasswordRestore || $token === null || !($user = Yii::createObject(self::di('User'))->findByToken($token))) {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            throw new yii\web\NotFoundHttpException();
        }

        if ($user->isRestoreTokenExpired()) {
            Yii::$app->session->setFlash('activeuser_error', ['token' => Yii::t('activeuser_general', 'You token was expired')]);
            return $this->redirect(['/activeuser/account/restore']);
        }

        /** @var RestoreForm $model */
        $model = Yii::createObject(RestoreForm::className());

        $model->setScenario($model::SCENARIO_PASSWORD);
        if ($this->getModule()->generatePassOnRestore) {
            // password auto generation
            $changed = $user->changePassword();
        } else {
            // change to user entered
            $model->email = $user->email;
            $changed = $model->load(Yii::$app->getRequest()->post()) && $model->changePassword();
        }
        if ($changed) {
            Yii::$app->session->setFlash($flashMessageId, $user->email);
            return $this->redirect(['/activeuser/account/password']);
        }
        return $this->render('restorePass', [
            'model' => $model
        ]);
    }

    /**
     * User resend confirmation message
     */
    public function actionResend()
    {
        // TODO filter too many resend request and set in Module period for resend
        if (!$this->getModule()->enableConfirmation) {
            throw new yii\web\NotFoundHttpException();
        }

        $email = Yii::$app->session->getFlash('resend');
        if ($email !== null) {
            // already sent
            return $this->render('resendComplete', [
                'email' => $email,
            ]);
        }

        // new resend
        /** @var ResendForm $model */
        $model = Yii::createObject(ResendForm::className());

        if ($model->load(Yii::$app->getRequest()->post()) && $model->resend()) {

            // resend complete, even if the user is not found
            Yii::$app->session->setFlash('resend', $model->email);
            return $this->redirect(['/activeuser/account/resend']);
        }
        return $this->render('resend', [
            'model' => $model,
        ]);
    }

    /**
     * Confirm email page
     * @param string $token user token for confirm email
     * @return string
     * @throws yii\base\InvalidConfigException
     */
    public function actionConfirm($token = '')
    {
        /** @var \inblank\activeuser\models\User $user */
        $user = Yii::createObject(self::di('User'))->findByToken($token);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($user !== null && $user->confirm()) {
            return $this->render('confirm', ['user' => $user]);
        }
        return $this->render('confirmWrong');
    }

    /**
     * View user data
     * @param int $id user identifier. If null, viewing data of the current logged user
     * If null and user is guest will trow yii\web\HttpException exception with 404 status code
     * @return string
     * @throws yii\web\HttpException
     */
    public function actionView($id = null)
    {
        $id || $id = Yii::$app->user->id;
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
        $user = $this->findModel($id);
        return $this->render('view', [
            'user' => $user
        ]);
    }

    /**
     * Update data of the current logged user
     */
    public function actionUpdate()
    {
        $user = $this->findModel(Yii::$app->user->id);
        if ($user->load(Yii::$app->request->post()) && $user->save()) {

            return $this->redirect(['index']);
        }
        return $this->render('update', [
            'user' => $user
        ]);
    }

    /**
     * Update password of the current logged user
     */
    public function actionChangePassword()
    {
        $user = $this->findModel(Yii::$app->user->id);
        /** @var ChangePasswordForm $form */
        $form = Yii::createObject(ChangePasswordForm::className());

        if ($form->load(Yii::$app->request->post()) && $form->changePassword()) {

            return $this->redirect(['index']);
        }
        $form->reset();
        return $this->render('changePassword', [
            'user' => $user,
            'model' => $form,
        ]);
    }

    /**
     * Find user model
     * @param mixed $value value for search
     * @param string $field field where search. Default `id`
     * @return mixed
     * @throws yii\web\HttpException
     */
    public function findModel($value, $field = 'id')
    {
        $user = Yii::createObject(self::di('User'))->findOne([$field => $value]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if (!$user) {
            throw new yii\web\HttpException(404, Yii::t('activeuser_frontend', 'User not found'));
        }
        return $user;
    }
}


1			<?php
2
3			namespace inblank\activeuser\controllers;
4
5			use inblank\activeuser\models\forms\ChangePasswordForm;
6			use inblank\activeuser\models\forms\LoginForm;
7			use inblank\activeuser\models\forms\RegisterForm;
8			use inblank\activeuser\models\forms\ResendForm;
9			use inblank\activeuser\models\forms\RestoreForm;
10			use inblank\activeuser\traits\CommonTrait;
11			use yii;
12			use yii\filters\AccessControl;
13			use yii\web\Controller;
14
15			class AccountController extends Controller
16			{
17
18			use CommonTrait;
19
20			/**
21			* @inheritdoc
22			*/
23			public function behaviors()
24			{
25			$authorizedUserAction = ['index', 'update', 'change-password', 'logout'];
26			return [
27			'access' => [
28			'class' => AccessControl::className(),
			0 ignored issues – show Deprecated Code introduced 2018-05-03 08:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `yii\base\BaseObject::className()` has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
29			'except' => ['confirm', 'view'],
30			'rules' => [
31			[
32			'allow' => true,
33			'actions' => ['register', 'login', 'resend', 'restore'],
34			'roles' => ['?'],
35			],
36			[
37			'allow' => true,
38			'actions' => $authorizedUserAction,
39			'roles' => ['@'],

inblank / yii2-activeuser

Issues (102)

Security Analysis not enabled

controllers/AccountController.php (20 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like