Issues in ConsoleController.php (master) - Issues in master - inblank/yii2-activeuser - Measure and Improve Code Quality continuously with Scrutinizer

Issues (102)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

components/ConsoleController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Console controller
 *
 * @link https://github.com/inblank/yii2-activeuser
 * @copyright Copyright (c) 2016 Pavel Aleksandrov <[email protected]>
 * @license http://opensource.org/licenses/MIT
 */

namespace inblank\activeuser\components;

use yii;
use yii\helpers\Console;

/**
 * Class ConsoleController
 *
 * @package inblank\activeuser\traits
 */
class ConsoleController extends yii\console\Controller
{
    /**
     * Confirm action
     * @param string $message message for confirm
     * @param bool $default default selection
     * @throws yii\base\ExitException
     */
    public function confirmAction($message, $default = false)
    {
        if (!Console::confirm($message, $default)) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
            Console::error(Yii::t('activeuser_backend', 'Action canceled'));
            Yii::$app->end();
        }
    }

    /**
     * Show action usage
     * @param string $required required params separated by comma
     * @param string $optional optional params separated by comma
     * @param array $errors errors to output
     * @throws yii\base\ExitException
     */
    protected function showUsage($required = '', $optional = '', $errors = [])
    {
        $description = Yii::t('activeuser_backend', $this->getActionHelp($this->action));
        Console::output($description);
        Console::output(str_pad('', mb_strlen($description), '-'));
        $paramsString = [];
        if (!empty($required)) {

            foreach (explode(',', $required) as $param) {
                $paramsString[] = '<' . trim($param) . '>';
            }
        }
        if (!empty($optional)) {

            foreach (explode(',', $optional) as $param) {
                $paramsString[] = '[' . trim($param) . ']';
            }
        }
        Console::output(
            Yii::t('activeuser_backend', 'Usage') . ': ' .
            Console::ansiFormat(
                'yii ' . $this->id . "/" . $this->action->id . ' ' .
                implode(' ', $paramsString),
                [Console::BOLD]
            )
        );
        Console::output();
        if (!empty($errors)) {
            $this->showErrors($errors);
        }
        yii::$app->end();
    }

    /**
     * Show errors
     * @param array $errors array of errors string
     * @throws yii\base\ExitException
     */
    protected function showErrors($errors)
    {
        foreach ((array)$errors as $err) {
            Console::error(Console::ansiFormat(Yii::t('activeuser_backend', "Error") . ": ", [Console::FG_RED]) . $err[0]);
        }
        yii::$app->end();
    }

}


1		<?php
2		/**
3		* Console controller
4		*
5		* @link https://github.com/inblank/yii2-activeuser
6		* @copyright Copyright (c) 2016 Pavel Aleksandrov <[email protected]>
7		* @license http://opensource.org/licenses/MIT
8		*/
9
10		namespace inblank\activeuser\components;
11
12		use yii;
13		use yii\helpers\Console;
14
15		/**
16		* Class ConsoleController
17		*
18		* @package inblank\activeuser\traits
19		*/
20		class ConsoleController extends yii\console\Controller
21		{
22		/**
23		* Confirm action
24		* @param string $message message for confirm
25		* @param bool $default default selection
26		* @throws yii\base\ExitException
27		*/
28		public function confirmAction($message, $default = false)
29		{
30		if (!Console::confirm($message, $default)) {
		0 ignored issues – show Bug Best Practice introduced 2017-07-06 07:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `\yii\helpers\Console::confirm($message, $default)` of type `boolean\|null` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
31		Console::error(Yii::t('activeuser_backend', 'Action canceled'));
32		Yii::$app->end();
33		}
34		}
35
36		/**
37		* Show action usage
38		* @param string $required required params separated by comma
39		* @param string $optional optional params separated by comma
40		* @param array $errors errors to output
41		* @throws yii\base\ExitException
42		*/
43		protected function showUsage($required = '', $optional = '', $errors = [])
44		{
45		$description = Yii::t('activeuser_backend', $this->getActionHelp($this->action));
46		Console::output($description);
47		Console::output(str_pad('', mb_strlen($description), '-'));
48		$paramsString = [];
49	View Code Duplication	if (!empty($required)) {
		0 ignored issues – show Duplication introduced 2017-07-06 07:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		foreach (explode(',', $required) as $param) {
51		$paramsString[] = '<' . trim($param) . '>';
52		}
53		}
54	View Code Duplication	if (!empty($optional)) {
		0 ignored issues – show Duplication introduced 2017-07-06 07:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
55		foreach (explode(',', $optional) as $param) {
56		$paramsString[] = '[' . trim($param) . ']';
57		}
58		}
59		Console::output(
60		Yii::t('activeuser_backend', 'Usage') . ': ' .
61		Console::ansiFormat(
62		'yii ' . $this->id . "/" . $this->action->id . ' ' .
63		implode(' ', $paramsString),
64		[Console::BOLD]
65		)
66		);
67		Console::output();
68		if (!empty($errors)) {
69		$this->showErrors($errors);
70		}
71		yii::$app->end();
72		}
73
74		/**
75		* Show errors
76		* @param array $errors array of errors string
77		* @throws yii\base\ExitException
78		*/
79		protected function showErrors($errors)
80		{
81		foreach ((array)$errors as $err) {
82		Console::error(Console::ansiFormat(Yii::t('activeuser_backend', "Error") . ": ", [Console::FG_RED]) . $err[0]);
83		}
84		yii::$app->end();
85		}
86
87		}
88

inblank / yii2-activeuser

Issues (102)

Security Analysis not enabled

components/ConsoleController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like