RestoreForm::changePassword() - Code Metrics - inblank/yii2-activeuser - Measure and Improve Code Quality continuously with Scrutinizer

RestoreForm::changePassword() A
last analyzed 2018-05-03 08:45 UTC

↳ Parent: RestoreForm

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	8

Duplication

Lines	13
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	13
loc	13
c	0
b	0
f	0
rs	9.4285
ccs	0
cts	12
cp	0
cc	3
eloc	8
nc	3
nop	0
crap	12

<?php

namespace inblank\activeuser\models\forms;

use inblank\activeuser\traits\CommonTrait;
use yii;
use yii\base\Model;

class RestoreForm extends Model
{
    use CommonTrait;

    const SCENARIO_PASSWORD = 'password';
    const SCENARIO_EMAIL = 'email';

    /**
     * @var string user email for restore password
     */
    public $email;
    /**
     * @var string new password
     */
    public $password;

    /** @inheritdoc */
    public function attributeLabels()
    {
        return [
            'email' => Yii::t('activeuser_general', 'Email'),
            'password' => Yii::t('activeuser_general', 'Password'),
        ];
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            ['email', 'required', 'on' => self::SCENARIO_EMAIL],
            ['email', 'email', 'skipOnEmpty' => true],

            ['password', 'required', 'on' => self::SCENARIO_PASSWORD],
            ['password', 'string', 'length' => [6, 20], 'skipOnEmpty' => true],
        ];
    }

    /**
     * Restore
     * @return bool
     * @throws yii\base\InvalidConfigException
     */
    public function restore()

    {
        if (!$this->validate()) {
            return false;
        }
        /** @var \inblank\activeuser\models\User $user */
        $user = Yii::createObject(self::di('User'))->findOne(['email' => $this->email]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($user) {
            $user->restore();
        }
        return true;
    }
    /**
     * Change password
     * @return bool
     * @throws yii\base\InvalidConfigException
     */
    public function changePassword()

    {
        if (!$this->validate()) {
            return false;
        }
        /** @var \inblank\activeuser\models\User $user */
        $user = Yii::createObject(self::di('User'))->findOne(['email' => $this->email]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        if ($user) {
            $user->password = $this->password;
            $user->newPassword();
        }
        return true;
    }
}


1		<?php
2
3		namespace inblank\activeuser\models\forms;
4
5		use inblank\activeuser\traits\CommonTrait;
6		use yii;
7		use yii\base\Model;
8
9		class RestoreForm extends Model
10		{
11		use CommonTrait;
12
13		const SCENARIO_PASSWORD = 'password';
14		const SCENARIO_EMAIL = 'email';
15
16		/**
17		* @var string user email for restore password
18		*/
19		public $email;
20		/**
21		* @var string new password
22		*/
23		public $password;
24
25		/** @inheritdoc */
26		public function attributeLabels()
27		{
28		return [
29		'email' => Yii::t('activeuser_general', 'Email'),
30		'password' => Yii::t('activeuser_general', 'Password'),
31		];
32		}
33
34		/**
35		* @inheritdoc
36		*/
37		public function rules()
38		{
39		return [
40		['email', 'required', 'on' => self::SCENARIO_EMAIL],
41		['email', 'email', 'skipOnEmpty' => true],
42
43		['password', 'required', 'on' => self::SCENARIO_PASSWORD],
44		['password', 'string', 'length' => [6, 20], 'skipOnEmpty' => true],
45		];
46		}
47
48		/**
49		* Restore
50		* @return bool
51		* @throws yii\base\InvalidConfigException
52		*/
53	View Code Duplication	public function restore()
		0 ignored issues – show Duplication introduced 2018-05-03 08:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		if (!$this->validate()) {
56		return false;
57		}
58		/** @var \inblank\activeuser\models\User $user */
59		$user = Yii::createObject(self::di('User'))->findOne(['email' => $this->email]);
		0 ignored issues – show Documentation introduced 2017-07-06 07:33 UTC by Report Bug Copy Issue Report `self::di('User')` is of type `*`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
60		if ($user) {
61		$user->restore();
62		}
63		return true;
64		}
65		/**
66		* Change password
67		* @return bool
68		* @throws yii\base\InvalidConfigException
69		*/
70	View Code Duplication	public function changePassword()
		0 ignored issues – show Duplication introduced 2018-05-03 08:00 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		if (!$this->validate()) {
73		return false;
74		}
75		/** @var \inblank\activeuser\models\User $user */
76		$user = Yii::createObject(self::di('User'))->findOne(['email' => $this->email]);
		0 ignored issues – show Documentation introduced 2017-07-06 07:33 UTC by Report Bug Copy Issue Report `self::di('User')` is of type `*`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77		if ($user) {
78		$user->password = $this->password;
79		$user->newPassword();
80		}
81		return true;
82		}
83		}
84

inblank / yii2-activeuser

RestoreForm::changePassword() A last analyzed 2018-05-03 08:45 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RestoreForm::changePassword() A
last analyzed 2018-05-03 08:45 UTC