inblank\activeuser\controllers\backend\UserController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	148
Duplicated Lines	16.22 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	behaviors()	0	13	1
A	actionIndex()	0	10	1
A	actionView()	0	6	1
A	actionCreate()	12	12	3
A	actionUpdate()	12	12	3
A	actionDelete()	0	6	1
A	actionChangePassword()	0	7	1
A	actionBlock()	0	5	1
A	actionUnblock()	0	5	1
A	findModel()	0	8	2

<?php

namespace inblank\activeuser\controllers\backend;

use Yii;
use inblank\activeuser\models\User;
use inblank\activeuser\models\UserSearch;
use yii\web\Controller;
use yii\web\NotFoundHttpException;
use yii\filters\VerbFilter;

/**
 * UserController implements the CRUD actions for User model.
 */
class UserController extends Controller
{
    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::className(),

The method yii\base\BaseObject::className() has been deprecated with message: since 2.0.14. On PHP >=5.5, use `::class` instead.

                'actions' => [
                    'delete' => ['POST'],
                    'change-password' => ['POST'],
                    'block' => ['POST'],
                ],
            ],
        ];
    }

    /**
     * Lists all User models.
     * @return mixed
     */
    public function actionIndex()
    {
        $searchModel = new UserSearch();
        $dataProvider = $searchModel->search(Yii::$app->request->queryParams);

        return $this->render('index', [
            'searchModel' => $searchModel,
            'dataProvider' => $dataProvider,
        ]);
    }

    /**
     * Displays a single User model.
     * @param integer $id
     * @return mixed
     */
    public function actionView($id)
    {
        return $this->render('view', [
            'model' => $this->findModel($id),
        ]);
    }

    /**
     * Creates a new User model.
     * If creation is successful, the browser will be redirected to the 'view' page.
     * @return mixed
     */
    public function actionCreate()

This method seems to be duplicated in your project.

    {
        $model = new User();

        if ($model->load(Yii::$app->request->post()) && $model->create(false)) {
            return $this->redirect(['view', 'id' => $model->id]);
        } else {
            return $this->render('create', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Updates an existing User model.
     * If update is successful, the browser will be redirected to the 'view' page.
     * @param integer $id
     * @return mixed
     */
    public function actionUpdate($id)

This method seems to be duplicated in your project.

    {
        $model = $this->findModel($id);

        if ($model->load(Yii::$app->request->post()) && $model->save()) {
            return $this->redirect(['view', 'id' => $model->id]);
        } else {
            return $this->render('update', [
                'model' => $model,
            ]);
        }
    }

    /**
     * Deletes an existing User model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     * @param integer $id
     * @return mixed
     */
    public function actionDelete($id)
    {
        $this->findModel($id)->delete();

        return $this->redirect(['index']);
    }

    /**
     * Change user password
     * @param int $id user identifier
     * @return \yii\web\Response
     */
    public function actionChangePassword($id)
    {
        $user = $this->findModel($id);
        $user->password = null;
        $user->newPassword(false);
        return $this->redirect(['view', 'id' => $id]);
    }

    /**
     * Block user
     * @param int $id user identifier
     * @return \yii\web\Response
     */
    public function actionBlock($id)
    {
        $this->findModel($id)->block(false);
        return $this->redirect(['view', 'id' => $id]);
    }

    /**
     * Unblock user
     * @param int $id user identifier
     * @return \yii\web\Response
     */
    public function actionUnblock($id)
    {
        $this->findModel($id)->unblock(false);
        return $this->redirect(['view', 'id' => $id]);
    }

    /**
     * Finds the User model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param integer $id
     * @return User the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)
    {
        if (($model = User::findOne($id)) !== null) {

The expression \inblank\activeuser\models\User::findOne($id); of type yii\db\ActiveRecordInterface|array|null adds the type array to the return on line 156 which is incompatible with the return type documented by inblank\activeuser\controllers\backend\UserController::findModel of type inblank\activeuser\models\User.

            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }

}