Issues in price-functions.php (master) - Issues in master - impress-org/give - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1282)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/price-functions.php (1 issue)

Labels

Bug 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Price Functions
 *
 * @package     Give
 * @subpackage  Functions
 * @copyright   Copyright (c) 2016, GiveWP
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       1.0
 */

// Exit if accessed directly.
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Checks to see if a Give form has variable prices enabled.
 *
 * @since 1.0
 *
 * @param int $form_id ID number of the form to check
 *
 * @return bool true if has variable prices, false otherwise
 */
function give_has_variable_prices( $form_id = 0 ) {

	if ( empty( $form_id ) ) {
		return false;
	}

	$form = new Give_Donate_Form( $form_id );

	return $form->has_variable_prices();
}


/**
 * Retrieves the variable prices for a form
 *
 * @since 1.0
 *
 * @param int $form_id ID of the Give form
 *
 * @return array|bool Variable prices
 */
function give_get_variable_prices( $form_id = 0 ) {

	if ( empty( $form_id ) ) {
		return false;
	}

	$form = new Give_Donate_Form( $form_id );

	return $form->prices;

}

/**
 * Retrieves the variable price ids for a form
 *
 * @since 1.8.8
 *
 * @param int $form_id ID of the Give form
 *
 * @return array Variable prices
 */
function give_get_variable_price_ids( $form_id = 0 ) {
	if( ! ( $prices = give_get_variable_prices( $form_id ) ) ) {
		return array();
	}

	$price_ids = array();
	foreach ( $prices as $price ){
		$price_ids[] = $price['_give_id']['level_id'];
	}

	return $price_ids;
}


/**
 * Get the default amount for multi-level forms
 *
 * @access public
 * @since  1.0
 *
 * @param int $form_id
 *
 * @return string $default_price
 */
function give_get_default_multilevel_amount( $form_id ) {
	$default_price = '1.00';

	// Get default level price data.
	$default_level = give_form_get_default_level( $form_id );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
	$default_price = isset( $default_level['_give_amount'] ) ? $default_level['_give_amount'] : $default_price;

	return $default_price;
}


/**
 * Get Default Form Amount
 *
 * Grabs the default amount for set and level forms
 *
 * @param int $form_id
 *
 * @return string $default_price
 * @since      1.0
 */
function give_get_default_form_amount( $form_id ) {

	if ( give_has_variable_prices( $form_id ) ) {

		$default_amount = give_get_default_multilevel_amount( $form_id );

	} else {

		$default_amount = give_get_meta( $form_id, '_give_set_price', true );

	}

	return apply_filters( 'give_default_form_amount', $default_amount, $form_id );

}


/**
 * Determine if custom price mode is enabled or disabled.
 *
 * This function is wrapper function to Give_Donate_Form::is_custom_price_mode()
 *
 * @since 1.6
 *
 * @param int $form_id Form ID.
 *
 * @use   Give_Donate_Form::is_custom_price_mode()
 *
 * @return bool
 */
function give_is_custom_price_mode( $form_id = 0 ) {

	if ( empty( $form_id ) ) {
		return false;
	}

	$form = new Give_Donate_Form( $form_id );

	return $form->is_custom_price_mode();
}


1			<?php
2			/**
3			* Price Functions
4			*
5			* @package Give
6			* @subpackage Functions
7			* @copyright Copyright (c) 2016, GiveWP
8			* @license https://opensource.org/licenses/gpl-license GNU Public License
9			* @since 1.0
10			*/
11
12			// Exit if accessed directly.
13			if ( ! defined( 'ABSPATH' ) ) {
14			exit;
15			}
16
17			/**
18			* Checks to see if a Give form has variable prices enabled.
19			*
20			* @since 1.0
21			*
22			* @param int $form_id ID number of the form to check
23			*
24			* @return bool true if has variable prices, false otherwise
25			*/
26			function give_has_variable_prices( $form_id = 0 ) {
27
28			if ( empty( $form_id ) ) {
29			return false;
30			}
31
32			$form = new Give_Donate_Form( $form_id );
33
34			return $form->has_variable_prices();
35			}
36
37
38			/**
39			* Retrieves the variable prices for a form
40			*
41			* @since 1.0
42			*
43			* @param int $form_id ID of the Give form
44			*
45			* @return array\|bool Variable prices
46			*/
47			function give_get_variable_prices( $form_id = 0 ) {
48
49			if ( empty( $form_id ) ) {
50			return false;
51			}
52
53			$form = new Give_Donate_Form( $form_id );
54
55			return $form->prices;
56
57			}
58
59			/**
60			* Retrieves the variable price ids for a form
61			*
62			* @since 1.8.8
63			*
64			* @param int $form_id ID of the Give form
65			*
66			* @return array Variable prices
67			*/
68			function give_get_variable_price_ids( $form_id = 0 ) {
69			if( ! ( $prices = give_get_variable_prices( $form_id ) ) ) {
70			return array();
71			}
72
73			$price_ids = array();
74			foreach ( $prices as $price ){
75			$price_ids[] = $price['_give_id']['level_id'];
76			}
77
78			return $price_ids;
79			}
80
81
82			/**
83			* Get the default amount for multi-level forms
84			*
85			* @access public
86			* @since 1.0
87			*
88			* @param int $form_id
89			*
90			* @return string $default_price
91			*/
92			function give_get_default_multilevel_amount( $form_id ) {
93			$default_price = '1.00';
94
95			// Get default level price data.
96			$default_level = give_form_get_default_level( $form_id );
			0 ignored issues – show Bug introduced 2018-10-24 21:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$default_level` is correct as `give_form_get_default_level($form_id)` (which targets `give_form_get_default_level()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
97			$default_price = isset( $default_level['_give_amount'] ) ? $default_level['_give_amount'] : $default_price;
98
99			return $default_price;
100			}
101
102
103			/**
104			* Get Default Form Amount
105			*
106			* Grabs the default amount for set and level forms
107			*
108			* @param int $form_id
109			*
110			* @return string $default_price
111			* @since 1.0
112			*/
113			function give_get_default_form_amount( $form_id ) {
114
115			if ( give_has_variable_prices( $form_id ) ) {
116
117			$default_amount = give_get_default_multilevel_amount( $form_id );
118
119			} else {
120
121			$default_amount = give_get_meta( $form_id, '_give_set_price', true );
122
123			}
124
125			return apply_filters( 'give_default_form_amount', $default_amount, $form_id );
126
127			}
128
129
130			/**
131			* Determine if custom price mode is enabled or disabled.
132			*
133			* This function is wrapper function to Give_Donate_Form::is_custom_price_mode()
134			*
135			* @since 1.6
136			*
137			* @param int $form_id Form ID.
138			*
139			* @use Give_Donate_Form::is_custom_price_mode()
140			*
141			* @return bool
142			*/
143			function give_is_custom_price_mode( $form_id = 0 ) {
144
145			if ( empty( $form_id ) ) {
146			return false;
147			}
148
149			$form = new Give_Donate_Form( $form_id );
150
151			return $form->is_custom_price_mode();
152			}
153

impress-org / give

Issues (1282)

Security Analysis not enabled

includes/price-functions.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like