Give_Frontend::get_instance() - Code Metrics - Inspection of "Merge pull request #4081 from impress-org/release/..." - impress-org/give - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 36b0ed...c8da5c )

by Devin

created 2019-04-16 18:59 UTC

Give_Frontend::get_instance() A

↳ Parent: Give_Frontend

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	0
dl	8
loc	8
rs	10
c	0
b	0
f	0

<?php

/**
 * This class will handle file loading for frontend.
 *
 * @package     Give
 * @subpackage  Frontend
 * @copyright   Copyright (c) 2018, GiveWP
 * @license     https://opensource.org/licenses/gpl-license GNU Public License
 * @since       2.4.0
 */
class Give_Frontend {

	/**
	 * Instance.
	 *
	 * @since  2.4.0
	 * @access private
	 * @var
	 */
	static private $instance;

	/**
	 * Singleton pattern.
	 *
	 * @since  2.4.0
	 * @access private
	 */
	private function __construct() {
	}


	/**
	 * Get instance.
	 *
	 * @since  2.4.0
	 * @access public
	 * @return Give_Frontend
	 */
	public static function get_instance() {

		if ( null === static::$instance ) {
			self::$instance = new static();
			self::$instance->setup();
		}

		return self::$instance;
	}

	/**
	 * Setup Admin
	 *
	 * @sinve  2.4.0
	 * @access private
	 */
	private function setup() {
		$this->frontend_loading();

		add_action( 'give_init', array( $this, 'bc_240' ), 0 );
	}

	/**
	 *  Load core file
	 *
	 * @since  2.4.0
	 * @access private
	 */
	private function frontend_loading() {
		require_once GIVE_PLUGIN_DIR . 'includes/class-give-template-loader.php';
		require_once GIVE_PLUGIN_DIR . 'includes/class-give-email-access.php'; // @todo: [refactor] can be load only for success and history page.
	}

	/**
	 * Backward compatibility GIVE_VERSION < 2.4.0
	 *
	 * @since 2.4.0
	 * @ccess public
	 *
	 * @param Give $give
	 */
	public function bc_240( $give ) {
		$give->template_loader = new Give_Template_Loader();
		$give->email_access    = new Give_Email_Access();
	}
}

Give_Frontend::get_instance();


1		<?php
2
3		/**
4		* This class will handle file loading for frontend.
5		*
6		* @package Give
7		* @subpackage Frontend
8		* @copyright Copyright (c) 2018, GiveWP
9		* @license https://opensource.org/licenses/gpl-license GNU Public License
10		* @since 2.4.0
11		*/
12		class Give_Frontend {
		0 ignored issues – show Coding Style introduced 2019-01-17 04:28 UTC by Report Bug Copy Issue Report Since you have declared the constructor as private, maybe you should also declare the class as final. Loading history...
13		/**
14		* Instance.
15		*
16		* @since 2.4.0
17		* @access private
18		* @var
19		*/
20		static private $instance;
21
22		/**
23		* Singleton pattern.
24		*
25		* @since 2.4.0
26		* @access private
27		*/
28		private function __construct() {
29		}
30
31
32		/**
33		* Get instance.
34		*
35		* @since 2.4.0
36		* @access public
37		* @return Give_Frontend
38		*/
39	View Code Duplication	public static function get_instance() {
		0 ignored issues – show Duplication introduced 2019-01-17 04:28 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
40		if ( null === static::$instance ) {
41		self::$instance = new static();
42		self::$instance->setup();
43		}
44
45		return self::$instance;
46		}
47
48		/**
49		* Setup Admin
50		*
51		* @sinve 2.4.0
52		* @access private
53		*/
54		private function setup() {
55		$this->frontend_loading();
56
57		add_action( 'give_init', array( $this, 'bc_240' ), 0 );
58		}
59
60		/**
61		* Load core file
62		*
63		* @since 2.4.0
64		* @access private
65		*/
66		private function frontend_loading() {
67		require_once GIVE_PLUGIN_DIR . 'includes/class-give-template-loader.php';
68		require_once GIVE_PLUGIN_DIR . 'includes/class-give-email-access.php'; // @todo: [refactor] can be load only for success and history page.
69		}
70
71		/**
72		* Backward compatibility GIVE_VERSION < 2.4.0
73		*
74		* @since 2.4.0
75		* @ccess public
76		*
77		* @param Give $give
78		*/
79		public function bc_240( $give ) {
80		$give->template_loader = new Give_Template_Loader();
81		$give->email_access = new Give_Email_Access();
82		}
83		}
84
85		Give_Frontend::get_instance();
86

impress-org / give

Push — master ( 36b0ed...c8da5c )

Give_Frontend::get_instance() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like