File::create() - Code Metrics - Inspection of "merge 2.5.3 to master for release (#4200)" - impress-org/give - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3dd85e...34f16b )

by Devin

created 2019-07-31 05:51 UTC

File::create() A

↳ Parent: File

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
nc	4
nop	2
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0

<?php

namespace Stripe;

/**
 * Class File
 *
 * @property string $id
 * @property string $object
 * @property int $created
 * @property string $filename
 * @property Collection $links
 * @property string $purpose
 * @property int $size
 * @property string $title
 * @property string $type
 * @property string $url
 *
 * @package Stripe
 */
class File extends ApiResource
{
    // This resource can have two different object names. In latter API
    // versions, only `file` is used, but since stripe-php may be used with
    // any API version, we need to support deserializing the older
    // `file_upload` object into the same class.
    const OBJECT_NAME = "file";
    const OBJECT_NAME_ALT = "file_upload";

    use ApiOperations\All;
    use ApiOperations\Create {
        create as protected _create;
    }
    use ApiOperations\Retrieve;

    public static function classUrl()
    {
        return '/v1/files';
    }

    /**
     * @param array|null $params
     * @param array|string|null $options
     *
     * @return \Stripe\File The created resource.
     */
    public static function create($params = null, $options = null)
    {
        $opts = \Stripe\Util\RequestOptions::parse($options);
        if (is_null($opts->apiBase)) {
            $opts->apiBase = Stripe::$apiUploadBase;
        }
        // Manually flatten params, otherwise curl's multipart encoder will
        // choke on nested arrays.
        // TODO: use array_column() once we drop support for PHP 5.4
        $flatParams = [];
        foreach (\Stripe\Util\Util::flattenParams($params) as $pair) {

            $flatParams[$pair[0]] = $pair[1];
        }
        return static::_create($flatParams, $opts);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			namespace Stripe;
4
5			/**
6			* Class File
7			*
8			* @property string $id
9			* @property string $object
10			* @property int $created
11			* @property string $filename
12			* @property Collection $links
13			* @property string $purpose
14			* @property int $size
15			* @property string $title
16			* @property string $type
17			* @property string $url
18			*
19			* @package Stripe
20			*/
21			class File extends ApiResource
22			{
23			// This resource can have two different object names. In latter API
24			// versions, only `file` is used, but since stripe-php may be used with
25			// any API version, we need to support deserializing the older
26			// `file_upload` object into the same class.
27			const OBJECT_NAME = "file";
28			const OBJECT_NAME_ALT = "file_upload";
29
30			use ApiOperations\All;
31			use ApiOperations\Create {
32			create as protected _create;
33			}
34			use ApiOperations\Retrieve;
35
36			public static function classUrl()
37			{
38			return '/v1/files';
39			}
40
41			/**
42			* @param array\|null $params
43			* @param array\|string\|null $options
44			*
45			* @return \Stripe\File The created resource.
46			*/
47			public static function create($params = null, $options = null)
48			{
49			$opts = \Stripe\Util\RequestOptions::parse($options);
50			if (is_null($opts->apiBase)) {
51			$opts->apiBase = Stripe::$apiUploadBase;
52			}
53			// Manually flatten params, otherwise curl's multipart encoder will
54			// choke on nested arrays.
55			// TODO: use array_column() once we drop support for PHP 5.4
56			$flatParams = [];
57			foreach (\Stripe\Util\Util::flattenParams($params) as $pair) {
			0 ignored issues – show Bug introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report It seems like `$params` defined by parameter `$params` on line 47 can also be of type `null`; however, `Stripe\Util\Util::flattenParams()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
58			$flatParams[$pair[0]] = $pair[1];
59			}
60			return static::_create($flatParams, $opts);
			0 ignored issues – show Documentation introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report `$opts` is of type `object<Stripe\Util\RequestOptions>`, but the function expects a `array\|string\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62			}
63

impress-org / give

Push — master ( 3dd85e...34f16b )

File::create() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like