Dispute::close() - Code Metrics - Inspection of "merge 2.5.3 to master for release (#4200)" - impress-org/give - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3dd85e...34f16b )

by Devin

created 2019-07-31 05:51 UTC

Dispute::close() A

↳ Parent: Dispute

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	1
dl	7
loc	7
rs	10
c	0
b	0
f	0

<?php

namespace Stripe;

/**
 * Class Dispute
 *
 * @property string $id
 * @property string $object
 * @property int $amount
 * @property BalanceTransaction[] $balance_transactions
 * @property string $charge
 * @property int $created
 * @property string $currency
 * @property mixed $evidence
 * @property mixed $evidence_details
 * @property bool $is_charge_refundable
 * @property bool $livemode
 * @property StripeObject $metadata
 * @property string $reason
 * @property string $status
 *
 * @package Stripe
 */
class Dispute extends ApiResource

{

    const OBJECT_NAME = "dispute";

    use ApiOperations\All;
    use ApiOperations\Retrieve;
    use ApiOperations\Update;

    /**
     * Possible string representations of dispute reasons.
     * @link https://stripe.com/docs/api#dispute_object
     */
    const REASON_BANK_CANNOT_PROCESS       = 'bank_cannot_process';
    const REASON_CHECK_RETURNED            = 'check_returned';
    const REASON_CREDIT_NOT_PROCESSED      = 'credit_not_processed';
    const REASON_CUSTOMER_INITIATED        = 'customer_initiated';
    const REASON_DEBIT_NOT_AUTHORIZED      = 'debit_not_authorized';
    const REASON_DUPLICATE                 = 'duplicate';
    const REASON_FRAUDULENT                = 'fraudulent';
    const REASON_GENERAL                   = 'general';
    const REASON_INCORRECT_ACCOUNT_DETAILS = 'incorrect_account_details';
    const REASON_INSUFFICIENT_FUNDS        = 'insufficient_funds';
    const REASON_PRODUCT_NOT_RECEIVED      = 'product_not_received';
    const REASON_PRODUCT_UNACCEPTABLE      = 'product_unacceptable';
    const REASON_SUBSCRIPTION_CANCELED     = 'subscription_canceled';
    const REASON_UNRECOGNIZED              = 'unrecognized';

    /**
     * Possible string representations of dispute statuses.
     * @link https://stripe.com/docs/api#dispute_object
     */
    const STATUS_CHARGE_REFUNDED        = 'charge_refunded';
    const STATUS_LOST                   = 'lost';
    const STATUS_NEEDS_RESPONSE         = 'needs_response';
    const STATUS_UNDER_REVIEW           = 'under_review';
    const STATUS_WARNING_CLOSED         = 'warning_closed';
    const STATUS_WARNING_NEEDS_RESPONSE = 'warning_needs_response';
    const STATUS_WARNING_UNDER_REVIEW   = 'warning_under_review';
    const STATUS_WON                    = 'won';

    /**
     * @param array|string|null $options
     *
     * @return Dispute The closed dispute.
     */
    public function close($options = null)
    {
        $url = $this->instanceUrl() . '/close';
        list($response, $opts) = $this->_request('post', $url, null, $options);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->refreshFrom($response, $opts);
        return $this;
    }
}


1		<?php
2
3		namespace Stripe;
4
5		/**
6		* Class Dispute
7		*
8		* @property string $id
9		* @property string $object
10		* @property int $amount
11		* @property BalanceTransaction[] $balance_transactions
12		* @property string $charge
13		* @property int $created
14		* @property string $currency
15		* @property mixed $evidence
16		* @property mixed $evidence_details
17		* @property bool $is_charge_refundable
18		* @property bool $livemode
19		* @property StripeObject $metadata
20		* @property string $reason
21		* @property string $status
22		*
23		* @package Stripe
24		*/
25	View Code Duplication	class Dispute extends ApiResource
		0 ignored issues – show Duplication introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		{
27
28		const OBJECT_NAME = "dispute";
29
30		use ApiOperations\All;
31		use ApiOperations\Retrieve;
32		use ApiOperations\Update;
33
34		/**
35		* Possible string representations of dispute reasons.
36		* @link https://stripe.com/docs/api#dispute_object
37		*/
38		const REASON_BANK_CANNOT_PROCESS = 'bank_cannot_process';
39		const REASON_CHECK_RETURNED = 'check_returned';
40		const REASON_CREDIT_NOT_PROCESSED = 'credit_not_processed';
41		const REASON_CUSTOMER_INITIATED = 'customer_initiated';
42		const REASON_DEBIT_NOT_AUTHORIZED = 'debit_not_authorized';
43		const REASON_DUPLICATE = 'duplicate';
44		const REASON_FRAUDULENT = 'fraudulent';
45		const REASON_GENERAL = 'general';
46		const REASON_INCORRECT_ACCOUNT_DETAILS = 'incorrect_account_details';
47		const REASON_INSUFFICIENT_FUNDS = 'insufficient_funds';
48		const REASON_PRODUCT_NOT_RECEIVED = 'product_not_received';
49		const REASON_PRODUCT_UNACCEPTABLE = 'product_unacceptable';
50		const REASON_SUBSCRIPTION_CANCELED = 'subscription_canceled';
51		const REASON_UNRECOGNIZED = 'unrecognized';
52
53		/**
54		* Possible string representations of dispute statuses.
55		* @link https://stripe.com/docs/api#dispute_object
56		*/
57		const STATUS_CHARGE_REFUNDED = 'charge_refunded';
58		const STATUS_LOST = 'lost';
59		const STATUS_NEEDS_RESPONSE = 'needs_response';
60		const STATUS_UNDER_REVIEW = 'under_review';
61		const STATUS_WARNING_CLOSED = 'warning_closed';
62		const STATUS_WARNING_NEEDS_RESPONSE = 'warning_needs_response';
63		const STATUS_WARNING_UNDER_REVIEW = 'warning_under_review';
64		const STATUS_WON = 'won';
65
66		/**
67		* @param array\|string\|null $options
68		*
69		* @return Dispute The closed dispute.
70		*/
71		public function close($options = null)
72		{
73		$url = $this->instanceUrl() . '/close';
74		list($response, $opts) = $this->_request('post', $url, null, $options);
		0 ignored issues – show Documentation introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report `null` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75		$this->refreshFrom($response, $opts);
76		return $this;
77		}
78		}
79

impress-org / give

Push — master ( 3dd85e...34f16b )

Dispute::close() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like