PaymentMethod - Code Metrics - Inspection of "merge 2.5.3 to master for release (#4200)" - impress-org/give - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3dd85e...34f16b )

by Devin

created 2019-07-31 05:51 UTC

PaymentMethod A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	38
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	38
loc	38
rs	10
c	0
b	0
f	0
wmc	2
lcom	1
cbo	5

2 Methods

Rating	Name	Duplication	Size	Complexity
A	attach()	7	7	1
A	detach()	7	7	1

How to fix Duplicated Code

<?php

namespace Stripe;

/**
 * Class PaymentMethod
 *
 * @property string $id
 * @property string $object
 * @property mixed $billing_details
 * @property mixed $card
 * @property mixed $card_present
 * @property int $created
 * @property string $customer
 * @property mixed $ideal
 * @property bool $livemode
 * @property StripeObject $metadata
 * @property mixed $sepa_debit
 * @property string $type
 *
 * @package Stripe
 */
class PaymentMethod extends ApiResource

{

    const OBJECT_NAME = "payment_method";

    use ApiOperations\All;
    use ApiOperations\Create;
    use ApiOperations\Retrieve;
    use ApiOperations\Update;

    /**
     * @param array|null $params
     * @param array|string|null $opts
     *
     * @return PaymentMethod The attached payment method.
     */
    public function attach($params = null, $opts = null)
    {
        $url = $this->instanceUrl() . '/attach';
        list($response, $opts) = $this->_request('post', $url, $params, $opts);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->refreshFrom($response, $opts);
        return $this;
    }

    /**
     * @param array|null $params
     * @param array|string|null $opts
     *
     * @return PaymentMethod The detached payment method.
     */
    public function detach($params = null, $opts = null)
    {
        $url = $this->instanceUrl() . '/detach';
        list($response, $opts) = $this->_request('post', $url, $params, $opts);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $this->refreshFrom($response, $opts);
        return $this;
    }
}


1		<?php
2
3		namespace Stripe;
4
5		/**
6		* Class PaymentMethod
7		*
8		* @property string $id
9		* @property string $object
10		* @property mixed $billing_details
11		* @property mixed $card
12		* @property mixed $card_present
13		* @property int $created
14		* @property string $customer
15		* @property mixed $ideal
16		* @property bool $livemode
17		* @property StripeObject $metadata
18		* @property mixed $sepa_debit
19		* @property string $type
20		*
21		* @package Stripe
22		*/
23	View Code Duplication	class PaymentMethod extends ApiResource
		0 ignored issues – show Duplication introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25
26		const OBJECT_NAME = "payment_method";
27
28		use ApiOperations\All;
29		use ApiOperations\Create;
30		use ApiOperations\Retrieve;
31		use ApiOperations\Update;
32
33		/**
34		* @param array\|null $params
35		* @param array\|string\|null $opts
36		*
37		* @return PaymentMethod The attached payment method.
38		*/
39		public function attach($params = null, $opts = null)
40		{
41		$url = $this->instanceUrl() . '/attach';
42		list($response, $opts) = $this->_request('post', $url, $params, $opts);
		0 ignored issues – show Bug introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report It seems like `$params` can also be of type `null`; however, `Stripe\ApiOperations\Request::_request()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
43		$this->refreshFrom($response, $opts);
44		return $this;
45		}
46
47		/**
48		* @param array\|null $params
49		* @param array\|string\|null $opts
50		*
51		* @return PaymentMethod The detached payment method.
52		*/
53		public function detach($params = null, $opts = null)
54		{
55		$url = $this->instanceUrl() . '/detach';
56		list($response, $opts) = $this->_request('post', $url, $params, $opts);
		0 ignored issues – show Bug introduced 2019-07-31 05:55 UTC by Report Bug Copy Issue Report It seems like `$params` can also be of type `null`; however, `Stripe\ApiOperations\Request::_request()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
57		$this->refreshFrom($response, $opts);
58		return $this;
59		}
60		}
61

impress-org / give

Push — master ( 3dd85e...34f16b )

PaymentMethod A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like