Stripe\BankAccount

Complexity

Total Complexity

6

Size/Duplication

Total Lines	84
Duplicated Lines	14.29 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	verify()	0	7	1

<?php

namespace Stripe;

/**
 * Class BankAccount
 *
 * @property string $id
 * @property string $object
 * @property string $account
 * @property string $account_holder_name
 * @property string $account_holder_type
 * @property string $bank_name
 * @property string $country
 * @property string $currency
 * @property string $customer
 * @property bool $default_for_currency
 * @property string $fingerprint
 * @property string $last4
 * @property StripeObject $metadata
 * @property string $routing_number
 * @property string $status
 *
 * @package Stripe
 */
class BankAccount extends ApiResource
{

    const OBJECT_NAME = "bank_account";

    use ApiOperations\Delete;
    use ApiOperations\Update;

    /**
     * Possible string representations of the bank verification status.
     * @link https://stripe.com/docs/api/external_account_bank_accounts/object#account_bank_account_object-status
     */
    const STATUS_NEW                 = 'new';
    const STATUS_VALIDATED           = 'validated';
    const STATUS_VERIFIED            = 'verified';
    const STATUS_VERIFICATION_FAILED = 'verification_failed';
    const STATUS_ERRORED             = 'errored';

    /**
     * @return string The instance URL for this resource. It needs to be special
     *    cased because it doesn't fit into the standard resource pattern.
     */
    public function instanceUrl()
    {
        if ($this['customer']) {
            $base = Customer::classUrl();
            $parent = $this['customer'];
            $path = 'sources';
        } elseif ($this['account']) {

This code seems to be duplicated across your project.

            $base = Account::classUrl();
            $parent = $this['account'];
            $path = 'external_accounts';
        } else {
            $msg = "Bank accounts cannot be accessed without a customer ID or account ID.";
            throw new Error\InvalidRequest($msg, null);
        }
        $parentExtn = urlencode(Util\Util::utf8($parent));
        $extn = urlencode(Util\Util::utf8($this['id']));
        return "$base/$parentExtn/$path/$extn";
    }

    /**
     * @param array|string $_id
     * @param array|string|null $_opts
     *
     * @throws \Stripe\Error\InvalidRequest
     */
    public static function retrieve($_id, $_opts = null)

The parameter $_id is not used and could be removed.

The parameter $_opts is not used and could be removed.

    {
        $msg = "Bank accounts cannot be accessed without a customer ID or account ID. " .
               "Retrieve a bank account using \$customer->sources->retrieve('bank_account_id') or " .
               "\$account->external_accounts->retrieve('bank_account_id') instead.";
        throw new Error\InvalidRequest($msg, null);
    }

    /**
     * @param string $_id
     * @param array|null $_params
     * @param array|string|null $_options
     *
     * @throws \Stripe\Error\InvalidRequest
     */
    public static function update($_id, $_params = null, $_options = null)

The parameter $_id is not used and could be removed.

The parameter $_params is not used and could be removed.

The parameter $_options is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $msg = "Bank accounts cannot be accessed without a customer ID or account ID. " .
               "Call save() on \$customer->sources->retrieve('bank_account_id') or " .
               "\$account->external_accounts->retrieve('bank_account_id') instead.";
        throw new Error\InvalidRequest($msg, null);
    }

   /**
     * @param array|null $params
     * @param array|string|null $options
     *
     * @return BankAccount The verified bank account.
     */
    public function verify($params = null, $options = null)
    {
        $url = $this->instanceUrl() . '/verify';
        list($response, $opts) = $this->_request('post', $url, $params, $options);

It seems like $params can also be of type null; however, Stripe\ApiOperations\Request::_request() does only seem to accept array, maybe add an additional type check?

        $this->refreshFrom($response, $opts);
        return $this;
    }
}