Conditions | 4 |
Paths | 3 |
Total Lines | 78 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
149 | function give_get_preview_email_header() { |
||
150 | |||
151 | //Payment receipt switcher |
||
152 | $payment_count = give_count_payments()->publish; |
||
153 | $payment_id = give_check_variable( give_clean( $_GET ), 'isset', 0, 'preview_id' ); |
||
154 | |||
155 | if ( $payment_count <= 0 ) { |
||
156 | return false; |
||
157 | } |
||
158 | |||
159 | //Get payments. |
||
160 | $donations = new Give_Payments_Query( array( |
||
161 | 'number' => 100, |
||
162 | 'output' => '', |
||
163 | 'fields' => 'ids' |
||
164 | ) ); |
||
165 | $donations = $donations->get_payments(); |
||
166 | $options = array(); |
||
167 | |||
168 | // Default option. |
||
169 | $options[0] = esc_html__( 'No donations found.', 'give' ); |
||
170 | |||
171 | //Provide nice human readable options. |
||
172 | if ( $donations ) { |
||
173 | $options[0] = esc_html__( '- Select a donation -', 'give' ); |
||
174 | foreach ( $donations as $donation_id ) { |
||
175 | |||
176 | $options[ $donation_id ] = sprintf( |
||
177 | '#%1$s - %2$s - %3$s', |
||
178 | $donation_id, |
||
179 | give_get_donation_donor_email( $donation_id ), |
||
180 | get_the_title( $donation_id ) |
||
181 | ); |
||
182 | } |
||
183 | } |
||
184 | |||
185 | //Start constructing HTML output. |
||
186 | $transaction_header = '<div style="margin:0;padding:10px 0;width:100%;background-color:#FFF;border-bottom:1px solid #eee; text-align:center;">'; |
||
187 | |||
188 | // Remove payment id query param if set from request url. |
||
189 | $request_url_data = wp_parse_url( $_SERVER['REQUEST_URI'] ); |
||
190 | $query = $request_url_data['query']; |
||
191 | $query = remove_query_arg( array( 'preview_id' ), $query ); |
||
192 | |||
193 | $request_url = home_url( '/?' . str_replace( '', '', $query ) ); |
||
194 | |||
195 | $transaction_header .= '<script> |
||
196 | function change_preview(){ |
||
197 | var transactions = document.getElementById("give_preview_email_payment_id"); |
||
198 | var selected_trans = transactions.options[transactions.selectedIndex]; |
||
199 | if (selected_trans){ |
||
200 | var url_string = "' . $request_url . '&preview_id=" + selected_trans.value; |
||
201 | window.location = url_string; |
||
202 | } |
||
203 | } |
||
204 | </script>'; |
||
205 | |||
206 | $transaction_header .= '<label for="give_preview_email_payment_id" style="font-size:12px;color:#333;margin:0 4px 0 0;">' . esc_html__( 'Preview email with a donation:', 'give' ) . '</label>'; |
||
207 | |||
208 | //The select field with 100 latest transactions |
||
209 | $transaction_header .= Give()->html->select( array( |
||
210 | 'name' => 'preview_email_payment_id', |
||
211 | 'selected' => $payment_id, |
||
212 | 'id' => 'give_preview_email_payment_id', |
||
213 | 'class' => 'give-preview-email-payment-id', |
||
214 | 'options' => $options, |
||
215 | 'chosen' => false, |
||
216 | 'select_atts' => 'onchange="change_preview()"', |
||
217 | 'show_option_all' => false, |
||
218 | 'show_option_none' => false, |
||
219 | ) ); |
||
220 | |||
221 | //Closing tag |
||
222 | $transaction_header .= '</div>'; |
||
223 | |||
224 | return apply_filters( 'give_preview_email_receipt_header', $transaction_header ); |
||
225 | |||
226 | } |
||
227 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.