Conditions | 46 |
Paths | 744 |
Total Lines | 320 |
Lines | 202 |
Ratio | 63.13 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
150 | public function convert_date( $date, $end_date = false ) { |
||
151 | |||
152 | $this->timestamp = false; |
||
153 | $second = $end_date ? 59 : 0; |
||
154 | $minute = $end_date ? 59 : 0; |
||
155 | $hour = $end_date ? 23 : 0; |
||
156 | $day = 1; |
||
157 | $month = date( 'n', current_time( 'timestamp' ) ); |
||
158 | $year = date( 'Y', current_time( 'timestamp' ) ); |
||
159 | |||
160 | if ( array_key_exists( (string) $date, $this->get_predefined_dates() ) ) { |
||
161 | |||
162 | // This is a predefined date rate, such as last_week |
||
163 | switch ( $date ) { |
||
164 | |||
165 | case 'this_month' : |
||
166 | |||
167 | if ( $end_date ) { |
||
168 | |||
169 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
170 | $hour = 23; |
||
171 | $minute = 59; |
||
172 | $second = 59; |
||
173 | } |
||
174 | |||
175 | break; |
||
176 | |||
177 | case 'last_month' : |
||
178 | |||
179 | if ( $month == 1 ) { |
||
180 | |||
181 | $month = 12; |
||
182 | $year --; |
||
183 | |||
184 | } else { |
||
185 | |||
186 | $month --; |
||
187 | |||
188 | } |
||
189 | |||
190 | if ( $end_date ) { |
||
191 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
192 | } |
||
193 | |||
194 | break; |
||
195 | |||
196 | case 'today' : |
||
197 | |||
198 | $day = date( 'd', current_time( 'timestamp' ) ); |
||
199 | |||
200 | if ( $end_date ) { |
||
201 | $hour = 23; |
||
202 | $minute = 59; |
||
203 | $second = 59; |
||
204 | } |
||
205 | |||
206 | break; |
||
207 | |||
208 | case 'yesterday' : |
||
209 | |||
210 | $day = date( 'd', current_time( 'timestamp' ) ) - 1; |
||
211 | |||
212 | // Check if Today is the first day of the month (meaning subtracting one will get us 0) |
||
213 | if ( $day < 1 ) { |
||
214 | |||
215 | // If current month is 1 |
||
216 | if ( 1 == $month ) { |
||
217 | |||
218 | $year -= 1; // Today is January 1, so skip back to last day of December |
||
219 | $month = 12; |
||
220 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
221 | |||
222 | } else { |
||
223 | |||
224 | // Go back one month and get the last day of the month |
||
225 | $month -= 1; |
||
226 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
227 | |||
228 | } |
||
229 | } |
||
230 | |||
231 | break; |
||
232 | |||
233 | View Code Duplication | case 'this_week' : |
|
234 | |||
235 | $days_to_week_start = ( date( 'w', current_time( 'timestamp' ) ) - 1 ) * 60 * 60 * 24; |
||
236 | $today = date( 'j', current_time( 'timestamp' ) ) * 60 * 60 * 24; |
||
237 | |||
238 | if ( $today <= $days_to_week_start ) { |
||
239 | |||
240 | if ( $month > 1 ) { |
||
241 | $month -= 1; |
||
242 | } else { |
||
243 | $month = 12; |
||
244 | } |
||
245 | |||
246 | } |
||
247 | |||
248 | if ( ! $end_date ) { |
||
249 | |||
250 | // Getting the start day |
||
251 | |||
252 | $day = date( 'd', current_time( 'timestamp' ) - $days_to_week_start ) - 1; |
||
253 | $day += get_option( 'start_of_week' ); |
||
254 | |||
255 | } else { |
||
256 | |||
257 | // Getting the end day |
||
258 | |||
259 | $day = date( 'd', current_time( 'timestamp' ) - $days_to_week_start ) - 1; |
||
260 | $day += get_option( 'start_of_week' ) + 6; |
||
261 | |||
262 | } |
||
263 | |||
264 | break; |
||
265 | |||
266 | View Code Duplication | case 'last_week' : |
|
267 | |||
268 | $days_to_week_start = ( date( 'w', current_time( 'timestamp' ) ) - 1 ) * 60 * 60 * 24; |
||
269 | $today = date( 'j', current_time( 'timestamp' ) ) * 60 * 60 * 24; |
||
270 | |||
271 | if ( $today <= $days_to_week_start ) { |
||
272 | |||
273 | if ( $month > 1 ) { |
||
274 | $month -= 1; |
||
275 | } else { |
||
276 | $month = 12; |
||
277 | } |
||
278 | |||
279 | } |
||
280 | |||
281 | if ( ! $end_date ) { |
||
282 | |||
283 | // Getting the start day |
||
284 | |||
285 | $day = date( 'd', current_time( 'timestamp' ) - $days_to_week_start ) - 8; |
||
286 | $day += get_option( 'start_of_week' ); |
||
287 | |||
288 | } else { |
||
289 | |||
290 | // Getting the end day |
||
291 | |||
292 | $day = date( 'd', current_time( 'timestamp' ) - $days_to_week_start ) - 8; |
||
293 | $day += get_option( 'start_of_week' ) + 6; |
||
294 | |||
295 | } |
||
296 | |||
297 | break; |
||
298 | |||
299 | View Code Duplication | case 'this_quarter' : |
|
300 | |||
301 | $month_now = date( 'n', current_time( 'timestamp' ) ); |
||
302 | |||
303 | if ( $month_now <= 3 ) { |
||
304 | |||
305 | if ( ! $end_date ) { |
||
306 | $month = 1; |
||
307 | } else { |
||
308 | $month = 3; |
||
309 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
310 | $hour = 23; |
||
311 | $minute = 59; |
||
312 | $second = 59; |
||
313 | } |
||
314 | |||
315 | } else if ( $month_now <= 6 ) { |
||
316 | |||
317 | if ( ! $end_date ) { |
||
318 | $month = 4; |
||
319 | } else { |
||
320 | $month = 6; |
||
321 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
322 | $hour = 23; |
||
323 | $minute = 59; |
||
324 | $second = 59; |
||
325 | } |
||
326 | |||
327 | } else if ( $month_now <= 9 ) { |
||
328 | |||
329 | if ( ! $end_date ) { |
||
330 | $month = 7; |
||
331 | } else { |
||
332 | $month = 9; |
||
333 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
334 | $hour = 23; |
||
335 | $minute = 59; |
||
336 | $second = 59; |
||
337 | } |
||
338 | |||
339 | } else { |
||
340 | |||
341 | if ( ! $end_date ) { |
||
342 | $month = 10; |
||
343 | } else { |
||
344 | $month = 12; |
||
345 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
346 | $hour = 23; |
||
347 | $minute = 59; |
||
348 | $second = 59; |
||
349 | } |
||
350 | |||
351 | } |
||
352 | |||
353 | break; |
||
354 | |||
355 | View Code Duplication | case 'last_quarter' : |
|
356 | |||
357 | $month_now = date( 'n', current_time( 'timestamp' ) ); |
||
358 | |||
359 | if ( $month_now <= 3 ) { |
||
360 | |||
361 | if ( ! $end_date ) { |
||
362 | $month = 10; |
||
363 | } else { |
||
364 | $year -= 1; |
||
365 | $month = 12; |
||
366 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
367 | $hour = 23; |
||
368 | $minute = 59; |
||
369 | $second = 59; |
||
370 | } |
||
371 | |||
372 | } else if ( $month_now <= 6 ) { |
||
373 | |||
374 | if ( ! $end_date ) { |
||
375 | $month = 1; |
||
376 | } else { |
||
377 | $month = 3; |
||
378 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
379 | $hour = 23; |
||
380 | $minute = 59; |
||
381 | $second = 59; |
||
382 | } |
||
383 | |||
384 | } else if ( $month_now <= 9 ) { |
||
385 | |||
386 | if ( ! $end_date ) { |
||
387 | $month = 4; |
||
388 | } else { |
||
389 | $month = 6; |
||
390 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
391 | $hour = 23; |
||
392 | $minute = 59; |
||
393 | $second = 59; |
||
394 | } |
||
395 | |||
396 | } else { |
||
397 | |||
398 | if ( ! $end_date ) { |
||
399 | $month = 7; |
||
400 | } else { |
||
401 | $month = 9; |
||
402 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
403 | $hour = 23; |
||
404 | $minute = 59; |
||
405 | $second = 59; |
||
406 | } |
||
407 | |||
408 | } |
||
409 | |||
410 | break; |
||
411 | |||
412 | View Code Duplication | case 'this_year' : |
|
413 | |||
414 | if ( ! $end_date ) { |
||
415 | $month = 1; |
||
416 | } else { |
||
417 | $month = 12; |
||
418 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
419 | $hour = 23; |
||
420 | $minute = 59; |
||
421 | $second = 59; |
||
422 | } |
||
423 | |||
424 | break; |
||
425 | |||
426 | View Code Duplication | case 'last_year' : |
|
427 | |||
428 | $year -= 1; |
||
429 | if ( ! $end_date ) { |
||
430 | $month = 1; |
||
431 | } else { |
||
432 | $month = 12; |
||
433 | $day = cal_days_in_month( CAL_GREGORIAN, $month, $year ); |
||
434 | $hour = 23; |
||
435 | $minute = 59; |
||
436 | $second = 59; |
||
437 | } |
||
438 | |||
439 | break; |
||
440 | |||
441 | } |
||
442 | |||
443 | |||
444 | } else if ( is_numeric( $date ) ) { |
||
445 | |||
446 | // return $date unchanged since it is a timestamp |
||
447 | $this->timestamp = true; |
||
448 | |||
449 | } else if ( false !== strtotime( $date ) ) { |
||
450 | |||
451 | $date = strtotime( $date, current_time( 'timestamp' ) ); |
||
452 | $year = date( 'Y', $date ); |
||
453 | $month = date( 'm', $date ); |
||
454 | $day = date( 'd', $date ); |
||
455 | |||
456 | } else { |
||
457 | |||
458 | return new WP_Error( 'invalid_date', esc_html__( 'Improper date provided.', 'give' ) ); |
||
459 | |||
460 | } |
||
461 | |||
462 | if ( false === $this->timestamp ) { |
||
463 | // Create an exact timestamp |
||
464 | $date = mktime( $hour, $minute, $second, $month, $day, $year ); |
||
465 | } |
||
466 | |||
467 | return apply_filters( 'give_stats_date', $date, $end_date, $this ); |
||
468 | |||
469 | } |
||
470 | |||
569 |
Adding a
@return
annotation to a constructor is not recommended, since a constructor does not have a meaningful return value.Please refer to the PHP core documentation on constructors.