imgmongelli / mongicommerce

src/Http/Controllers/shop/ShopPaymentController.php

<?php
namespace Mongi\Mongicommerce\Http\Controllers\shop;

use Stripe\Charge;
use Stripe\Stripe;
use Illuminate\Http\Request;
use Stripe\Exception\CardException;
use Illuminate\Support\Facades\Auth;
use Mongi\Mongicommerce\Models\Cart;
use Mongi\Mongicommerce\Models\Order;
use Illuminate\Support\Facades\Session;
use Stripe\Exception\ApiErrorException;
use Stripe\Exception\RateLimitException;
use Mongi\Mongicommerce\Models\OrderStatus;
use Mongi\Mongicommerce\Models\ProductItem;
use Mongi\Mongicommerce\Models\TypePayment;
use Mongi\Mongicommerce\Models\AdminSetting;
use Stripe\Exception\ApiConnectionException;
use Stripe\Exception\AuthenticationException;
use Stripe\Exception\InvalidRequestException;
use Mongi\Mongicommerce\Http\Controllers\Controller;
use Mongi\Mongicommerce\Models\ProductsOrder;

class ShopPaymentController extends Controller
{
    public function page(){
            $total = session('checkout.total');
            $api_stripe_key = AdminSetting::getStripeApiKey();
            $iban = AdminSetting::getIban();
            return view('mongicommerce.pages.payment',compact('total','api_stripe_key','iban'));
    }

    public function pay(Request $request){

        try {
            $total = session('checkout.total');
            $cost_shipping = session('checkout.shipping_price');

The assignment to $cost_shipping is dead and can be removed.

            $order_weight = session('checkout.total_weight');

The assignment to $order_weight is dead and can be removed.

            $order_id = 0;
            $check_order = Order::orderBy('created_at','desc')->first();
            if(is_null($check_order)){
                $order_id = 1;
            }else{
                $order_id = $check_order->id + 1;
            }
            Stripe::setApiKey(AdminSetting::getStripeApiSecretKey());
            // Use Stripe's library to make requests...
            Charge::create ([
                "amount" => number_format(($total*100) , 0, '', ''),
                "currency" => "eur",
                "source" => $request->stripeToken,
                "description" => "Pagamento ordine N.".$order_id
            ]);

            $note_delivery = session('checkout.note_delivery');
            $get_in_shop_checkbox = session('checkout.get_in_shop_checkbox');

            $order = new Order();
            $order->user_id = Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

            $order->total_price = $total;
            $order->shipping_price = 0;
            $order->order_weight = 0;
            $order->status_id = OrderStatus::IN_PREPARAZIONE;
            $order->note_delivery = $note_delivery;
            $order->payment_type_id = TypePayment::STRIPE;
            $order->pick_up_in_shop = $get_in_shop_checkbox == 'true' ? true : false;
            $order->save();
            //save into order_products

            $products = Cart::where('user_id',Auth::user()->id)->get();
            foreach ($products as $product){
                $order_products = new ProductsOrder();
                $order_products->order_id = $order->id;
                $order_products->product_item_id = $product->product_item_id;
                $order_products->number_products = $product->quantity;
                $order_products->save();

                //scalo quantità prodotti
                $productM = ProductItem::find($product->product_item_id);
                $productM->quantity = $productM->quantity - $product->quantity;
                $productM->save();

            }
            //empty cart
            Cart::emptyCart();
            Session::flash('success', 'Pagamento avvenuto con successo');
            return redirect(route('shop.user.orders'));

        } catch(CardException $e) {

            // Since it's a decline, \Stripe\Exception\CardException will be caught
            $error =  '<h4>'.$e->getError()->message.'</h4><br>';
            $error .= 'Status: ' . $e->getHttpStatus() . '<br>';
            $error .= 'Type is:' . $e->getError()->type . '<br>';
            $error .= 'Code is:' . $e->getError()->code . '<br>';
            // param is '' in this case
            $error .= 'Param is:' . $e->getError()->param . '<br>';

            Session::flash('error', $error);
            return back();
        } catch (RateLimitException $e) {
            // Too many requests made to the API too quickly
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        } catch (InvalidRequestException $e) {
            // Invalid parameters were supplied to Stripe's API
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        } catch (AuthenticationException $e) {
            // Authentication with Stripe's API failed
            // (maybe you changed API keys recently)
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        } catch (ApiConnectionException $e) {
            // Network communication with Stripe failed
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        } catch (ApiErrorException $e) {
            // Display a very generic error to the user, and maybe send
            // yourself an email
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        } catch (Exception $e) {

The type Mongi\Mongicommerce\Http\Controllers\shop\Exception was not found. Did you mean Exception? If so, make sure to prefix the type with \.

            // Something else happened, completely unrelated to Stripe
            $error = $e->getError()->message;
            Session::flash('error', $error);
            return back();
        }

    }

      public function normalPayment(Request $r){
        $type = $r->get('type_payment');
        switch ($type){
            case 'iban':
                $typePayment = TypePayment::BONIFICO;
                $orderStatus = OrderStatus::ATTESA_PAGAMENTO;
                break;
            case 'negozio':
                $typePayment = TypePayment::IN_NEGOZIO;
                $orderStatus = OrderStatus::ATTESA_PAGAMENTO;
                break;
        }

        $total = session('checkout.total');
        $cost_shipping = session('checkout.shipping_price');

The assignment to $cost_shipping is dead and can be removed.

        $order_weight = session('checkout.total_weight');

The assignment to $order_weight is dead and can be removed.

        $note_delivery = session('checkout.note_delivery');
        $get_in_shop_checkbox = session('checkout.get_in_shop_checkbox');

        $order = new Order();
        $order->user_id = Auth::user()->id;

Accessing id on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        $order->total_price = $total;
        $order->shipping_price = 0;
        $order->order_weight = 0;
        $order->status_id = $orderStatus;

The variable $orderStatus does not seem to be defined for all execution paths leading up to this point.

        $order->note_delivery = $note_delivery;
        $order->payment_type_id = $typePayment;

The variable $typePayment does not seem to be defined for all execution paths leading up to this point.

        $order->pick_up_in_shop = $get_in_shop_checkbox == 'true' ? true : false;
        $order->save();

        //save into order_products

        $products = Cart::where('user_id',Auth::user()->id)->get();
        foreach ($products as $product){
            $order_products = new ProductsOrder();
            $order_products->order_id = $order->id;
            $order_products->product_item_id = $product->product_item_id;
            $order_products->number_products = $product->quantity;
            $order_products->save();

            //scalo quantità prodotti
            $productM = ProductItem::find($product->product_item_id);
            $productM->quantity = $productM->quantity - $product->quantity;
            $productM->save();

        }
        //empty cart
        Cart::emptyCart();
        Session::flash('success', 'Ordine inoltrato con successo');
        return response()->json(['url'=>route('shop.user.orders')]);

    }
}