AdminShowDetailController::generateDetailHtml() - Code Metrics - Inspection of "showed up details in page" - imgmongelli/mongicommerce - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( ccdc18...c3c113 )

by Gianluca

created 2020-12-17 21:38 UTC

AdminShowDetailController::generateDetailHtml() A

↳ Parent: AdminShowDetailController

Complexity

Conditions	5
Paths	5

Size

Total Lines	22
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	16
dl	0
loc	22
rs	9.4222
c	1
b	0
f	0
cc	5
nc	5
nop	2

<?php


namespace Mongi\Mongicommerce\Http\Controllers\admin;

use Illuminate\Http\Request;
use Mongi\Mongicommerce\Http\Controllers\Controller;
use Mongi\Mongicommerce\Models\Detail;
use Mongi\Mongicommerce\Models\DetailValue;

class AdminShowDetailController extends Controller
{
    public function page(){
        return view('mongicommerce::admin.pages.details.show_details');
    }

    public function getDetails(Request $r){
        $category_id = $r->get('category_id');
        $details = Detail::where('category_id',$category_id)->get();
        $d = [];
        foreach ($details as $detail){
            $d[] = [
                'name' => $detail->name,
                'type' => $detail->type,
                'values' => $detail->values,
                'html' => $this->generateDetailHtml($detail->type,$detail->values)
            ];
        }

        return response()->json($d);

    }

    public function generateDetailHtml($type,$values){
        if($type === 'select'){
            $html = '';
            $html .= '<select class="form-control">';
            $html .= '<option value="">Seleziona</option>';
            foreach($values as $value){
                $html .= '<option value="'.$value->id.'">'.$value->value.'</option>';
            }
            $html .= '</select>';
            return $html;
        }
        if($type === 'checkbox'){
            $html = '';

            foreach($values as $value){
                $html .= '<div class="custom-control custom-checkbox">';
                $html .= '<input type="checkbox" class="custom-control-input" id="defaultUnchecked_'.$value->id.'">';
                $html .= '<label class="custom-control-label" for="defaultUnchecked_'.$value->id.'">'.$value->value.'</label>';
                $html .= '</div>';
            }

            return $html;
        }
    }

}


1			<?php
2
3
4			namespace Mongi\Mongicommerce\Http\Controllers\admin;
5
6			use Illuminate\Http\Request;
7			use Mongi\Mongicommerce\Http\Controllers\Controller;
8			use Mongi\Mongicommerce\Models\Detail;
9			use Mongi\Mongicommerce\Models\DetailValue;
10
11			class AdminShowDetailController extends Controller
12			{
13			public function page(){
14			return view('mongicommerce::admin.pages.details.show_details');
15			}
16
17			public function getDetails(Request $r){
18			$category_id = $r->get('category_id');
19			$details = Detail::where('category_id',$category_id)->get();
20			$d = [];
21			foreach ($details as $detail){
22			$d[] = [
23			'name' => $detail->name,
24			'type' => $detail->type,
25			'values' => $detail->values,
26			'html' => $this->generateDetailHtml($detail->type,$detail->values)
27			];
28			}
29
30			return response()->json($d);
31
32			}
33
34			public function generateDetailHtml($type,$values){
35			if($type === 'select'){
36			$html = '';
37			$html .= '<select class="form-control">';
38			$html .= '<option value="">Seleziona</option>';
39			foreach($values as $value){
40			$html .= '<option value="'.$value->id.'">'.$value->value.'</option>';
41			}
42			$html .= '</select>';
43			return $html;
44			}
45			if($type === 'checkbox'){
46			$html = '';
47
48			foreach($values as $value){
49			$html .= '<div class="custom-control custom-checkbox">';
50			$html .= '<input type="checkbox" class="custom-control-input" id="defaultUnchecked_'.$value->id.'">';
51			$html .= '<label class="custom-control-label" for="defaultUnchecked_'.$value->id.'">'.$value->value.'</label>';
52			$html .= '</div>';
53			}
54
55			return $html;
56			}
57			}
58
59			}
60

imgmongelli / mongicommerce

Push — master ( ccdc18...c3c113 )

AdminShowDetailController::generateDetailHtml() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like