Imgix_Options_page::imgix_options_page() - Code Metrics - Inspection of "Move code into classes" - imgix-wordpress/images-via-imgix - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Rasmus

created 2017-01-31 16:13 UTC

Imgix_Options_page::imgix_options_page() A

↳ Parent: Imgix_Options_page

Complexity

Conditions	1
Paths	1

Size

Total Lines	64
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	18
nc	1
nop	0
dl	0
loc	64
rs	9.3956
c	0
b	0
f	0

How to fix Long Method

<?php

class Imgix_Options_page {

	/**
	 * The instance of the class.
	 *
	 * @var Imgix_Options_page
	 */
	protected static $instance;

	/**
	 * Plugin options
	 *
	 * @var array
	 */
	protected $options = [];


	public function __construct() {
		$this->options = get_option( 'imgix_settings', [] );
		add_action( 'admin_init', [ $this, 'imgix_register_settings' ] );
		add_action( 'admin_menu', [ $this, 'imgix_add_options_link' ] );
	}

	/**
	 * Plugin loader instance.
	 *
	 * @return Imgix_Options_page
	 */
	public static function instance() {
		if ( ! isset( self::$instance ) ) {
			self::$instance = new self;
		}

		return self::$instance;
	}

	/**
	 * Renders options page
	 */
	public function imgix_options_page() {
		?>
		<div class="wrap">

			<h1>
				<img src="<?php echo plugins_url( 'assets/images/imgix-logo.png', __DIR__ ); ?>" alt="imgix Logo">
			</h1>

			<p><strong>Need help getting started?</strong> It's easy! Check out our
				<a href="https://github.com/imgix-wordpress/imgix-wordpress#getting-started" target="_blank">instructions.</a>
			</p>

			<form method="post" action="<?php echo admin_url( 'options.php' ); ?>">
				<?php settings_fields( 'imgix_settings_group' ); ?>
				<table class="form-table">
					<tbody>
						<tr>
							<th>
								<label class="description" for="imgix_settings[cdn_link]"><?php esc_html_e( 'imgix Source', 'imgix' ); ?>
							</th>
							<td>
								<input id="imgix_settings[cdn_link]" type="url" name="imgix_settings[cdn_link]" placeholder="https://yourcompany.imgix.net" value="<?php echo $this->get_option( 'cdn_link' ); ?>" class="regular-text code"/>
							</td>
						</tr>
						<tr>
							<th>
								<label class="description" for="imgix_settings[auto_format]"><?php esc_html_e( 'Auto Format Images', 'imgix' ); ?></label>
							</th>
							<td>
								<input id="imgix_settings[auto_format]" type="checkbox" name="imgix_settings[auto_format]" value="1" <?php checked( $this->get_option( 'auto_format' ) ) ?> />
							</td>
						</tr>
						<tr>
							<th>
								<label class="description" for="imgix_settings[auto_enhance]"><?php esc_html_e( 'Auto Enhance Images', 'imgix' ); ?></label>
							</th>
							<td>
								<input id="imgix_settings[auto_enhance]" type="checkbox" name="imgix_settings[auto_enhance]" value="1" <?php checked( $this->get_option( 'auto_enhance' ) ) ?> />
							</td>
						</tr>
						<tr>
							<th>
								<label class="description" for="imgix_settings[add_dpi2_srcset]"><?php esc_html_e( 'Automatically add retina images using srcset', 'imgix' ); ?></label>
							</th>
							<td>
								<input id="imgix_settings[add_dpi2_srcset]" type="checkbox" name="imgix_settings[add_dpi2_srcset]" value="1" <?php checked( $this->get_option( 'add_dpi2_srcset' ) ) ?> />
							</td>
						</tr>
					</tbody>
				</table>

				<p class="submit">
					<input type="submit" class="button-primary" value="<?php esc_html_e( 'Save Options', 'imgix' ); ?>"/>
				</p>
			</form>

			<p class="description">
				This plugin is powered by
				<a href="http://www.imgix.com" target="_blank">imgix</a>. You can find and contribute to the code on
				<a href="https://github.com/imgix-wordpress/images-via-imgix" target="_blank">GitHub</a>.
			</p>
		</div>
		<?php
	}

	/**
	 *  Adds link to options page in Admin > Settings menu.
	 */
	public function imgix_add_options_link() {
		add_options_page( 'imgix', 'imgix', 'manage_options', 'imgix-options', [ $this, 'imgix_options_page' ] );
	}

	/**
	 *  Creates our settings in the options table.
	 */
	public function imgix_register_settings() {
		register_setting( 'imgix_settings_group', 'imgix_settings' );
	}

	/**
	 * Get option and handle if option is not set
	 *
	 * @param string $key
	 *
	 * @return mixed
	 */
	protected function get_option( $key ) {
		return isset( $this->options[ $key ] ) ? $this->options[ $key ] : '';
	}
}

Imgix_Options_page::instance();


1			<?php
2
3			class Imgix_Options_page {
4
5			/**
6			* The instance of the class.
7			*
8			* @var Imgix_Options_page
9			*/
10			protected static $instance;
11
12			/**
13			* Plugin options
14			*
15			* @var array
16			*/
17			protected $options = [];
18
19
20			public function __construct() {
21			$this->options = get_option( 'imgix_settings', [] );
22			add_action( 'admin_init', [ $this, 'imgix_register_settings' ] );
23			add_action( 'admin_menu', [ $this, 'imgix_add_options_link' ] );
24			}
25
26			/**
27			* Plugin loader instance.
28			*
29			* @return Imgix_Options_page
30			*/
31			public static function instance() {
32			if ( ! isset( self::$instance ) ) {
33			self::$instance = new self;
34			}
35
36			return self::$instance;
37			}
38
39			/**
40			* Renders options page
41			*/
42			public function imgix_options_page() {
43			?>
44			<div class="wrap">
45
46			<h1>
47			<img src="<?php echo plugins_url( 'assets/images/imgix-logo.png', __DIR__ ); ?>" alt="imgix Logo">
48			</h1>
49
50			<p><strong>Need help getting started?</strong> It's easy! Check out our
51			<a href="https://github.com/imgix-wordpress/imgix-wordpress#getting-started" target="_blank">instructions.</a>
52			</p>
53
54			<form method="post" action="<?php echo admin_url( 'options.php' ); ?>">
55			<?php settings_fields( 'imgix_settings_group' ); ?>
56			<table class="form-table">
57			<tbody>
58			<tr>
59			<th>
60			<label class="description" for="imgix_settings[cdn_link]"><?php esc_html_e( 'imgix Source', 'imgix' ); ?>
61			</th>
62			<td>
63			<input id="imgix_settings[cdn_link]" type="url" name="imgix_settings[cdn_link]" placeholder="https://yourcompany.imgix.net" value="<?php echo $this->get_option( 'cdn_link' ); ?>" class="regular-text code"/>
64			</td>
65			</tr>
66			<tr>
67			<th>
68			<label class="description" for="imgix_settings[auto_format]"><?php esc_html_e( 'Auto Format Images', 'imgix' ); ?></label>
69			</th>
70			<td>
71			<input id="imgix_settings[auto_format]" type="checkbox" name="imgix_settings[auto_format]" value="1" <?php checked( $this->get_option( 'auto_format' ) ) ?> />
72			</td>
73			</tr>
74			<tr>
75			<th>
76			<label class="description" for="imgix_settings[auto_enhance]"><?php esc_html_e( 'Auto Enhance Images', 'imgix' ); ?></label>
77			</th>
78			<td>
79			<input id="imgix_settings[auto_enhance]" type="checkbox" name="imgix_settings[auto_enhance]" value="1" <?php checked( $this->get_option( 'auto_enhance' ) ) ?> />
80			</td>
81			</tr>
82			<tr>
83			<th>
84			<label class="description" for="imgix_settings[add_dpi2_srcset]"><?php esc_html_e( 'Automatically add retina images using srcset', 'imgix' ); ?></label>
85			</th>
86			<td>
87			<input id="imgix_settings[add_dpi2_srcset]" type="checkbox" name="imgix_settings[add_dpi2_srcset]" value="1" <?php checked( $this->get_option( 'add_dpi2_srcset' ) ) ?> />
88			</td>
89			</tr>
90			</tbody>
91			</table>
92
93			<p class="submit">
94			<input type="submit" class="button-primary" value="<?php esc_html_e( 'Save Options', 'imgix' ); ?>"/>
95			</p>
96			</form>
97
98			<p class="description">
99			This plugin is powered by
100			<a href="http://www.imgix.com" target="_blank">imgix</a>. You can find and contribute to the code on
101			<a href="https://github.com/imgix-wordpress/images-via-imgix" target="_blank">GitHub</a>.
102			</p>
103			</div>
104			<?php
105			}
106
107			/**
108			* Adds link to options page in Admin > Settings menu.
109			*/
110			public function imgix_add_options_link() {
111			add_options_page( 'imgix', 'imgix', 'manage_options', 'imgix-options', [ $this, 'imgix_options_page' ] );
112			}
113
114			/**
115			* Creates our settings in the options table.
116			*/
117			public function imgix_register_settings() {
118			register_setting( 'imgix_settings_group', 'imgix_settings' );
119			}
120
121			/**
122			* Get option and handle if option is not set
123			*
124			* @param string $key
125			*
126			* @return mixed
127			*/
128			protected function get_option( $key ) {
129			return isset( $this->options[ $key ] ) ? $this->options[ $key ] : '';
130			}
131			}
132
133			Imgix_Options_page::instance();
134

imgix-wordpress / images-via-imgix

Pull Request — master (#16)

Imgix_Options_page::imgix_options_page() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like