imgix-wordpress /
images-via-imgix
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Images_Via_Imgix often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Images_Via_Imgix, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 3 | class Images_Via_Imgix { |
||
| 4 | |||
| 5 | /** |
||
| 6 | * The instance of the class. |
||
| 7 | * |
||
| 8 | * @var Images_Via_Imgix |
||
| 9 | */ |
||
| 10 | protected static $instance; |
||
| 11 | |||
| 12 | /** |
||
| 13 | * Plugin options |
||
| 14 | * |
||
| 15 | * @var array |
||
| 16 | */ |
||
| 17 | protected $options = []; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Buffer is started by plugin and should be ended on shutdown. |
||
| 21 | * |
||
| 22 | * @var bool |
||
| 23 | */ |
||
| 24 | protected $buffer_started = false; |
||
| 25 | |||
| 26 | /** |
||
| 27 | * ImagesViaImgix constructor. |
||
| 28 | */ |
||
| 29 | public function __construct() { |
||
| 46 | |||
| 47 | /** |
||
| 48 | * Plugin loader instance. |
||
| 49 | * |
||
| 50 | * @return Images_Via_Imgix |
||
| 51 | */ |
||
| 52 | public static function instance() { |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Override options from settings. |
||
| 62 | * Used in unit tests. |
||
| 63 | * |
||
| 64 | * @param array $options |
||
| 65 | */ |
||
| 66 | public function set_options( $options ) { |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Find all img tags with sources matching "imgix.net" without the parameter |
||
| 72 | * "srcset" and add the "srcset" parameter to all those images, appending a new |
||
| 73 | * source using the "dpr=2" modifier. |
||
| 74 | * |
||
| 75 | * @param $content |
||
| 76 | * |
||
| 77 | * @return string Content with retina-enriched image tags. |
||
| 78 | */ |
||
| 79 | public function add_retina( $content ) { |
||
| 87 | |||
| 88 | /** |
||
| 89 | * Modify image urls for attachments to use imgix host. |
||
| 90 | * |
||
| 91 | * @param string $url |
||
| 92 | * |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function replace_image_url( $url ) { |
||
| 127 | |||
| 128 | /** |
||
| 129 | * Set params when running image_downsize |
||
| 130 | * |
||
| 131 | * @param false|array $return |
||
| 132 | * @param int $attachment_id |
||
| 133 | * @param string|array $size |
||
| 134 | * |
||
| 135 | * @return false|array |
||
| 136 | */ |
||
| 137 | public function image_downsize( $return, $attachment_id, $size ) { |
||
| 170 | |||
| 171 | /** |
||
| 172 | * Change url for images in srcset |
||
| 173 | * |
||
| 174 | * @param array $sources |
||
| 175 | * @param array $size_array |
||
| 176 | * @param string $image_src |
||
| 177 | * @param array $image_meta |
||
| 178 | * @param int $attachment_id |
||
| 179 | * |
||
| 180 | * @return array |
||
| 181 | */ |
||
| 182 | public function calculate_image_srcset( $sources, $size_array, $image_src, $image_meta, $attachment_id ) { |
||
| 198 | |||
| 199 | /** |
||
| 200 | * Modify image urls in content to use imgix host. |
||
| 201 | * |
||
| 202 | * @param $content |
||
| 203 | * |
||
| 204 | * @return string |
||
| 205 | */ |
||
| 206 | public function replace_images_in_content( $content ) { |
||
| 234 | |||
| 235 | /** |
||
| 236 | * Add tag to dns prefetch cdn host |
||
| 237 | */ |
||
| 238 | public function prefetch_cdn() { |
||
| 248 | |||
| 249 | /** |
||
| 250 | * Start output buffer if auto retina is enabled |
||
| 251 | */ |
||
| 252 | public function buffer_start_for_retina() { |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Stop output buffer if it was enabled by the plugin |
||
| 261 | */ |
||
| 262 | public function buffer_end_for_retina() { |
||
| 267 | |||
| 268 | /** |
||
| 269 | * Returns a array of global parameters to be applied in all images, |
||
| 270 | * according to plugin's settings. |
||
| 271 | * |
||
| 272 | * @return array Global parameters to be appened at the end of each img URL. |
||
| 273 | */ |
||
| 274 | protected function get_global_params() { |
||
| 297 | |||
| 298 | /** |
||
| 299 | * Get all defined image sizes |
||
| 300 | * |
||
| 301 | * @return array |
||
| 302 | */ |
||
| 303 | protected function get_all_defined_sizes() { |
||
| 325 | } |
||
| 326 | |||
| 328 |
Loading history...
This check looks for type mismatches where the missing type is
false. This is usually indicative of an error condtion.Consider the follow example
This function either returns a new
DateTimeobject or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returnedfalsebefore passing on the value to another function or method that may not be able to handle afalse.