Imedia\Ammit\UI\Resolver\Validator\PragmaticRawValueValidator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	105
Duplicated Lines	19.05 %

Coupling/Cohesion

Components	1
Dependencies	6

Test Coverage

Coverage

57.69%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	mustHaveLengthBetween()	0	17	2
A	mustBeStringNotEmpty()	0	15	2
A	mustBeEmailAddress()	0	16	3
A	mustBeValidAgainstRegex()	20	20	4

<?php
declare(strict_types = 1);

namespace Imedia\Ammit\UI\Resolver\Validator;

use Assert\Assertion;
use Assert\InvalidArgumentException;
use Imedia\Ammit\Domain\MailMxValidation;
use Imedia\Ammit\UI\Resolver\Validator\Implementation\Pragmatic\UuidValidatorTrait;

/**
 * @internal Contains Domain Validation assertions (but class won't be removed in next version)
 *   Domain Validation should be done in Domain
 *   Should be used for prototyping project knowing you are accumulating technical debt
 *
 * @author Guillaume MOREL <g.morel@imediafrance.fr>
 */
class PragmaticRawValueValidator extends RawValueValidator
{
    use UuidValidatorTrait;

    /**
     * Domain should be responsible for id format
     * Exceptions are caught in order to be processed later
     * @param mixed $value String ?
     *
     * @return mixed Untouched value
     */
    public function mustHaveLengthBetween($value, int $min, int $max, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $min, $max, $propertyPath, $exceptionMessage) {
                Assertion::betweenLength(
                    $value,
                    $min,
                    $max,
                    $exceptionMessage,
                    $propertyPath
                );
            }
        );

        return $value;
    }

    /**
     * Domain should be responsible for string emptiness
     * Exceptions are caught in order to be processed later
     * @param mixed $value String not empty ?
     *
     * @return mixed Untouched value
     */
    public function mustBeStringNotEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {
                Assertion::notEmpty(
                    $value,
                    $exceptionMessage,
                    $propertyPath
                );
            }
        );

        return $value;
    }

    /**
     * Domain should be responsible for email format
     * Exceptions are caught in order to be processed later
     * @param mixed $value Email ?
     *
     * @return mixed Untouched value
     */
    public function mustBeEmailAddress($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)
    {
        $mailMxValidation = new MailMxValidation();
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage, $mailMxValidation) {
                Assertion::true(
                    $mailMxValidation->isEmailFormatValid($value) && $mailMxValidation->isEmailHostValid($value),
                    $exceptionMessage,
                    $propertyPath
                );
            }
        );

        return $value;
    }

    /**
     * Domain should be responsible for regex validation
     * Exceptions are caught in order to be processed later
     * @param mixed  $value   Valid against Regex ?
     * @param string $pattern Regex
     *
     * @return mixed Untouched value
     */
    public function mustBeValidAgainstRegex($value, string $pattern, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

This method seems to be duplicated in your project.

    {
        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $pattern, $propertyPath, $exceptionMessage) {
                if (preg_match($pattern, $value)) {

This if statement is empty and can be removed.

                } else {
                    throw new InvalidArgumentException(
                        $exceptionMessage ?: sprintf('Value "%s" not valid against regex "%s".', $value, $pattern),
                        0,
                        $propertyPath,
                        $value
                    );
                }
            }
        );

        return $value;
    }
}