Imedia\Ammit\UI\Resolver\Validator\Implementation\Pure\IntegerValidatorTrait

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	12.9 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

73.68%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	mustBeInteger()	0	35	6
A	mustBeIntegerOrEmpty()	8	8	2

<?php

namespace Imedia\Ammit\UI\Resolver\Validator\Implementation\Pure;

use Imedia\Ammit\UI\Resolver\Validator\InvalidArgumentException;
use Imedia\Ammit\UI\Resolver\UIValidationEngine;
use Imedia\Ammit\UI\Resolver\Validator\UIValidatorInterface;

/**
 * @author Guillaume MOREL <g.morel@imediafrance.fr>
 */
trait IntegerValidatorTrait
{
    /** @var UIValidationEngine */
    protected $validationEngine;

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Integer ?
     *
     * @return int|null Value casted into int or -1 or null
     */
    public function mustBeIntegerOrEmpty($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null)

This method seems to be duplicated in your project.

    {
        if ($value === '') {
            return null;
        }

        return $this->mustBeInteger($value, $propertyPath, $parentValidator, $exceptionMessage);
    }

    /**
     * Exceptions are caught in order to be processed later
     * @param mixed $value Integer ?
     *
     * @return int Value casted into int or -1
     */
    public function mustBeInteger($value, string $propertyPath = null, UIValidatorInterface $parentValidator = null, string $exceptionMessage = null): int
    {
        if (is_numeric($value)) {
            $value = (int) $value;
        }

        $this->validationEngine->validateFieldValue(
            $parentValidator ?: $this,
            function() use ($value, $propertyPath, $exceptionMessage) {
                if (is_int($value)) {
                    return;
                }

                if (null === $exceptionMessage) {
                    $exceptionMessage = sprintf(

Consider using a different name than the imported variable $exceptionMessage, or did you forget to import by reference?

                        'Value "%s" is not an integer.',
                        $value
                    );
                }

                throw new InvalidArgumentException(
                    $exceptionMessage,
                    0,
                    $propertyPath,
                    $value
                );
            }
        );

        if (!is_int($value)) {
            return -1;
        }

        return $value;
    }
}