imanghafoori1 / laravel-widgetize

src/Utils/WidgetJsonifier.php

<?php

namespace Imanghafoori\Widgets\Utils;

use Illuminate\Contracts\Debug\ExceptionHandler;

class WidgetJsonifier
{
    /**
     * @param $widget object|string
     * @param  array  $args
     * @return string
     */
    public function jsonResponse($widget, ...$args)
    {
        if (is_string($widget)) {
            $widget = $this->makeWidgetObj($widget);
        }

        app(Normalizer::class)->normalizeWidgetConfig($widget);

        try {
            $json = $this->generateJson($widget, ...$args);
        } catch (\Exception $e) {
            return app()->make(ExceptionHandler::class)->render(app('request'), $e)->send();
        }

        return $json;
    }

    /**
     * @param $widget string
     * @return object
     */
    private function makeWidgetObj(string $widget)
    {
        $widget = app()->getNamespace().'Widgets\\'.$widget;

The method getNamespace() does not exist on Illuminate\Container\Container. Are you sure you never get this type here, but always one of the subclasses?

        return app($widget);
    }

    /**
     * It tries to get the html from cache if possible, otherwise generates it.
     *
     * @param $widget object
     * @param  array  ...$args
     * @return string
     */
    private function generateJson($widget, ...$args)
    {
        // Everything inside this function is executed only when the cache is not available.
        $expensivePhpCode = function () use ($widget, $args) {
            $data = \App::call($widget->controller, ...$args);

$args is expanded, but the parameter $parameters of Illuminate\Foundation\Application::call() does not expect variable arguments.

            // render the template with the resulting data.
            return response()->json($data, 200);
        };

        // We first try to get the output from the cache before trying to run the expensive $expensivePhpCode...
        if (app(Policies::class)->widgetShouldUseCache()) {
            return app(Cache::class)->cacheResult($args, $expensivePhpCode, $widget, 'json');

Are you sure the usage of app(Imanghafoori\Widgets\Utils\Cache::class)->cacheResult($args, $expensivePhpCode, $widget, 'json') targeting Imanghafoori\Widgets\Utils\Cache::cacheResult() seems to always return null.

        }

        return $expensivePhpCode();
    }
}