Normalizer::checkDataMethodExists() - Code Metrics - Inspection of "refactoring normalizer class" - imanghafoori1/laravel-widgetize - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fbc7c8...750795 )

by Iman

created 2017-03-31 00:52 UTC

Normalizer::checkDataMethodExists() A

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	3
nc	2
nop	1

<?php

namespace Imanghafoori\Widgets\Utils;

use Imanghafoori\Widgets\BaseWidget;
use Imanghafoori\Widgets\Utils\Normalizers\CacheNormalizer;
use Imanghafoori\Widgets\Utils\Normalizers\ControllerNormalizer;
use Imanghafoori\Widgets\Utils\Normalizers\PresenterNormalizer;
use Imanghafoori\Widgets\Utils\Normalizers\TemplateNormalizer;

class Normalizer
{
    private $widget;
    private $presenterNormalizer;
    private $templateNormalizer;

    /**
     * Normalizer constructor.
     * @param TemplateNormalizer $templateNormalizer
     * @param CacheNormalizer $cacheNormalizer
     * @param PresenterNormalizer $presenterNormalizer
     * @param ControllerNormalizer $controllerNormalizer
     * @internal param $widget
     */
    public function __construct(TemplateNormalizer $templateNormalizer, CacheNormalizer $cacheNormalizer, PresenterNormalizer $presenterNormalizer, ControllerNormalizer $controllerNormalizer)
    {
        $this->presenterNormalizer = $presenterNormalizer;
        $this->controllerNormalizer = $controllerNormalizer;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->templateNormalizer = $templateNormalizer;
        $this->cacheNormalizer = $cacheNormalizer;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }


    public function normalizeWidgetConfig(BaseWidget $widget)
    {
        // to avoid normalizing a widget multiple times unnecessarily :
        if (isset($widget->isNormalized)) {
            return null;
        }

        $this->widget = $widget;
        $this->controllerNormalizer->normalizeControllerMethod($widget);
        $this->presenterNormalizer->normalizePresenterName($widget);
        $this->templateNormalizer->normalizeTemplateName($widget);
        $this->cacheNormalizer->normalizeCacheLifeTime($widget);
        $this->cacheNormalizer->normalizeCacheTags($widget);
        $this->normalizeContextAs();
        $widget->isNormalized = true;

    }

    /**
     * Figures out what the variable name should be in view file.
     * @return null
     */
    private function normalizeContextAs()
    {
        // removes the $ sign.
        $this->widget->contextAs = str_replace('$', '', (string)$this->widget->contextAs);
    }
}


1			<?php
2
3			namespace Imanghafoori\Widgets\Utils;
4
5			use Imanghafoori\Widgets\BaseWidget;
6			use Imanghafoori\Widgets\Utils\Normalizers\CacheNormalizer;
7			use Imanghafoori\Widgets\Utils\Normalizers\ControllerNormalizer;
8			use Imanghafoori\Widgets\Utils\Normalizers\PresenterNormalizer;
9			use Imanghafoori\Widgets\Utils\Normalizers\TemplateNormalizer;
10
11			class Normalizer
12			{
13			private $widget;
14			private $presenterNormalizer;
15			private $templateNormalizer;
16
17			/**
18			* Normalizer constructor.
19			* @param TemplateNormalizer $templateNormalizer
20			* @param CacheNormalizer $cacheNormalizer
21			* @param PresenterNormalizer $presenterNormalizer
22			* @param ControllerNormalizer $controllerNormalizer
23			* @internal param $widget
24			*/
25			public function __construct(TemplateNormalizer $templateNormalizer, CacheNormalizer $cacheNormalizer, PresenterNormalizer $presenterNormalizer, ControllerNormalizer $controllerNormalizer)
26			{
27			$this->presenterNormalizer = $presenterNormalizer;
28			$this->controllerNormalizer = $controllerNormalizer;
			0 ignored issues – show Bug introduced 2017-03-31 00:54 UTC by Report Bug Copy Issue Report The property `controllerNormalizer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29			$this->templateNormalizer = $templateNormalizer;
30			$this->cacheNormalizer = $cacheNormalizer;
			0 ignored issues – show Bug introduced 2017-03-31 00:54 UTC by Report Bug Copy Issue Report The property `cacheNormalizer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31			}
32
33
34			public function normalizeWidgetConfig(BaseWidget $widget)
35			{
36			// to avoid normalizing a widget multiple times unnecessarily :
37			if (isset($widget->isNormalized)) {
38			return null;
39			}
40
41			$this->widget = $widget;
42			$this->controllerNormalizer->normalizeControllerMethod($widget);
43			$this->presenterNormalizer->normalizePresenterName($widget);
44			$this->templateNormalizer->normalizeTemplateName($widget);
45			$this->cacheNormalizer->normalizeCacheLifeTime($widget);
46			$this->cacheNormalizer->normalizeCacheTags($widget);
47			$this->normalizeContextAs();
48			$widget->isNormalized = true;
			0 ignored issues – show Bug introduced 2017-03-29 12:40 UTC by Report Bug Copy Issue Report The property `isNormalized` does not seem to exist in `Imanghafoori\Widgets\BaseWidget`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
49			}
50
51			/**
52			* Figures out what the variable name should be in view file.
53			* @return null
54			*/
55			private function normalizeContextAs()
56			{
57			// removes the $ sign.
58			$this->widget->contextAs = str_replace('$', '', (string)$this->widget->contextAs);
59			}
60			}
61

imanghafoori1 / laravel-widgetize

Push — master ( fbc7c8...750795 )

Normalizer::checkDataMethodExists() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like