imanghafoori1 / laravel-widgetize

src/Utils/Normalizers/CacheTagsNormalizer.php

<?php

namespace Imanghafoori\Widgets\Utils\Normalizers;

use Imanghafoori\Widgets\Utils\NormalizerContract;

class CacheTagsNormalizer implements NormalizerContract
{
    /**
     * ّFigures out what the cache tags should be.
     * @param object $widget
     * @return void
     */
    public function normalize($widget): void
    {
        if (! property_exists($widget, 'cacheTags')) {
            $widget->cacheTags = [];
        } elseif (is_array($widget->cacheTags)) {
            $this->checkTagForString($widget);
        } else {
            $this->errorOut($widget);
        }
    }

    /**
     * @param $widget
     * @param null $tag

Are you sure the doc-type for parameter $tag is correct as it would always require null to be passed?

     */
    private function errorOut($widget, $tag = null): void
    {
        $tag = $tag ? ' '.$tag.'is not string' : '';

$tag is of type null, thus it always evaluated to false.

        throw new \InvalidArgumentException('Cache Tags on "'.get_class($widget).'" must be of type Array with String elements.'.$tag);
    }

    /**
     * @param $widget
     */
    protected function checkTagForString($widget): void
    {
        foreach ($widget->cacheTags as $tag) {
            if (! is_string($tag)) {
                $this->errorOut($widget);
            }
        }
    }
}