Expander::expendReferences() - Code Metrics - Inspection of "More tests" - imanghafoori1/laravel-microscope - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 30255f...a24543 )

by Iman

created 2021-06-05 20:03 UTC

Expander::expendReferences() C

↳ Parent: Expander

Complexity

Conditions	16
Paths	27

Size

Total Lines

Duplication

Lines	6
Ratio	9.09 %

Importance

Changes

Metric	Value
cc	16
nc	27
nop	2
dl	6
loc	66
rs	5.5666
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Imanghafoori\LaravelMicroscope\Analyzers;

use Illuminate\Support\Str;

class Expander
{
    /**
     * @param  string  $type
     *
     * @return bool
     */
    public static function isBuiltinType($type)
    {
        return \in_array(strtolower($type), [
            'self',
            'static',
            'parent',
        ], true);
    }

    public static function expendReferences($classes, $imports)
    {
        // here we implode the tokens to form the full namespaced class path
        $results = [];
        $namespace = '';
        $c = 0;
        foreach ($classes as $importeds) {
            if ($importeds[0][0] == T_NAMESPACE) {
                unset($importeds[0]);
                foreach ($importeds as $row) {
                    $namespace .= $row[1];
                }
                continue;
            }

            $results[$c]['class'] = '';

            // attach the current namespace if it does not begin with '\'
            if ($importeds[0][1][0] != '\\') {
                $results[$c]['class'] = $namespace ? $namespace.'\\' : '';
            }

            foreach ($importeds as $row) {
                if (self::isBuiltinType($row[1])) {
                    unset($results[$c]);
                    continue;
                }

                // if starts with "\" or is not imported by the "use"
                if ($importeds[0][1][0] != '\\' && Str::contains($importeds[0][1], '\\')) {
                    // for php 8.x
                    $tmp = explode('\\', $importeds[0][1]);
                } else {
                    $tmp = [$importeds[0][1]];
                }

                if ($importeds[0][1] == '\\' || ! isset(array_values($imports)[0][$tmp[0]][0])) {
                    $results[$c]['class'] .= $row[1];
                    $results[$c]['line'] = $row[2];
                    continue;
                }

                // reads the import from the top
                $results[$c]['class'] = array_values($imports)[0][$tmp[0]][0];

                // for half imported references
                if ($importeds[0][1][0] != '\\' && Str::contains($importeds[0][1], '\\')) {
                    // for php 8.x
                    $tmp = explode('\\', $importeds[0][1]);
                    for ($j = 1; $j < count($tmp); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                        $results[$c]['class'] .= '\\'.$tmp[$j];
                    }
                } else {
                    // for php 7.x
                    for ($j = 1; $j < count($importeds); $j++) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
                        $results[$c]['class'] .= $importeds[$j][1];
                    }
                }

                $results[$c]['line'] = $row[2];
            }
            $c++;
        }

        return [$results, $namespace];
    }
}


1		<?php
2
3		namespace Imanghafoori\LaravelMicroscope\Analyzers;
4
5		use Illuminate\Support\Str;
6
7		class Expander
8		{
9		/**
10		* @param string $type
11		*
12		* @return bool
13		*/
14		public static function isBuiltinType($type)
15		{
16		return \in_array(strtolower($type), [
17		'self',
18		'static',
19		'parent',
20		], true);
21		}
22
23		public static function expendReferences($classes, $imports)
24		{
25		// here we implode the tokens to form the full namespaced class path
26		$results = [];
27		$namespace = '';
28		$c = 0;
29		foreach ($classes as $importeds) {
30		if ($importeds[0][0] == T_NAMESPACE) {
31		unset($importeds[0]);
32		foreach ($importeds as $row) {
33		$namespace .= $row[1];
34		}
35		continue;
36		}
37
38		$results[$c]['class'] = '';
39
40		// attach the current namespace if it does not begin with '\'
41		if ($importeds[0][1][0] != '\\') {
42		$results[$c]['class'] = $namespace ? $namespace.'\\' : '';
43		}
44
45		foreach ($importeds as $row) {
46		if (self::isBuiltinType($row[1])) {
47		unset($results[$c]);
48		continue;
49		}
50
51		// if starts with "\" or is not imported by the "use"
52		if ($importeds[0][1][0] != '\\' && Str::contains($importeds[0][1], '\\')) {
53		// for php 8.x
54		$tmp = explode('\\', $importeds[0][1]);
55		} else {
56		$tmp = [$importeds[0][1]];
57		}
58
59		if ($importeds[0][1] == '\\' \|\| ! isset(array_values($imports)[0][$tmp[0]][0])) {
60		$results[$c]['class'] .= $row[1];
61		$results[$c]['line'] = $row[2];
62		continue;
63		}
64
65		// reads the import from the top
66		$results[$c]['class'] = array_values($imports)[0][$tmp[0]][0];
67
68		// for half imported references
69		if ($importeds[0][1][0] != '\\' && Str::contains($importeds[0][1], '\\')) {
70		// for php 8.x
71		$tmp = explode('\\', $importeds[0][1]);
72	View Code Duplication	for ($j = 1; $j < count($tmp); $j++) {
		0 ignored issues – show Performance Best Practice introduced 2020-09-15 07:18 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history... Duplication introduced 2021-06-05 20:05 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		$results[$c]['class'] .= '\\'.$tmp[$j];
74		}
75		} else {
76		// for php 7.x
77	View Code Duplication	for ($j = 1; $j < count($importeds); $j++) {
		0 ignored issues – show Performance Best Practice introduced 2021-06-05 20:05 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history... Duplication introduced 2021-06-05 20:05 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		$results[$c]['class'] .= $importeds[$j][1];
79		}
80		}
81
82		$results[$c]['line'] = $row[2];
83		}
84		$c++;
85		}
86
87		return [$results, $namespace];
88		}
89		}
90

imanghafoori1 / laravel-microscope

Push — master ( 30255f...a24543 )

Expander::expendReferences() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like