LogsErrors::finishCommand() - Code Metrics - imanghafoori1/laravel-microscope - Measure and Improve Code Quality continuously with Scrutinizer

LogsErrors::finishCommand() A
last analyzed 2021-06-25 21:33 UTC

↳ Parent: LogsErrors

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	4
nop	1
dl	0
loc	18
rs	9.3554
c	0
b	0
f	0

<?php

namespace Imanghafoori\LaravelMicroscope\Traits;

use Illuminate\Support\Str;
use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;

trait LogsErrors
{
    /**
     * Shows the status of a successful or failed check.
     *
     * @param  ErrorPrinter  $errorPrinter
     */
    protected function finishCommand(ErrorPrinter $errorPrinter)
    {
        $commandName = class_basename($this);
        $commandType = Str::after($commandName, 'Check');
        $commandType = strtolower($commandType);

        if (! $errorPrinter->logErrors) {
            return;
        }

        if (($errorCount = $errorPrinter->hasErrors()) || $errorPrinter->pended) {

            $errorCount && $this->warn(PHP_EOL.$errorCount.' errors found for '.$commandType);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

            $errorPrinter->logErrors();
        } else {
            $this->info(PHP_EOL.'All '.$commandType.' are correct!');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1			<?php
2
3			namespace Imanghafoori\LaravelMicroscope\Traits;
4
5			use Illuminate\Support\Str;
6			use Imanghafoori\LaravelMicroscope\ErrorReporters\ErrorPrinter;
7
8			trait LogsErrors
9			{
10			/**
11			* Shows the status of a successful or failed check.
12			*
13			* @param ErrorPrinter $errorPrinter
14			*/
15			protected function finishCommand(ErrorPrinter $errorPrinter)
16			{
17			$commandName = class_basename($this);
18			$commandType = Str::after($commandName, 'Check');
19			$commandType = strtolower($commandType);
20
21			if (! $errorPrinter->logErrors) {
22			return;
23			}
24
25			if (($errorCount = $errorPrinter->hasErrors()) \|\| $errorPrinter->pended) {
			0 ignored issues – show Bug Best Practice introduced 2020-06-01 16:22 UTC by Report Bug Copy Issue Report The expression `$errorPrinter->pended` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
26			$errorCount && $this->warn(PHP_EOL.$errorCount.' errors found for '.$commandType);
			0 ignored issues – show Bug introduced 2021-02-12 23:00 UTC by Report Bug Copy Issue Report It seems like `warn()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
27
28			$errorPrinter->logErrors();
29			} else {
30			$this->info(PHP_EOL.'All '.$commandType.' are correct!');
			0 ignored issues – show Bug introduced 2020-04-09 12:04 UTC by Report Bug Copy Issue Report It seems like `info()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31			}
32			}
33			}
34

imanghafoori1 / laravel-microscope

LogsErrors::finishCommand() A last analyzed 2021-06-25 21:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

LogsErrors::finishCommand() A
last analyzed 2021-06-25 21:33 UTC