RouteSituations::getNormalizedArgs() - Code Metrics - Inspection of "Apply fixes from StyleCI" - imanghafoori1/laravel-heyman - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#47)

by Iman

created 2018-08-31 10:05 UTC

RouteSituations::getNormalizedArgs() A

↳ Parent: RouteSituations

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	14
ccs	9
cts	9
cp	1
rs	10
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3

<?php

namespace Imanghafoori\HeyMan\Situations;

use Imanghafoori\HeyMan\Normilizers\RouteNormalizer;
use Imanghafoori\HeyMan\WatchingStrategies\RouterEventManager;

class RouteSituations extends BaseSituation
{
    public function hasMethod($method)
    {
        return in_array($method, [
            'whenYouVisitUrl',
            'whenYouSendPost',
            'whenYouSendPatch',
            'whenYouSendPut',
            'whenYouSendDelete',
            'whenYouCallAction',
            'whenYouHitRouteName',
        ]);
    }

    public function __call($method, $args)
    {
        $method = str_replace('whenYou', '', $method);
        $args = $this->getNormalizedArgs($method, $args);
        $this->chain->eventManager = app(RouterEventManager::class)->init($args);

    }

    /**
     * @param $method
     * @param $args
     *
     * @return array
     */
    private function getNormalizedArgs($method, $args): array
    {
        $normalizer = app(RouteNormalizer::class);
        if ($method == 'CallAction') {
            return $normalizer->normalizeAction($args);
        }
        if ($method == 'HitRouteName') {
            return $args;
        }

        $method = str_replace('VisitUrl', 'SendGet', $method);
        $method = str_replace('Send', '', $method);

        return $normalizer->normalizeUrl($args, strtoupper($method));
    }
}


1		<?php
2
3		namespace Imanghafoori\HeyMan\Situations;
4
5		use Imanghafoori\HeyMan\Normilizers\RouteNormalizer;
6		use Imanghafoori\HeyMan\WatchingStrategies\RouterEventManager;
7
8		class RouteSituations extends BaseSituation
9		{
10	103	public function hasMethod($method)
11		{
12	103	return in_array($method, [
13	103	'whenYouVisitUrl',
14		'whenYouSendPost',
15		'whenYouSendPatch',
16		'whenYouSendPut',
17		'whenYouSendDelete',
18		'whenYouCallAction',
19		'whenYouHitRouteName',
20		]);
21		}
22
23	58	public function __call($method, $args)
24		{
25	58	$method = str_replace('whenYou', '', $method);
26	58	$args = $this->getNormalizedArgs($method, $args);
27	58	$this->chain->eventManager = app(RouterEventManager::class)->init($args);
		0 ignored issues – show Documentation Bug introduced 2018-08-31 10:14 UTC by Report Bug Copy Issue Report It seems like `app(Imanghafoori\HeyMan\...er::class)->init($args)` of type `Imanghafoori\HeyMan\Watc...gies\RouterEventManager` is incompatible with the declared type `Imanghafoori\HeyMan\ListenerApplier` of property `$eventManager`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
28	58	}
29
30		/**
31		* @param $method
32		* @param $args
33		*
34		* @return array
35		*/
36	58	private function getNormalizedArgs($method, $args): array
37		{
38	58	$normalizer = app(RouteNormalizer::class);
39	58	if ($method == 'CallAction') {
40	10	return $normalizer->normalizeAction($args);
41		}
42	51	if ($method == 'HitRouteName') {
43	11	return $args;
44		}
45
46	40	$method = str_replace('VisitUrl', 'SendGet', $method);
47	40	$method = str_replace('Send', '', $method);
48
49	40	return $normalizer->normalizeUrl($args, strtoupper($method));
50		}
51		}
52

imanghafoori1 / laravel-heyman

Pull Request — master (#47)

RouteSituations::getNormalizedArgs() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like