Imanghafoori\HeyMan\Hooks\EloquentHooks

Complexity

Total Complexity

6

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	whenYouSave()	0	5	1
A	whenYouFetch()	0	5	1
A	authorizeModel()	0	5	1
A	whenYouCreate()	0	5	1
A	whenYouUpdate()	0	5	1
A	whenYouDelete()	0	5	1

<?php

namespace Imanghafoori\HeyMan\Hooks;

use Imanghafoori\HeyMan\EloquentConditionApplier;
use Imanghafoori\HeyMan\YouShouldHave;

trait EloquentHooks
{
    /**
     * @param mixed ...$model
     *
     * @return YouShouldHave
     */
    public function whenYouFetch(...$model)
    {
        $model = $this->normalizeInput($model);

It seems like normalizeInput() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        return $this->authorizeModel('retrieved', $model);
    }

    /**
     * @param mixed ...$model
     *
     * @return YouShouldHave
     */
    public function whenYouCreate(...$model)
    {
        $model = $this->normalizeInput($model);

        return $this->authorizeModel('creating', $model);
    }

    /**
     * @param mixed ...$model
     *
     * @return YouShouldHave
     */
    public function whenYouUpdate(...$model)
    {
        $model = $this->normalizeInput($model);

        return $this->authorizeModel('updating', $model);
    }

    /**
     * @param mixed ...$model
     *
     * @return YouShouldHave
     */
    public function whenYouSave(...$model)
    {
        $model = $this->normalizeInput($model);

        return $this->authorizeModel('saving', $model);
    }

    /**
     * @param mixed ...$model
     *
     * @return YouShouldHave
     */
    public function whenYouDelete(...$model)
    {
        $model = $this->normalizeInput($model);

        return $this->authorizeModel('deleting', $model);
    }

    private function authorizeModel($event, $modelClass)
    {
        $this->authorizer = app(EloquentConditionApplier::class)->init($event, $modelClass);

The property authorizer does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        return app(YouShouldHave::class);
    }
}