CheckExpectations::sendRequest() - Code Metrics - Inspection of "Merge pull request #69 from imanghafoori1/analysis..." - imanghafoori1/laravel-heyman - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( c88fe1...950be2 )

by Iman

created 2018-10-12 17:26 UTC

CheckExpectations::sendRequest() A

↳ Parent: CheckExpectations

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	11
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0
cc	3
nc	2
nop	0
crap	3

<?php

namespace Imanghafoori\HeyMan\MakeSure;

class CheckExpectations
{
    private $chain;

    private $phpunit;

    /**
     * CheckExpectations constructor.
     *
     * @param $chain
     * @param $phpunit
     */
    public function __construct(Chain $chain, $phpunit)
    {
        $this->chain = $chain;
        $this->phpunit = $phpunit;
    }

    public function check()
    {
        $this->expectExceptions();
        $this->fireEvents();
        $this->checkResponse();
    }

    private function checkResponse()
    {
        if (!$this->chain->http) {

            return;
        }
        $this->checkResponses($this->sendRequest());
    }

    /**
     * @return mixed
     */
    private function sendRequest()
    {
        $method = $this->chain->http['method'];
        $data = $this->chain->http;
        if ($method == 'get' or $method == 'getJson') {
            $response = $this->phpunit->$method($data['uri'], $data['headers']);
        } else {
            $response = $this->phpunit->$method($data['uri'], $data['data'], $data['headers']);
        }

        return $response;
    }

    /**
     * @param $response
     */
    private function checkResponses($response)
    {
        foreach ($this->chain->assertion as $assertion) {
            $type = $assertion['type'];
            $response->$type($assertion['value']);
        }
    }

    private function fireEvents()
    {
        if ($this->chain->event) {
            event($this->chain->event);
        }
    }

    private function expectExceptions()
    {
        if ($this->chain->exception) {
            $this->phpunit->expectException($this->chain->exception);
        }
    }
}


1		<?php
2
3		namespace Imanghafoori\HeyMan\MakeSure;
4
5		class CheckExpectations
6		{
7		private $chain;
8
9		private $phpunit;
10
11		/**
12		* CheckExpectations constructor.
13		*
14		* @param $chain
15		* @param $phpunit
16		*/
17	39	public function __construct(Chain $chain, $phpunit)
18		{
19	39	$this->chain = $chain;
20	39	$this->phpunit = $phpunit;
21	39	}
22
23	39	public function check()
24		{
25	39	$this->expectExceptions();
26	39	$this->fireEvents();
27	38	$this->checkResponse();
28	38	}
29
30	38	private function checkResponse()
31		{
32	38	if (!$this->chain->http) {
		0 ignored issues – show Bug Best Practice introduced 2018-09-14 17:19 UTC by Report Bug Copy Issue Report The expression `$this->chain->http` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
33	1	return;
34		}
35	37	$this->checkResponses($this->sendRequest());
36	37	}
37
38		/**
39		* @return mixed
40		*/
41	37	private function sendRequest()
42		{
43	37	$method = $this->chain->http['method'];
44	37	$data = $this->chain->http;
45	37	if ($method == 'get' or $method == 'getJson') {
46	27	$response = $this->phpunit->$method($data['uri'], $data['headers']);
47		} else {
48	10	$response = $this->phpunit->$method($data['uri'], $data['data'], $data['headers']);
49		}
50
51	37	return $response;
52		}
53
54		/**
55		* @param $response
56		*/
57	37	private function checkResponses($response)
58		{
59	37	foreach ($this->chain->assertion as $assertion) {
60	29	$type = $assertion['type'];
61	29	$response->$type($assertion['value']);
62		}
63	37	}
64
65	39	private function fireEvents()
66		{
67	39	if ($this->chain->event) {
68	1	event($this->chain->event);
69		}
70	38	}
71
72	39	private function expectExceptions()
73		{
74	39	if ($this->chain->exception) {
75	1	$this->phpunit->expectException($this->chain->exception);
76		}
77	39	}
78		}
79

imanghafoori1 / laravel-heyman

Push — master ( c88fe1...950be2 )

CheckExpectations::sendRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like