ChainManager::get() - Code Metrics - Inspection of "refactor" - imanghafoori1/laravel-heyman - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f43d04...c61266 )

by Iman

created 2018-10-21 20:31 UTC

ChainManager::get() A

↳ Parent: ChainManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace Imanghafoori\HeyMan;

use Imanghafoori\HeyMan\Reactions\ReactionFactory;

class ChainManager
{
    /**
     * @var \Imanghafoori\HeyMan\Chain
     */
    private $chain;

    public function startChain()
    {
        $this->chain = new Chain();
        $this->chain->chainInfo = [

            'beforeReaction' => [],
            'debugInfo'      => ['file' => '', 'line' => '', 'args' => ''],
            'responseType'   => 'nothing',
            'data'           => [],
        ];
    }

    public function submitChainConfig()
    {
        $callbackListener = resolve(ReactionFactory::class)->make();
        $this->get('eventManager')->commitChain($callbackListener);
    }

    public function commitCalledMethod($args, $methodName)
    {
        $this->push('data', $args);
        $this->set('responseType', $methodName);
    }

    public function get($key)
    {
        return $this->chain->chainInfo[$key] ?? null;
    }

    public function set($key, $value)
    {
        $this->chain->chainInfo[$key] = $value;
    }

    public function push($key, $value)
    {
        $this->chain->chainInfo[$key][] = $value;
    }
}


1			<?php
2
3			namespace Imanghafoori\HeyMan;
4
5			use Imanghafoori\HeyMan\Reactions\ReactionFactory;
6
7			class ChainManager
8			{
9			/**
10			* @var \Imanghafoori\HeyMan\Chain
11			*/
12			private $chain;
13
14			public function startChain()
15			{
16			$this->chain = new Chain();
17			$this->chain->chainInfo = [
			0 ignored issues – show Documentation Bug introduced 2018-10-21 20:37 UTC by Report Bug Copy Issue Report It seems like `array('beforeReaction' =...ng', 'data' => array())` of type `array<string,array\|array<string,string>\|string>` is incompatible with the declared type `Imanghafoori\HeyMan\ListenerApplier` of property `$chainInfo`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
18			'beforeReaction' => [],
19			'debugInfo' => ['file' => '', 'line' => '', 'args' => ''],
20			'responseType' => 'nothing',
21			'data' => [],
22			];
23			}
24
25			public function submitChainConfig()
26			{
27			$callbackListener = resolve(ReactionFactory::class)->make();
28			$this->get('eventManager')->commitChain($callbackListener);
29			}
30
31			public function commitCalledMethod($args, $methodName)
32			{
33			$this->push('data', $args);
34			$this->set('responseType', $methodName);
35			}
36
37			public function get($key)
38			{
39			return $this->chain->chainInfo[$key] ?? null;
40			}
41
42			public function set($key, $value)
43			{
44			$this->chain->chainInfo[$key] = $value;
45			}
46
47			public function push($key, $value)
48			{
49			$this->chain->chainInfo[$key][] = $value;
50			}
51			}
52

imanghafoori1 / laravel-heyman

Push — master ( f43d04...c61266 )

ChainManager::get() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like