Imanghafoori\HeyMan\Plugins\Reactions\WeRespondFrom

Complexity

Total Complexity

2

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	respondFrom()	0	4	1
A	weRespondFrom()	0	5	1

<?php

namespace Imanghafoori\HeyMan\Plugins\Reactions;

use Illuminate\Http\Exceptions\HttpResponseException;
use Imanghafoori\HeyMan\Core\BaseReaction;
use Imanghafoori\HeyMan\Reactions\Then;

final class WeRespondFrom extends BaseReaction
{
    public function weRespondFrom($callback, array $parameters = [])
    {
        $this->commit(func_get_args(), [static::class, 'respondFrom']);

        return new Then($this);
    }

    public static function respondFrom($method)
    {
        return function () use ($method) {
            throw new HttpResponseException(app()->call(...$method));

$method is expanded, but the parameter $callback of Illuminate\Container\Container::call() does not expect variable arguments.

It seems like app()->call($method) can also be of type callable; however, parameter $response of Illuminate\Http\Exceptions\HttpResponseException::__construct() does only seem to accept Symfony\Component\HttpFoundation\Response, maybe add an additional type check?

        };
    }
}