BaseEloquentOverrides::morphToMany() - Code Metrics - Inspection of "refactor to have less overrides" - imanghafoori1/eloquent-relativity - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ac9ebe...25a070 )

by Iman

created 2019-10-22 08:17 UTC

BaseEloquentOverrides::morphToMany() B

↳ Parent: Project

Complexity

Conditions	7
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	7

Importance

Changes

Metric	Value
dl	0
loc	26
ccs	10
cts	10
cp	1
rs	8.5706
c	0
b	0
f	0
cc	7
nc	16
nop	9
crap	7

How to fix Many Parameters

<?php

namespace Imanghafoori\Relativity;

trait BaseEloquentOverrides
{
    protected function guessBelongsToManyRelation()
    {
        $debug = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);

        $name = $debug[1]['args'][8] ?? $debug[2]['function'];

        if ($name == "morphedByMany") {
            $name = $debug[2]['args'][7] ?? debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 4)[3]['function'];
        }

        return $name;
    }

    public function getRelationValue($key)
    {
        // If the key already exists in the relationships array, it just means the
        // relationship has already been loaded, so we'll just return it out of
        // here because there is no need to query within the relations twice.
        if ($this->relationLoaded($key)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return $this->relations[$key];
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        // If the "attribute" exists as a method on the model, we will just assume
        // it is a relationship and will load and return results from the query
        // and hydrate the relationship's value on the "relationships" array.
        if (method_exists($this, $key) or isset(static::$dynamicRelations[$key])) {
            return $this->getRelationshipFromMethod($key);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }
}


1		<?php
2
3		namespace Imanghafoori\Relativity;
4
5		trait BaseEloquentOverrides
6		{
7	1	protected function guessBelongsToManyRelation()
8		{
9	1	$debug = debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 3);
10
11	1	$name = $debug[1]['args'][8] ?? $debug[2]['function'];
12
13	1	if ($name == "morphedByMany") {
14	1	$name = $debug[2]['args'][7] ?? debug_backtrace(DEBUG_BACKTRACE_PROVIDE_OBJECT, 4)[3]['function'];
15		}
16
17	1	return $name;
18		}
19
20	5	public function getRelationValue($key)
21		{
22		// If the key already exists in the relationships array, it just means the
23		// relationship has already been loaded, so we'll just return it out of
24		// here because there is no need to query within the relations twice.
25	5	if ($this->relationLoaded($key)) {
		0 ignored issues – show Bug introduced 2019-05-17 08:03 UTC by Report Bug Copy Issue Report It seems like `relationLoaded()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26	1	return $this->relations[$key];
		0 ignored issues – show Bug introduced 2019-05-17 07:36 UTC by Report Bug Copy Issue Report The property `relations` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
27		}
28
29		// If the "attribute" exists as a method on the model, we will just assume
30		// it is a relationship and will load and return results from the query
31		// and hydrate the relationship's value on the "relationships" array.
32	5	if (method_exists($this, $key) or isset(static::$dynamicRelations[$key])) {
33	5	return $this->getRelationshipFromMethod($key);
		0 ignored issues – show Bug introduced 2019-05-17 08:03 UTC by Report Bug Copy Issue Report It seems like `getRelationshipFromMethod()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
34		}
35		}
36		}
37

imanghafoori1 / eloquent-relativity

Push — master ( ac9ebe...25a070 )

BaseEloquentOverrides::morphToMany() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like